On Mon, Sep 12, 2011 at 8:53 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Monday 12 September 2011 16:05:59, Abhijit Halder wrote:
>> I have seen in one place (write_exp_elt) that we are passing an union
>> by value and not by reference.
>> Please let me know whether we do have any specific reason of doing
>> that. I am submitting the patch as an attachment. Please review the
>> same.
>>
>
> See <http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2011-09&msgid=CAOhZP9xK6f%3D96Gxj2To-ktVK7qA1k%3DWek7hX-FMwq8u75KsDyw%40mail.gmail.com>:
>
> --0016364d2c7965a8ac04acbfddf0
> Content-Type: application/octet-stream; name=patch
> Content-Disposition: attachment; filename=patch
> Content-Transfer-Encoding: base64
> X-Attachment-Id: f_gshl4bmu0
>
> Please teach your browser to attach files to gmail as
> some text based content type, like patch/diff or
> text/x-patch.  It may just be a matter of renaming
> the files to have a ".diff" or ".patch" extension before
> attaching them.  If not, you may need to teach your browser
> about the mime type of .diff/.patch.
>
> You can see which mime type gmail gives your patch
> before actually sending the email.  Just let gmail complete
> the patch upload, and you should then see something like
>
> [X] foo.diff (text/x-patch) 5K
>
> It also affects the mail archives, check the difference,
> both sent from gmail with files attached:
>
>  <http://sourceware.org/ml/gdb-patches/2011-09/msg00192.html>
>  <http://sourceware.org/ml/gdb-patches/2011-08/msg00570.html>
>
> (follow the "Raw text" link too)
>
> --
> Pedro Alves
>

Sorry for this blunder!
Re-submitting this once again with corrected file extension.

Thanks,
Abhijit Halder