From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26206 invoked by alias); 2 Oct 2011 08:14:52 -0000 Received: (qmail 26193 invoked by uid 22791); 2 Oct 2011 08:14:48 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pz0-f49.google.com (HELO mail-pz0-f49.google.com) (209.85.210.49) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 Oct 2011 08:14:26 +0000 Received: by pzk34 with SMTP id 34so8355418pzk.8 for ; Sun, 02 Oct 2011 01:14:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.208.231 with SMTP id mh7mr17500071pbc.13.1317540105383; Sun, 02 Oct 2011 00:21:45 -0700 (PDT) Received: by 10.142.90.3 with HTTP; Sun, 2 Oct 2011 00:21:45 -0700 (PDT) Date: Sun, 02 Oct 2011 08:14:00 -0000 Message-ID: Subject: [PATCH] PR-10034 Bad space handling in `set remote exec-file' command. From: Abhijit Halder To: "gdb-patches@sourceware.org ml" Content-Type: multipart/mixed; boundary=14dae9c09a8cf570ea04ae4bb5c7 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00015.txt.bz2 --14dae9c09a8cf570ea04ae4bb5c7 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 361 Hi, In the `set remote exec-file' command if we provide space at the end of the file-name, the space is not being chopped off and being considered as part of file-name. This behavior is inconsistent across similar set commands like `set logging file' etc. My patch will fix that problem. Please review this patch and put your comments. Thanks, Abhijit Halder --14dae9c09a8cf570ea04ae4bb5c7 Content-Type: text/plain; charset=US-ASCII; name="ChangeLog.txt" Content-Disposition: attachment; filename="ChangeLog.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt9pbuok0 Content-length: 249 MjAxMS0wOS0xMyAgQWJoaWppdCBIYWxkZXIgIDxhYmhpaml0LmsuaGFsZGVy QGdtYWlsLmNvbT4KCglGaXggUFIgcmVtb3RlLzEwMDM0OgoJKiBjbGkvY2xp LXNldHNob3cuYyAoZG9fc2V0c2hvd19jb21tYW5kKTogQ2xlYXIgdHJhaWxp bmcgd2hpdGVzcGFjZQoJZnJvbSBjb21tYW5kIGFyZ3VtZW50IHN0cmluZ3Mu Cg== --14dae9c09a8cf570ea04ae4bb5c7 Content-Type: application/octet-stream; name="gdb-space-issue.patch" Content-Disposition: attachment; filename="gdb-space-issue.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt9pc4pp1 Content-length: 2758 SW5kZXg6IGdkYi9jbGkvY2xpLXNldHNob3cuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2NsaS9jbGktc2V0 c2hvdy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQ2CmRpZmYgLWEgLXAg LXUgLXIxLjQ2IGNsaS1zZXRzaG93LmMKLS0tIGdkYi9jbGkvY2xpLXNldHNo b3cuYwk0IEF1ZyAyMDExIDE5OjEwOjEzIC0wMDAwCTEuNDYKKysrIGdkYi9j bGkvY2xpLXNldHNob3cuYwkyOSBTZXAgMjAxMSAwNzozOTo0NSAtMDAwMApA QCAtMTc3LDE1ICsxNzcsMTggQEAgZG9fc2V0c2hvd19jb21tYW5kIChjaGFy ICphcmcsIGludCBmcm9tXwogCSAgfQogCSAgYnJlYWs7CiAJY2FzZSB2YXJf c3RyaW5nX25vZXNjYXBlOgotCSAgaWYgKGFyZyA9PSBOVUxMKQotCSAgICBh cmcgPSAiIjsKLQkgIGlmICgqKGNoYXIgKiopIGMtPnZhciAhPSBOVUxMKQot CSAgICB4ZnJlZSAoKihjaGFyICoqKSBjLT52YXIpOwotCSAgKihjaGFyICoq KSBjLT52YXIgPSB4c3RyZHVwIChhcmcpOwotCSAgYnJlYWs7CiAJY2FzZSB2 YXJfb3B0aW9uYWxfZmlsZW5hbWU6CiAJICBpZiAoYXJnID09IE5VTEwpCiAJ ICAgIGFyZyA9ICIiOworCSAgZWxzZQorCSAgICB7CisJICAgICAgLyogQ2xl YXIgdHJhaWxpbmcgd2hpdGVzcGFjZS4gICovCisJICAgICAgY2hhciAqcHRy ID0gYXJnICsgc3RybGVuIChhcmcpIC0gMTsKKworCSAgICAgIHdoaWxlIChw dHIgPj0gYXJnICYmICgqcHRyID09ICcgJyB8fCAqcHRyID09ICdcdCcpKQor CQlwdHItLTsKKwkgICAgICAqKHB0ciArIDEpID0gJ1wwJzsKKwkgICAgfQog CSAgaWYgKCooY2hhciAqKikgYy0+dmFyICE9IE5VTEwpCiAJICAgIHhmcmVl ICgqKGNoYXIgKiopIGMtPnZhcik7CiAJICAqKGNoYXIgKiopIGMtPnZhciA9 IHhzdHJkdXAgKGFyZyk7CkBAIC0xOTMsMTYgKzE5NiwxNyBAQCBkb19zZXRz aG93X2NvbW1hbmQgKGNoYXIgKmFyZywgaW50IGZyb21fCiAJY2FzZSB2YXJf ZmlsZW5hbWU6CiAJICBpZiAoYXJnID09IE5VTEwpCiAJICAgIGVycm9yX25v X2FyZyAoXygiZmlsZW5hbWUgdG8gc2V0IGl0IHRvLiIpKTsKKwkgIGVsc2UK KwkgICAgeworCSAgICAgIC8qIENsZWFyIHRyYWlsaW5nIHdoaXRlc3BhY2Uu ICAqLworCSAgICAgIGNoYXIgKnB0ciA9IGFyZyArIHN0cmxlbiAoYXJnKSAt IDE7CisKKwkgICAgICB3aGlsZSAocHRyID49IGFyZyAmJiAoKnB0ciA9PSAn ICcgfHwgKnB0ciA9PSAnXHQnKSkKKwkJcHRyLS07CisJICAgICAgKihwdHIg KyAxKSA9ICdcMCc7CisJICAgIH0KIAkgIGlmICgqKGNoYXIgKiopIGMtPnZh ciAhPSBOVUxMKQogCSAgICB4ZnJlZSAoKihjaGFyICoqKSBjLT52YXIpOwot CSAgewotCSAgICAvKiBDbGVhciB0cmFpbGluZyB3aGl0ZXNwYWNlIG9mIGZp bGVuYW1lLiAgKi8KLQkgICAgY2hhciAqcHRyID0gYXJnICsgc3RybGVuIChh cmcpIC0gMTsKLQotCSAgICB3aGlsZSAocHRyID49IGFyZyAmJiAoKnB0ciA9 PSAnICcgfHwgKnB0ciA9PSAnXHQnKSkKLQkgICAgICBwdHItLTsKLQkgICAg KihwdHIgKyAxKSA9ICdcMCc7Ci0JICB9CiAJICAqKGNoYXIgKiopIGMtPnZh ciA9IHRpbGRlX2V4cGFuZCAoYXJnKTsKIAkgIGJyZWFrOwogCWNhc2UgdmFy X2Jvb2xlYW46CkBAIC00MTksNyArNDIzLDcgQEAgY21kX3Nob3dfbGlzdCAo c3RydWN0IGNtZF9saXN0X2VsZW1lbnQgKgogICBmb3IgKDsgbGlzdCAhPSBO VUxMOyBsaXN0ID0gbGlzdC0+bmV4dCkKICAgICB7CiAgICAgICAvKiBJZiB3 ZSBmaW5kIGEgcHJlZml4LCBydW4gaXRzIGxpc3QsIHByZWZpeGluZyBvdXIg b3V0cHV0IGJ5IGl0cwotICAgICAgICAgcHJlZml4ICh3aXRoICJzaG93ICIg c2tpcHBlZCkuICAqLworCSBwcmVmaXggKHdpdGggInNob3cgIiBza2lwcGVk KS4gICovCiAgICAgICBpZiAobGlzdC0+cHJlZml4bGlzdCAmJiAhbGlzdC0+ YWJicmV2X2ZsYWcpCiAJewogCSAgc3RydWN0IGNsZWFudXAgKm9wdGlvbmxp c3RfY2hhaW4K --14dae9c09a8cf570ea04ae4bb5c7--