From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26384 invoked by alias); 16 Aug 2011 17:25:38 -0000 Received: (qmail 26334 invoked by uid 22791); 16 Aug 2011 17:25:37 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ew0-f41.google.com (HELO mail-ew0-f41.google.com) (209.85.215.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Aug 2011 17:25:22 +0000 Received: by ewy9 with SMTP id 9so68977ewy.0 for ; Tue, 16 Aug 2011 10:25:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.19.201 with SMTP id c9mr1070494ebb.0.1313515521070; Tue, 16 Aug 2011 10:25:21 -0700 (PDT) Received: by 10.213.33.142 with HTTP; Tue, 16 Aug 2011 10:25:21 -0700 (PDT) In-Reply-To: References: <20110813205053.GB22058@host1.jankratochvil.net> <20110814121407.GA29236@host1.jankratochvil.net> <83y5ywulun.fsf@gnu.org> <20110814170136.GA26819@host1.jankratochvil.net> <83sjp3vkze.fsf@gnu.org> <20110814195523.GA7588@host1.jankratochvil.net> <83bovptr1u.fsf@gnu.org> Date: Tue, 16 Aug 2011 17:25:00 -0000 Message-ID: Subject: Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell. [MinGW question] From: Abhijit Halder To: Eli Zaretskii Cc: jan.kratochvil@redhat.com, sergiodj@redhat.com, tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=000e0ce071940a555d04aaa2aa88 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00335.txt.bz2 --000e0ce071940a555d04aaa2aa88 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1509 On Tue, Aug 16, 2011 at 7:39 PM, Abhijit Halder wrote: > On Tue, Aug 16, 2011 at 7:08 PM, Eli Zaretskii wrote: >>> Date: Tue, 16 Aug 2011 18:15:19 +0530 >>> From: Abhijit Halder >>> Cc: Eli Zaretskii , sergiodj@redhat.com, tromey@redhat.co= m, >>> =A0 =A0 =A0 pedro@codesourcery.com, gdb-patches@sourceware.org >>> >>> --- src/gdb/NEWS =A0 =A0 =A02011-08-14 07:27:51.582233000 +0530 >>> +++ dst/gdb/NEWS =A0 =A0 =A02011-08-14 07:50:38.562234498 +0530 >>> @@ -64,6 +64,9 @@ >>> >>> =A0* New commands "info macros", and "info definitions" have been added. >>> >>> +* New command "pipe" has been added to make GDB command output availab= le to the >>> + =A0shell for processing. >>> + >>> =A0* Changed commands >> >> This part is okay. >> >>> +void >>> +_initialize_pipe (void) >>> +{ >>> + =A0add_cmd ("pipe", no_class, pipe_command, _("\ >>> +Create pipe to pass gdb-command output to the shell for processing.\n\ >>> +Arguments are a delimiter, followed by a gdb-command, then the same de= limiter \ >>> +again and finally a shell-command."), >> >> This doc string should say something about what can be the delimiter. >> >> What about the manual? =A0(Apologies if I already reviewed that part: >> this has been a very long thread.) > I have not yet got a chance to work on document part. I am currently > working on it. >> >> Thanks. >> > Added test-case for this new command. Please review this. Thanks, Abhijit Halder --000e0ce071940a555d04aaa2aa88 Content-Type: text/x-patch; charset=US-ASCII; name="gdb-pipe-command-testsuite.patch" Content-Disposition: attachment; filename="gdb-pipe-command-testsuite.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_grf54vf00 Content-length: 3762 ZGlmZiAtcnVwIHNyYy9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3BpcGUuYyBk c3QvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9waXBlLmMKLS0tIHNyYy9nZGIv dGVzdHN1aXRlL2dkYi5iYXNlL3BpcGUuYwkyMDExLTA4LTE2IDIyOjM3OjM3 Ljc4NTM1MTAwMSArMDUzMAorKysgZHN0L2dkYi90ZXN0c3VpdGUvZ2RiLmJh c2UvcGlwZS5jCTIwMTEtMDgtMTYgMjI6MzI6NDAuMjEzMzUwNzA5ICswNTMw CkBAIC0wLDAgKzEsMjcgQEAKKy8qIFRoaXMgdGVzdGNhc2UgaXMgcGFydCBv ZiBHREIsIHRoZSBHTlUgZGVidWdnZXIuCisKKyAgIENvcHlyaWdodCAyMDEx IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisgICBUaGlzIHBy b2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yIG1vZGlmeQorICAgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRo ZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkK KyAgIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJz aW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisgICAoYXQgeW91ciBvcHRpb24p IGFueSBsYXRlciB2ZXJzaW9uLgorCisgICBUaGlzIHByb2dyYW0gaXMgZGlz dHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwK KyAgIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRo ZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgICBNRVJDSEFOVEFCSUxJVFkgb3Ig RklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisg ICBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxz LgorCisgICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRo ZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICAgYWxvbmcgd2l0aCB0 aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3Jn L2xpY2Vuc2VzLz4uICAqLworCisjaW5jbHVkZSA8c3RkaW8uaD4KKworaW50 IG1haW4gKCkKK3sKKyNpZmRlZiB1c2VzdHVicworICBzZXRfZGVidWdfdHJh cHMgKCk7CisgIGJyZWFrcG9pbnQgKCk7CisjZW5kaWYKKyAgcmV0dXJuIDA7 IC8qIGVuZCBtYWluICovCit9CmRpZmYgLXJ1cCBzcmMvZ2RiL3Rlc3RzdWl0 ZS9nZGIuYmFzZS9waXBlLmV4cCBkc3QvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFz ZS9waXBlLmV4cAotLS0gc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvcGlw ZS5leHAJMjAxMS0wOC0xNiAyMjozNzo0NS45NjkzNTExMTkgKzA1MzAKKysr IGRzdC9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3BpcGUuZXhwCTIwMTEtMDgt MTYgMjI6MzU6MzQuMTE3MzU2NzgxICswNTMwCkBAIC0wLDAgKzEsNDkgQEAK KyMgICBDb3B5cmlnaHQgMjAxMSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24s IEluYy4KKworIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91 IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorIyBpdCB1bmRl ciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNl IGFzIHB1Ymxpc2hlZCBieQorIyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0 aW9uOyBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorIyAo YXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorIworIyBUaGlz IHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3 aWxsIGJlIHVzZWZ1bCwKKyMgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3 aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyMgTUVSQ0hB TlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NF LiAgU2VlIHRoZQorIyBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3Ig bW9yZSBkZXRhaWxzLgorIworIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQg YSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBh bG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2VlIDxodHRwOi8v d3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworIworIyB0ZXN0IGdkYiBwaXBl IGNvbW1hbmRzCisjCisKK2lmICR0cmFjZWxldmVsIHRoZW4geworICAgIHN0 cmFjZSAkdHJhY2VsZXZlbAorfQorCitzZXQgdGVzdGZpbGUgInBpcGUiCitz ZXQgc3JjZmlsZSAke3Rlc3RmaWxlfS5jCitzZXQgYmluZmlsZSAke29iamRp cn0vJHtzdWJkaXJ9LyR7dGVzdGZpbGV9CitpZiAgeyBbZ2RiX2NvbXBpbGUg IiR7c3JjZGlyfS8ke3N1YmRpcn0vJHtzcmNmaWxlfSIgIiR7YmluZmlsZX0i IGV4ZWN1dGFibGUge2RlYnVnfV0gIT0gIiIgfSB7CisgICAgdW50ZXN0ZWQg cGlwZS5leHAKKyAgICByZXR1cm4gLTEKK30KKworaWYgW2dldF9jb21waWxl cl9pbmZvICR7YmluZmlsZX1dIHsKKyAgICByZXR1cm4gLTEKK30KKworZ2Ri X2V4aXQKK2dkYl9zdGFydAorZ2RiX3JlaW5pdGlhbGl6ZV9kaXIgJHtzcmNk aXJ9LyR7c3ViZGlyfQorZ2RiX2xvYWQgJHtiaW5maWxlfQorCitzZXQgZW5k X21haW4gW2dkYl9nZXRfbGluZV9udW1iZXIgIiBlbmQgbWFpbiAiICRzcmNm aWxlXQorCitpZiAhW3J1bnRvX21haW5dIHRoZW4geworICAgIGZhaWwgIkNh bid0IHJ1biB0byBtYWluIgorICAgIHJldHVybiAwCit9CisKK2dkYl90ZXN0 ICJwaXBlIHwgYnQgfCBncmVwIFwibWFpblwiIiAiXCMwLiptYWluLiooKS4q YXQuKiR7c3JjZmlsZX06JHtlbmRfbWFpbn0iCisK --000e0ce071940a555d04aaa2aa88 Content-Type: application/octet-stream; name=ChangeLog Content-Disposition: attachment; filename=ChangeLog Content-Transfer-Encoding: base64 X-Attachment-Id: f_grf55lhs1 Content-length: 204 MjAxMS0wNy0yOSBBYmhpaml0IEhhbGRlciA8YWJoaWppdC5rLmhhbGRlckBn bWFpbC5jb20+CgoJVGVzdHN1aXRlIGZvciBgcGlwZScgY29tbWFuZC4KCgkq IGdkYi5iYXNlL3BpcGUuYzogTmV3IGZpbGUuCgkqIGdkYi5iYXNlL3BpcGUu ZXhwOiBOZXcgZmlsZS4K --000e0ce071940a555d04aaa2aa88--