From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17366 invoked by alias); 31 Aug 2011 12:42:49 -0000 Received: (qmail 17355 invoked by uid 22791); 31 Aug 2011 12:42:48 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_XC X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 12:42:32 +0000 Received: by wwe32 with SMTP id 32so590719wwe.12 for ; Wed, 31 Aug 2011 05:42:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.202.136 with SMTP id d8mr359251weo.52.1314794551092; Wed, 31 Aug 2011 05:42:31 -0700 (PDT) Received: by 10.216.22.75 with HTTP; Wed, 31 Aug 2011 05:42:31 -0700 (PDT) In-Reply-To: References: <201108301527.22683.pedro@codesourcery.com> <83y5yaepu4.fsf@gnu.org> Date: Wed, 31 Aug 2011 12:42:00 -0000 Message-ID: Subject: Re: [PATCH][TEST-CASE][DOC] Implementation of pipe to pass GDB's command output to the shell. From: Abhijit Halder To: Eli Zaretskii Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, sergiodj@redhat.com, jan.kratochvil@redhat.com, tromey@redhat.com Content-Type: multipart/mixed; boundary=0016e6dab1622ba53a04abcc76fa X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00652.txt.bz2 --0016e6dab1622ba53a04abcc76fa Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1100 On Wed, Aug 31, 2011 at 4:30 PM, Eli Zaretskii wrote: >> Date: Wed, 31 Aug 2011 14:13:49 +0530 >> From: Abhijit Halder >> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, sergiodj@redhat.= com, >> =A0 =A0 =A0 jan.kratochvil@redhat.com, tromey@redhat.com >> >> >> +@samp{print dd_tbl} is passed to the shell command @samp{sed 's/@}/\= n/g' | @ >> >> +grep ".test_dd" | tr ',' '\n'} for processing. >> > >> > I would suggest to add that the example does not use `|' as a >> > delimiter to allow the shell command to use it in its usual shell >> > semantics. >> > >> In the above example one can use `|' as the delimiter. it will not >> break anything syntactically but will not be readable much, hence I >> avoided using `|' as delimiter. Do we need to mention that here? > > We don't _have_ to mention that, but I think it's a good idea, because > the natural choice of the delimiter is the normal pipe character. > Okay I got it. Made that change, please comment on it. >> I made the corrections as suggested. Please review this: > > OK, thanks. > --0016e6dab1622ba53a04abcc76fa Content-Type: text/x-patch; charset=US-ASCII; name="gdb-pipe-command-doc.patch" Content-Disposition: attachment; filename="gdb-pipe-command-doc.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gs0aput50 Content-length: 3465 ZGlmZiAtcnVwIHNyYy9nZGIvZG9jL0NoYW5nZUxvZyBkc3QvZ2RiL2RvYy9D aGFuZ2VMb2cKLS0tIHNyYy9nZGIvZG9jL0NoYW5nZUxvZwkyMDExLTA4LTI3 IDIwOjM1OjM4LjQ1OTkzNDAyOSArMDUzMAorKysgZHN0L2dkYi9kb2MvQ2hh bmdlTG9nCTIwMTEtMDgtMzEgMTM6MzM6NTkuMTg4MTE4MDE2ICswNTMwCkBA IC0xLDMgKzEsNyBAQAorMjAxMS0wOC0yOSAgQWJoaWppdCBIYWxkZXIgIDxh Ymhpaml0LmsuaGFsZGVyQGdtYWlsLmNvbT4KKworCSogZ2RiLnRleGluZm8g KFNoZWxsIENvbW1hbmRzKTogQWRkIHBpcGUgY29tbWFuZC4KKwogMjAxMS0w OC0yNSAgQW5kcmV3IE9ha2xleSAgPGFuZHJld0BhZG8uaXMtYS1nZWVrLm5l dD4KIAogCSogZ2RiLnRleGluZm8gKFR5cGVzIEluIFB5dGhvbik6IERvY3Vt ZW50ICdiaXRwb3MnIGZvciBlbnVtcy4KZGlmZiAtcnVwIHNyYy9nZGIvZG9j L2dkYi50ZXhpbmZvIGRzdC9nZGIvZG9jL2dkYi50ZXhpbmZvCi0tLSBzcmMv Z2RiL2RvYy9nZGIudGV4aW5mbwkyMDExLTA4LTI2IDIxOjExOjM5LjkzODM1 NDAwNyArMDUzMAorKysgZHN0L2dkYi9kb2MvZ2RiLnRleGluZm8JMjAxMS0w OC0zMSAxODowNDoxMS4zNDgxMTgwNDIgKzA1MzAKQEAgLTEzNjcsNiArMTM2 Nyw1MiBAQCBFeGVjdXRlIHRoZSBAY29kZXttYWtlfSBwcm9ncmFtIHdpdGgg dGhlCiBhcmd1bWVudHMuICBUaGlzIGlzIGVxdWl2YWxlbnQgdG8gQHNhbXB7 c2hlbGwgbWFrZSBAdmFye21ha2UtYXJnc319LgogQGVuZCB0YWJsZQogCitJ ZiB5b3Ugd2FudCB0byBwcm9jZXNzIHRoZSBvdXRwdXQgb2YgYSBAdmFsdWV7 R0RCTn0gY29tbWFuZCB1c2luZyBzb21lIHNoZWxsCitjb21tYW5kIG9yIHNv bWUgc2NyaXB0LCB0aGF0IGNhbiBiZSBkb25lIGJ5IHVzaW5nIHRoZSBjb21t YW5kIEBjb2Rle3BpcGV9LgorCitAdGFibGUgQGNvZGUKK0BraW5kZXggcGlw ZQorQGl0ZW0gcGlwZSBAdmFye2RsaW19IEB2YXJ7Z2RiY21kfSBAdmFye2Rs aW19IEB2YXJ7c2hlbGxjbWR9CitAdmFye2RsaW19IGlzIGEgc3RyaW5nIG9m IGFyYml0cmFyeSBsZW5ndGgsIGNvbnRhaW5pbmcgbm8gd2hpdGVzcGFjZSBh bmQgbm8KK2xlYWRpbmcgQHNhbXB7LX0sIGFjdHMgYXMgYSBzZXBhcmF0b3Ig YmV0d2VlbiBhIEB2YWx1ZXtHREJOfSBjb21tYW5kCitAdmFye2dkYmNtZH0g YW5kIGEgc2hlbGwgY29tbWFuZCBAdmFye3NoZWxsY21kfS4gIFRoZSBzaGVs bCBjb21tYW5kIHNob3VsZCBiZQoraW4gY29tcGxpYW5jZSB3aXRoIHRoZSBz eW50YXggb2YgdGhlIGRlZmF1bHQgc2hlbGwuICBUaGUgQHZhcntkbGltfSBw YXR0ZXJuCitzaG91bGQgbm90IGFwcGVhciBpbiBAdmFye2dkYmNvbWR9IG90 aGVyd2lzZSB0aGUgcGFyc2luZyB3aWxsIGZhaWw7IGFsdGhvdWdoIGl0Citt YXkgYXBwZWFyIGluIEB2YXJ7c2hlbGxjbWR9LiAKK0BlbmQgdGFibGUKKwor QHNtYWxsZXhhbXBsZQorKEB2YWx1ZXtHREJQfSkgQGJ7cHR5cGUgZGRfdGJs fQordHlwZSA9IHN0cnVjdCBkZCBAeworICAgIGludCBkZF9oYW5kbGU7Cisg ICAgY29uc3QgY2hhciAqZGRfbmFtZTsKKyAgICBpbnQgZGRfbWFqb3I7Cisg ICAgaW50IGRkX21pbm9yOworICAgIHZvaWQgKmRkX2NvZGU7CisgICAgdm9p ZCAqZGRfZGF0YTsKK0B9IFsxMDI0XQorKEB2YWx1ZXtHREJQfSkgQGJ7cGlw ZSA8YnI+IHByaW50IGRkX3RibCA8YnI+IHNlZCAncy9AfS9cbi9nJyB8IGdy ZXAgQAorIlwudGVzdF9kZCIgfCB0ciAnLCcgJ1xuJ30KKworICBAe2RkX2hh bmRsZSA9IDEwCisgIGRkX25hbWUgPSAweDgwNDg1MzggIi50ZXN0X2RkIgor ICBkZF9tYWpvciA9IDEwMAorICBkZF9taW5vciA9IDAKKyAgZGRfY29kZSA9 IDB4Y2MKKyAgZGRfZGF0YSA9IDB4ODAKK0BlbmQgc21hbGxleGFtcGxlCisK K0luIHRoZSBhYm92ZSBleGFtcGxlIEBzYW1wezxicj59IGFjdHMgYXMgYSBk ZWxpbWl0ZXIuICBUaGUgb3V0cHV0IG9mCitAc2FtcHtwcmludCBkZF90Ymx9 IGlzIHBhc3NlZCB0byB0aGUgc2hlbGwgY29tbWFuZCBAc2FtcHtzZWQgJ3Mv QH0vXG4vZycgfCBACitncmVwICIudGVzdF9kZCIgfCB0ciAnLCcgJ1xuJ30g Zm9yIHByb2Nlc3NpbmcuICBAc2FtcHt8fSBjb3VsZCBiZSBvbmUgbmF0dXJh bAorY2hvaXNlIG9mIHVzaW5nIGFzIHRoZSBkZWxpbWl0ZXIuICBJbiB0aGUg YWJvdmUgd2UgYXZvaWRlZCB0aGUgc2FtZSBmb3IKK3JlYWRhYmlsaXR5IHB1 cnBvc2UuCisKK0luIHRoZSBnaXZlbiBleGFtcGxlIHRoZSBvdXRwdXQgb2Yg QHZhbHVle0dEQk59IGNvbW1hbmQgQHNhbXB7cHJpbnQgZGRfdGJsfSBpcwor aHVnZSBhbmQgbm90IHdlbGwgZm9ybWF0ZWQuICBUaGUgdXNlIG9mIHNoZWxs IGNvbW1hbmRzIGxpa2UgQGNvbW1hbmR7c2VkfSwKK0Bjb21tYW5ke3RyfSBh bmQgQGNvbW1hbmR7Z3JlcH0gZWFzZSB0aGUgc2VhcmNoaW5nIG9mIGRlc2ly ZWQgcGF0dGVybiBhbmQgaGVuY2UKK2Vhc2UgZGVidWdnaW5nLgorCiBAbm9k ZSBMb2dnaW5nIE91dHB1dAogQHNlY3Rpb24gTG9nZ2luZyBPdXRwdXQKIEBj aW5kZXggbG9nZ2luZyBAdmFsdWV7R0RCTn0gb3V0cHV0Cg== --0016e6dab1622ba53a04abcc76fa--