On Wed, Aug 31, 2011 at 4:30 PM, Eli Zaretskii wrote: >> Date: Wed, 31 Aug 2011 14:13:49 +0530 >> From: Abhijit Halder >> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, sergiodj@redhat.com, >>       jan.kratochvil@redhat.com, tromey@redhat.com >> >> >> +@samp{print dd_tbl} is passed to the shell command @samp{sed 's/@}/\n/g' | @ >> >> +grep ".test_dd" | tr ',' '\n'} for processing. >> > >> > I would suggest to add that the example does not use `|' as a >> > delimiter to allow the shell command to use it in its usual shell >> > semantics. >> > >> In the above example one can use `|' as the delimiter. it will not >> break anything syntactically but will not be readable much, hence I >> avoided using `|' as delimiter. Do we need to mention that here? > > We don't _have_ to mention that, but I think it's a good idea, because > the natural choice of the delimiter is the normal pipe character. > Okay I got it. Made that change, please comment on it. >> I made the corrections as suggested. Please review this: > > OK, thanks. >