From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107586 invoked by alias); 12 Mar 2015 00:25:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107571 invoked by uid 89); 12 Mar 2015 00:25:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-la0-f45.google.com Received: from mail-la0-f45.google.com (HELO mail-la0-f45.google.com) (209.85.215.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 12 Mar 2015 00:25:38 +0000 Received: by labge10 with SMTP id ge10so12413155lab.7 for ; Wed, 11 Mar 2015 17:25:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=qZSJefMjEag33O/FcdXXs21uCtzQcF0uh1qqgD2lvi4=; b=gtx5EheZu9bsn7T4La9/Yy4Vl3dnYhC872Yb6Ml7pXfXc3MdPLX2uKREu6eOAuNgX7 NhmjEC2r3PP/GLPG7j4XrIvw0NLLixytdwL+P2s7sU23iY6mtzC5So3rPKm/+unr8Q9Z LOKFId1SX7f7HWaifcGHQpTTRJjSo2gzQUfwdH+KjlNY4fcZ1qg18QnemBbwHrIHWR9A Bzy3wWfLHNIirNAHyCWsOgRHeHNbNKPYWALOu9VJgokHrQFj/xQhTtFs8EtrcH+qEVAk Oom47zGjQSfeLTBm+7uYkoRhX1+dnUuaISfepcz9u3MiY6ttiDeSn43fmHbuQrSHaa7j xMZA== X-Gm-Message-State: ALoCoQkQBoc4EerE+h57JHdQnKr6708xPK1/bFaNN4ty0s/k3ixwWtKLce+tVWX7Co0gpzZeXaJJ X-Received: by 10.152.87.115 with SMTP id w19mr31543705laz.66.1426119935421; Wed, 11 Mar 2015 17:25:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.52.42 with HTTP; Wed, 11 Mar 2015 17:24:55 -0700 (PDT) In-Reply-To: <21760.54598.126480.383468@ruffy2.mtv.corp.google.com> References: <1426097817-30955-1-git-send-email-martin.galvan@tallertechnologies.com> <21760.54598.126480.383468@ruffy2.mtv.corp.google.com> From: Martin Galvan Date: Thu, 12 Mar 2015 00:25:00 -0000 Message-ID: Subject: Re: [PATCH v2] Python API: Fix an exception when registering a global pretty-printer in verbose mode To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-03/txt/msg00329.txt.bz2 On Wed, Mar 11, 2015 at 8:52 PM, Doug Evans wrote: > LGTM, with two more nits. > The ChangeLog entry > 80 char limit :-), > and convention is to include the function name in the ChangeLog entry. > > E.g., > > 2015-03-11 Martin Galvan > > * python/lib/gdb/printing.py (register_pretty_printer): Fix exception > when registering a global pretty-printer in verbose mode. > > No need to repost though. > Ok to commit with that fixed. Thanks a lot! I'll keep that in mind for any future patches.