From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50013 invoked by alias); 29 Jun 2015 21:17:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49998 invoked by uid 89); 29 Jun 2015 21:16:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f42.google.com Received: from mail-la0-f42.google.com (HELO mail-la0-f42.google.com) (209.85.215.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 29 Jun 2015 21:16:58 +0000 Received: by lagx9 with SMTP id x9so140924096lag.1 for ; Mon, 29 Jun 2015 14:16:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=VHM/iMOdhqkY4K9TKMSrlUbjABfjjWnip8E4HG13pXM=; b=Mfpr3xyzZrC4+lx5j3hB9kuHVCR/RmhRq3fFr6TzJRMTpdRzM0vURPkrtiLMdZaDpM 8eqf3vH21XWgRX1U/6rIyh9iUUJUOyvYFPWRRFVkbo+qXELpf+RsU1y8432V9CKWrt9m 23wL85VrsOPyLhImc8736CzSh/JGY06e6lcxdhzNWYzSyS+N2wEdV4E9+zCzWrqMhYIr 1nCoKk2r2j21x47CXh2UrlAdcRfLjrb5JaV3UqyaX3VciyCePcBqkQmQumGBX/6knPPL MT5qjiOirbV3G/AYT9hZeXQksdCSLBP2B72qkHaW6tYGJY+oxyypntaxd9QHoZNMp7oO Q1Dg== X-Gm-Message-State: ALoCoQnwV5HepA6Inh8wSUzF0zk96oOps1WWdLQHLI5g4o2tMuXuVjMpjRSq3Nn1PlZVfcZQAyoY X-Received: by 10.112.180.201 with SMTP id dq9mr16594385lbc.78.1435612615469; Mon, 29 Jun 2015 14:16:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.144.7 with HTTP; Mon, 29 Jun 2015 14:16:15 -0700 (PDT) In-Reply-To: References: <1435464030-22372-1-git-send-email-martin.galvan@tallertechnologies.com> From: Martin Galvan Date: Mon, 29 Jun 2015 21:17:00 -0000 Message-ID: Subject: Re: [PATCH] testsuite: Remove the unneeded escaping of '[' and ']' characters in test_class_help To: Doug Evans Cc: Andreas Schwab , gdb-patches , Yao Qi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-06/txt/msg00613.txt.bz2 Is it ok to commit as it is, or should I change the comment to reflect what Andreas said? On Mon, Jun 29, 2015 at 11:03 AM, Doug Evans wrote: > On Sun, Jun 28, 2015 at 4:07 AM, Andreas Schwab w= rote: >> Martin Galvan writes: >> >>> +# Notice that the '[' and ']' characters don't need to be escaped for = strings >>> +# wrapped in {} braces. >> >> This isn't true in general, it's because this is a tcl list. The >> backslashes are removed when the list is passed through join in >> help_test_raw (which removes one level of quoting, but doesn't do >> command or variable expansion). But that also means that the backslash >> before '.' is ineffective and should be replaced by a double backslash. >> Alternatively, each element could be enclosed with braces which disables >> any quoting inside it. >> >>> proc test_class_help { command_class expected_initial_lines args } { >>> set l_stock_body { >>> - "List of commands\:.*\[\r\n\]+" >>> - "Type \"help\" followed by command name for full documentation= \.\[\r\n\]+" >>> - "Type \"apropos word\" to search for commands related to \"wor= d\"\.[\r\n\]+" >>> + "List of commands\:.*[\r\n]+" >> >> The backslash before ':' is useless. > > Thanks for the clarity. > We don't have to fix all issues in this patch, so the patch is fine with = me. --=20 Martin Galvan Software Engineer Taller Technologies Argentina San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: 54 351 4217888 / +54 351 4218211