From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30230 invoked by alias); 22 Apr 2015 19:36:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30218 invoked by uid 89); 22 Apr 2015 19:36:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL,TBC autolearn=no version=3.3.2 X-HELO: mail-lb0-f176.google.com Received: from mail-lb0-f176.google.com (HELO mail-lb0-f176.google.com) (209.85.217.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 22 Apr 2015 19:36:44 +0000 Received: by lbbzk7 with SMTP id zk7so188383528lbb.0 for ; Wed, 22 Apr 2015 12:36:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=3TOwbrTtyDmQFEsVsIhuwjpffiT+fSD/7ypt6OO3O2o=; b=c783xATIZxf5Upzwx3Fo1hjlLubQNMz79jPH2/mtkTuS+mZNPWe7/GAIl7bQCubDWm P0ifD7ZGLZtJXErU8fdpPO/QhI8eKiB+CjUlmJfSmCnZZ+9XmhxJBj0vn++RcGne7zNU gkW/c0MDiSz5y3w0eHFIFtFEErJCiCtSd0P+6BiGRY6xz//irpHLxd4TPHtI2xPN1Rrr hz0bx1YPJrzETVmNPGvswtCfjHGYpkEAo1SVc9SdAS0/i4E6oFncUqclojCy3r8su/YJ KgxTPq4QOEVl8y2VYami1RBAbw9BdpFWG7DKI+9VztXDa0/+5/F5Zpp5tIBwwZ2Tki4p bazw== X-Gm-Message-State: ALoCoQksC4xrugf6FAr2YdDtMmnCU4tSNbeCNkQe2nK0/mRnonxba9nZP4rr1+is2fbspC1eSxmi X-Received: by 10.152.203.201 with SMTP id ks9mr25369214lac.49.1429731400798; Wed, 22 Apr 2015 12:36:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.52.71 with HTTP; Wed, 22 Apr 2015 12:36:00 -0700 (PDT) In-Reply-To: References: <1429637147-5430-1-git-send-email-martin.galvan@tallertechnologies.com> From: Martin Galvan Date: Wed, 22 Apr 2015 19:36:00 -0000 Message-ID: Subject: Re: [PING][PATCH v3] Python API: Fix an exception when registering a global pretty-printer in verbose mode To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-04/txt/msg00839.txt.bz2 That's great. Thanks a lot! On Wed, Apr 22, 2015 at 4:35 PM, Doug Evans wrote: > On Tue, Apr 21, 2015 at 10:25 AM, Martin Galvan > wrote: >> This patch fixes a Python exception that was being thrown when trying to= register a global pretty-printer with verbose mode on: >> >> File "/usr/share/gdb/python/gdb/printing.py", line 119, in register_pr= etty_printer >> gdb.write("Registering global %s pretty-printer ...\n" % name) >> NameError: name 'name' is not defined >> >> This patch was previously accepted by Doug Evans (https://sourceware.org= /ml/gdb-patches/2015-03/msg00312.html), but it was never committed. >> >> I have a company-wide copyright assignment for gdb. I don't have commit = access though, so it would be great if anyone could commit this for me. Tha= nks a lot! >> >> Chamges in v3: >> * Added the function name to the ChangeLog entry, and wrapped it at 80 = characters. >> >> Changes in v2: >> * Moved printer.name to the next line so that it won't break the 80 cha= racter limit. >> >> -- >> ChangeLog: >> >> gdb/ >> 2015-04-16 Martin Galvan >> >> * python/lib/gdb/printing.py (register_pretty_printer): Fix exce= ption >> when registering a global pretty-printer in verbose mode. >> --- >> gdb/python/lib/gdb/printing.py | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/python/lib/gdb/printing.py b/gdb/python/lib/gdb/printin= g.py >> index e384e41..c935333 100644 >> --- a/gdb/python/lib/gdb/printing.py >> +++ b/gdb/python/lib/gdb/printing.py >> @@ -116,7 +116,8 @@ def register_pretty_printer(obj, printer, replace=3D= False): >> >> if obj is None: >> if gdb.parameter("verbose"): >> - gdb.write("Registering global %s pretty-printer ...\n" % na= me) >> + gdb.write("Registering global %s pretty-printer ...\n" % >> + printer.name) >> obj =3D gdb >> else: >> if gdb.parameter("verbose"): > > Hi. > Looking at the code again I found a couple more issues, > so I fixed those too and wrote a testcase. > > https://sourceware.org/ml/gdb-patches/2015-04/msg00837.html --=20 Martin Galvan Software Engineer Taller Technologies Argentina San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: 54 351 4217888 / +54 351 4218211