From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9390 invoked by alias); 12 Nov 2014 17:26:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9378 invoked by uid 89); 12 Nov 2014 17:26:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-qg0-f51.google.com Received: from mail-qg0-f51.google.com (HELO mail-qg0-f51.google.com) (209.85.192.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 12 Nov 2014 17:26:29 +0000 Received: by mail-qg0-f51.google.com with SMTP id j5so8933390qga.38 for ; Wed, 12 Nov 2014 09:26:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=NZKZalUQGJJmnLwFG5wnSdSDHtXbZYEeBO9hzI3llQA=; b=Bmh4EWFVt55/HaiyTZOGYEgPxVlsYr4VhtppoJu2FkApLpb/q8BZneAbdDyjEw7CRj F3G89+8AfejUUhRLRnH40oDEMM8K8O+UEkTnrZC8avM7dRLZtRxsxl0XWxXnAxno44DG f1UmMaokBOz8N7NfD/MewBwV+CZKcAMRt6gBIg6ZN2K568AWgzRB4yQcqt7ZYFWp35qB YgDaGB7CrouORnR1WI6zIqtNQgPwcNoAm6cfu2OmUKe0RW5GDKePhnP8m4+Ql7+HasKI YsvP+C3FAD4WbgnE1M+u5XPLsoo3e6Ixg3CV+DrWYgdZwkb3NwM2FgdgAigQuWupw9l8 jvnA== X-Gm-Message-State: ALoCoQm1qnFqCbiSfw4ViyVVxYtwEe96b5QEC+jrA+5K4BQHeo264O0JJGdjfrtDnyNOF+xOI10P MIME-Version: 1.0 X-Received: by 10.140.31.35 with SMTP id e32mr60002760qge.4.1415813187515; Wed, 12 Nov 2014 09:26:27 -0800 (PST) Received: by 10.140.34.65 with HTTP; Wed, 12 Nov 2014 09:26:27 -0800 (PST) In-Reply-To: <546396DC.1020803@redhat.com> References: <201411071727.sA7HRNIQ007851@d03av02.boulder.ibm.com> <546396DC.1020803@redhat.com> Date: Wed, 12 Nov 2014 17:26:00 -0000 Message-ID: Subject: Re: [PING][RFC][PATCH v2] Python API: add gdb.stack_may_be_invalid From: Martin Galvan To: Pedro Alves Cc: Doug Evans , Ulrich Weigand , gdb-patches , Eli Zaretskii , Daniel Gutson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-11/txt/msg00224.txt.bz2 On Wed, Nov 12, 2014 at 2:20 PM, Pedro Alves wrote: > On 11/12/2014 05:06 PM, Doug Evans wrote: >> >> Plus the name "stack is destroyed" is confusing. >> This function is just a wrapper around gdbarch_in_function_epilogue_p >> so I'd just call it in_function_epilogue_p (or >> gdbpy_in_function_epilogue_p or some such). > > Can we agree to rename the gdbarch hook instead? > The function does _not_ return whether the PC is in the epilogue. > > https://sourceware.org/ml/gdb-patches/2014-10/msg00590.html If everyone's ok with stack_frame_destroyed_p, I'll do the renaming myself and send it as a separate patch. --=20 Mart=C3=ADn Galv=C3=A1n Software Engineer Taller Technologies Argentina San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: 54 351 4217888 / +54 351 4218211