From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31173 invoked by alias); 22 Oct 2014 18:32:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31164 invoked by uid 89); 22 Oct 2014 18:32:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-lb0-f177.google.com Received: from mail-lb0-f177.google.com (HELO mail-lb0-f177.google.com) (209.85.217.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 22 Oct 2014 18:32:43 +0000 Received: by mail-lb0-f177.google.com with SMTP id w7so3272788lbi.8 for ; Wed, 22 Oct 2014 11:32:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=L6YAr2nFXfkCBcCByogFoCTdCqY5WS50oVuRWsjFFNI=; b=jNqlnU4BD5M4uuwNQuNkKnxmT1lGWATBWG7aLSLLt5hUwIvJ8UXKu//A1BbzjLUAwL DmkC3cjzCg836qwvXgju/9yetbDkwnI9pA0pnknNxXcUOA64goJjAwHfj7AOVDWqydJE mNY970FcdeA7zReR0S1lAxc/SpTx3DKqE6CZguy6+JCVFC6RtzdJnU28sHIUjGUje9X5 i2KbQjR0Cs2YmRHHe+E6N+NDvwXOjKIIei1ZBEUSEkbSerJGGQesL77ZdKBUSHGqT20w 55LG/1OvLgEDHFm+GxbnjhV9Oz2ZSYYXQ3azEUGSnt5upUfHZ6ZNmnQOh73oxJzJJgP+ cNxA== X-Gm-Message-State: ALoCoQlRnFBzbC9/llJsRb9CZ+xRjcMWP8BQKt4qJKQBOKdmAiVdAB1/Ii5Wl+k3NK+xdfHyaFeU MIME-Version: 1.0 X-Received: by 10.112.14.69 with SMTP id n5mr2527553lbc.34.1414002758682; Wed, 22 Oct 2014 11:32:38 -0700 (PDT) Received: by 10.112.59.129 with HTTP; Wed, 22 Oct 2014 11:32:38 -0700 (PDT) In-Reply-To: <83egu07zbu.fsf@gnu.org> References: <1413986485-4673-1-git-send-email-martin.galvan@tallertechnologies.com> <83tx2w87j0.fsf@gnu.org> <83fveg809v.fsf@gnu.org> <83egu07zbu.fsf@gnu.org> Date: Wed, 22 Oct 2014 18:32:00 -0000 Message-ID: Subject: Re: [PATCH] Python API: Add gdb.is_in_prologue and gdb.is_in_epilogue. From: Martin Galvan To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-10/txt/msg00587.txt.bz2 On Wed, Oct 22, 2014 at 3:07 PM, Eli Zaretskii wrote: > Having said all that, please don't read this as a rejection of your > code. Even if you agree with me, please wait for others to chime in > and say what they think, before acting on my opinions. > > Thanks. Don't worry about that. Looking at the documentation again, I think saying "functionStart [..] is the start address of the function you want to check if pc belongs to" is a bit misleading in this case. I think that paragraph should be changed to something like: "The optional @var{functionStart} argument is the start address of the function @var{pc} belongs to. If your binary doesn't have debugging info, @value{GDBN} will need to use this value to guess whether @var{pc} belongs to the prologue, otherwise it'll ignore it. Notice that in the latter case you can= pass any valid address as @var{functionStart}; the result will only depend on @var{pc} being in a prologue, even if it's not the prologue of the function starting= at @var{functionStart}." --=20 Mart=C3=ADn Galv=C3=A1n Software Engineer Taller Technologies Argentina San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: 54 351 4217888 / +54 351 4218211