From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Daniel Gutson <daniel.gutson@tallertechnologies.com>
Subject: Re: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq().
Date: Wed, 26 Nov 2014 01:19:00 -0000 [thread overview]
Message-ID: <CAOKbPbY5fQv5qKWwXcV3fwQgZ0Hx2D3hc-_amZGTv5LbdFSyQw@mail.gmail.com> (raw)
In-Reply-To: <87k32jc96x.fsf@redhat.com>
On Tue, Nov 25, 2014 at 5:32 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
>
> On Tuesday, November 25 2014, Martin Galvan wrote:
>
> > I noticed in frame_id_eq() we were checking for the "l" frame_id being invalid twice instead of checking both "l" and "r", so I corrected it.
>
> Hi Martin,
>
> Thanks for the patch. I guess it is obvious enough that it could be
> checked in without approval, but just to be safe, let's wait until a
> maintainer approves it. Meanwhile...
>
> > gdb/ChangeLog:
> >
> > 2014-11-25 Martin Galvan <martin.galvan@tallertechnologies.com>
> >
> > * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID.
>
> The indentation of this ChangeLog entry is wrong. You must use TAB
> instead of whitespaces to indent the "*" part.
My mistake. Will remember that for any new patches I send :)
--
Martín Galván
Software Engineer
Taller Technologies Argentina
San Lorenzo 47, 3rd Floor, Office 5
Córdoba, Argentina
Phone: 54 351 4217888 / +54 351 4218211
next prev parent reply other threads:[~2014-11-26 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 19:34 Martin Galvan
2014-11-25 20:33 ` Sergio Durigan Junior
2014-11-26 1:19 ` Martin Galvan [this message]
2014-11-30 15:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOKbPbY5fQv5qKWwXcV3fwQgZ0Hx2D3hc-_amZGTv5LbdFSyQw@mail.gmail.com \
--to=martin.galvan@tallertechnologies.com \
--cc=daniel.gutson@tallertechnologies.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox