From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27550 invoked by alias); 18 Nov 2011 16:13:24 -0000 Received: (qmail 27536 invoked by uid 22791); 18 Nov 2011 16:13:22 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Nov 2011 16:13:07 +0000 Received: by vcbfo1 with SMTP id fo1so2806489vcb.0 for ; Fri, 18 Nov 2011 08:13:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.222.211 with SMTP id ih19mr1578265qab.96.1321632785123; Fri, 18 Nov 2011 08:13:05 -0800 (PST) Received: by 10.229.136.19 with HTTP; Fri, 18 Nov 2011 08:13:05 -0800 (PST) In-Reply-To: <20111118155522.GD2703@adacore.com> References: <20111117232006.GA22252@enorme.TCLDOMAIN.OFFICE> <20111118155522.GD2703@adacore.com> Date: Fri, 18 Nov 2011 16:13:00 -0000 Message-ID: Subject: Re: [PATCH] Renesas SH (sh4) native support From: Hector Oron To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org, Nobuhiro Iwamatsu , takashi.yoshii.zj@renesas.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00502.txt.bz2 Hi Joel, 2011/11/18 Joel Brobecker : > The biggest issue I have besides copyright assignment (from the original > author, right?) is the fact that it hasn't been tested. If we could > involve the author a bit, and ask him to rebase the patch against > HEAD, and test it a bit, at least we could have a little bit of > confidence. Surely, before merging the code, it must be built and tested properly. The original author was CC, but apparently that email was wrong and it was bouncing the email, so I am adding another known address, and see if we can add support into main GDB for Renesas SH. @Yoshii-san, please, look at for context. > I've also spotted the following: > > =C2=A0 =C2=A0+#include > =C2=A0 =C2=A0+#include > =C2=A0 =C2=A0+#include > =C2=A0 =C2=A0+#include > =C2=A0 =C2=A0+#include > =C2=A0 =C2=A0+ > =C2=A0 =C2=A0+#include > > which is a big no-no in a -tdep file. Tdep files should be compilable > on any host. > > I haven't been able to review the file much beyond that... Thanks for the comments! --=20 =C2=A0H=C3=A9ctor Or=C3=B3n =C2=A0-.. . -... .. .- -. =C2=A0 -.. . ...- . .= -.. --- .--. . .-.