Re: [PATCH] testsuite: skip morestack.exp in sparc targets

[Will Newton <will.newton@linaro.org>]

On 9 October 2013 13:49, Jose E. Marchesi <jose.marchesi@oracle.com> wrote:
>
> 2013-10-09  Jose E. Marchesi  <jose.marchesi@oracle.com>
>
>         * gdb.base/morestack.exp: Skip test in sparc targets, where
>         -fsplit-stack is not supported.
>
> Index: testsuite/gdb.base/morestack.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/morestack.exp,v
> retrieving revision 1.5
> diff -u -r1.5 morestack.exp
> --- testsuite/gdb.base/morestack.exp    27 Jun 2013 18:51:31 -0000      1.5
> +++ testsuite/gdb.base/morestack.exp    9 Oct 2013 12:43:55 -0000
> @@ -13,6 +13,12 @@
>  # You should have received a copy of the GNU General Public License
>  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>
> +# This test does not work on targets for which -fsplit-stack is not
> +# supported.
> +if { [istarget sparc*-*-linux-gnu] } {
> +    return
> +}
> +
>  if [get_compiler_info] {
>      return -1
>  }

It might be simpler just to enable for the targets that do support
-fsplit-stack:

if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
  return
}

-- 
Will Newton
Toolchain Working Group, Linaro