From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20540 invoked by alias); 23 Jan 2014 15:21:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20530 invoked by uid 89); 23 Jan 2014 15:21:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f175.google.com Received: from mail-ie0-f175.google.com (HELO mail-ie0-f175.google.com) (209.85.223.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 23 Jan 2014 15:21:31 +0000 Received: by mail-ie0-f175.google.com with SMTP id ar20so1232629iec.6 for ; Thu, 23 Jan 2014 07:21:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Zpe2VGNx9K51V1HI6qb2TsoE/w5BkYKlALNFw+oZXDo=; b=kUuZFdxtXxaa/IBkgukzbrzqbI7Xg4TsO+Cu5LVN/C47iV9IIKyutObSyTuN52YVdn eE4ERedwiHVjJpcMkpyLXehG/F/B0NDKPFqP23oYyqKi5BuisCtpyWFdvONGvSncSLzn XOcjbM/gYmk/oo0ERBcRZtpX/vy75YXznHIopl0tS2gRo+x21G4MyAXZvs+Bpp1tTCk2 MAsRE5TYelRGZYmX94wktbhCq/gE5npSGj1zpDTK7CSZ5smaao7REmu4QMp1TkYBRqC1 P8fthfF95/2RPrHFhp4gYG7uQHYt6qjjawKb+SAcU1dPcieEWy/PC7KnCPqL4X1EJhm6 Gxhw== X-Gm-Message-State: ALoCoQmBM/yhrHr84UPCYXyL8kuEktADtNdBthZWfSBPgn5f5MRKWpQO4lS7xo+nZF3LzMJXZzi0 MIME-Version: 1.0 X-Received: by 10.50.122.38 with SMTP id lp6mr29532714igb.30.1390490490098; Thu, 23 Jan 2014 07:21:30 -0800 (PST) Received: by 10.64.20.52 with HTTP; Thu, 23 Jan 2014 07:21:30 -0800 (PST) In-Reply-To: <52AF4563.2090304@linaro.org> References: <52AF4563.2090304@linaro.org> Date: Thu, 23 Jan 2014 15:21:00 -0000 Message-ID: Subject: Re: [PATCH] gdb/elfread.c: Enable ifunc support on ARM. From: Will Newton To: "gdb-patches@sourceware.org" Cc: Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00903.txt.bz2 On 16 December 2013 18:24, Will Newton wrote: > > There are two failures in the gnu-ifunc.exp test on ARM. These are > due to the failure to resolve the correct target function when > attempting to breakpoint a GNU ifunc resolved function: > > (gdb) break gnu_ifunc > Breakpoint 4 at gnu-indirect-function resolver at 0x2aacb5a2 > > when gnu_ifunc has been resolved this should actually be: > > (gdb) break gnu_ifunc > Breakpoint 4 at 0x868c > > There are two reasons for this. The first is that ARM does not have a > separate .got.plt section so looking this up will always fail. The second > is that the Thumb bit needs to be stripped from the address to allow > it to be reliably compared when inserting into the ifunc cache. > > Tested with no regressions on arm-linux-gnueabihf and > x86_64-unknown-linux-gnu. > > gdb/ChangeLog: > > 2013-12-16 Will Newton > > * elfread.c (elf_rel_plt_read): Look for a .got section if > looking up .got.plt fails. > (elf_gnu_ifunc_resolve_by_got): Call gdbarch_addr_bits_remove > on address passed to elf_gnu_ifunc_record_cache. > (elf_gnu_ifunc_resolve_addr): Likewise. > (elf_gnu_ifunc_resolver_return_stop): Likewise. > --- > gdb/elfread.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Ping? -- Will Newton Toolchain Working Group, Linaro