Re: [PATCH v3 2/6] Implements support for recording thumb2 ASIMD struct ld/st insn

Pedro Alves
2014-08-27T10:09:47Z

On 08/27/2014 10:07 AM, Omair Javaid wrote:
> On 13 August 2014 19:10, Will Newton <will.newton@linaro.org> wrote:
>> On 13 August 2014 14:12, Omair Javaid <omair.javaid@linaro.org> wrote:
>>> gdb:
>>>

Same comments as previous patch on ChangeLog and $subject.
Please likewise adjust all patches in the series.

>>> +static int
>>> +thumb2_record_asimd_struct_ld_st (insn_decode_record *thumb2_insn_r)
>>> +{
>>> + struct regcache *reg_cache = thumb2_insn_r->regcache;
>>> + uint32_t l_bit, a_bit, b_bits;
>>> + uint32_t record_buf[128], record_buf_mem[128];
>>> + uint32_t reg_rn, reg_vd, address, f_esize, f_elem;
>>> + uint32_t index_r = 0, index_e = 0, bf_regs = 0, index_m = 0, loop_t = 0;
>>> + uint8_t bf_align, f_ebytes;
>>> +
>>> + l_bit = bit (thumb2_insn_r->arm_insn, 21);
>>> + a_bit = bit (thumb2_insn_r->arm_insn, 23);
>>> + b_bits = bits (thumb2_insn_r->arm_insn, 8, 11);
>>> + bf_align = bits (thumb2_insn_r->arm_insn, 4, 5);
>>
>> bf_align does not appear to be used.
>>
>>> + reg_rn = bits (thumb2_insn_r->arm_insn, 16, 19);
>>> + reg_vd = bits (thumb2_insn_r->arm_insn, 12, 15);
>>> + reg_vd = (bit (thumb2_insn_r->arm_insn, 22) << 4) | reg_vd;
>>> + f_ebytes = (1 << bits (thumb2_insn_r->arm_insn, 6, 7));
>>
>> The outer brackets are redundant.

> Ping! Kindly provide your feedback and help me approve this patch series.

This is OK with Will's comments addressed.

Thanks,
Pedro Alves