From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25063 invoked by alias); 4 Jun 2013 09:10:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25022 invoked by uid 89); 4 Jun 2013 09:10:48 -0000 X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-ie0-f177.google.com (HELO mail-ie0-f177.google.com) (209.85.223.177) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 04 Jun 2013 09:10:47 +0000 Received: by mail-ie0-f177.google.com with SMTP id u16so10227884iet.8 for ; Tue, 04 Jun 2013 02:10:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=etl1VIMdAzdBuopPmKuRL0xAP1idfxpZJ6HCoBJJnuY=; b=gEPLTMhoKBC5SlABtf977BAiLzQjqCIDXi2nbPT5n77YC7uErCPEbVDrzo9g8qrHOW WiQ/G0n2CH5DBgw+D3BD/lJaHTAjhgq4F6pJQrGn/gh/iJmJht7bk1PNM/pLSahJrpaM cGOiKT2JTxRqvUrcdjq8UE19bvcyNK7q+POZTL+kmddeXbSSOLVjQhC7CLAi8pCh9fkj XaPeczhnkWx7WtPLKmZUl1+tVhzhs7z8TBDtZXib1MFrGhnVtt2sUU1xjXZYa32tmkTp N15rU3tPSH8JXcEaJbSakbB0DWHW1RLqqZuuvXTI/mUBG87mGMktP96I3Fc1UAxxH90k pFaA== MIME-Version: 1.0 X-Received: by 10.50.3.36 with SMTP id 4mr209091igz.69.1370337046051; Tue, 04 Jun 2013 02:10:46 -0700 (PDT) Received: by 10.64.8.111 with HTTP; Tue, 4 Jun 2013 02:10:45 -0700 (PDT) In-Reply-To: <51ADAD62.6060704@codesourcery.com> References: <51AC8CA2.3030008@codesourcery.com> <87vc5vmamh.fsf@fleche.redhat.com> <51ADAAEC.6020902@codesourcery.com> <51ADAD62.6060704@codesourcery.com> Date: Tue, 04 Jun 2013 09:10:00 -0000 Message-ID: Subject: Re: [PATCH, c++ testsuite] Fix a few failures in gdb.cp/virtfunc.exp From: Will Newton To: lgustavo@codesourcery.com Cc: Tom Tromey , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnZO5J9RZT7kb6hnMjZe2dSyZ+W4TH8E0A3yBI9gQLJzTBa8gDkYQDWzGsMbJh95dSFeOGv X-SW-Source: 2013-06/txt/msg00037.txt.bz2 On 4 June 2013 10:03, Luis Machado wrote: > On 06/04/2013 10:53 AM, Luis Machado wrote: >> >> On 06/03/2013 06:17 PM, Tom Tromey wrote: >>>>>>>> >>>>>>>> "Luis" == Luis Machado writes: >>> >>> >>> Luis> 2013-06-03 Luis Machado >>> Luis> * gdb.cp/virtfunc.exp (make_one_vtable_result): Handle extra >>> output >>> Luis> from targets that use function descriptors in the virtual >>> tables. >>> >>> Ok. Thanks for looking at this. >> >> >> Before checking in the patch, i figured out the rest of the problems. >> >> Newer GDB's seem to have fixed a problem with displaying thunks in the >> virtual tables. Older ones did not demangle those names properly. >> >> With that said, ppc64 uses dot symbols for those thunks, so we need to >> account for those in the testcase as well. >> >> Here's the updated patch. I escaped dot once (\.) instead of twice. So >> hopefully this is the correct way. I often get confused with escaping in >> dejagnu. >> >> With this fix, i see only a single failure for virtfunc.exp on ppc64. >> The other failure is more involved and i'm still chasing the root cause. > > > For convenience, here is an example of how the output looks for ppc64. Thunk > symbols have a dot prefix. > > vtable for 'D' @ 0x10013248 (subobject @ 0x10013ed0): > [0]: @0x10013c00: 0x10001d64 <.non-virtual thunk to E::vg()> > [1]: @0x10013ca8: 0x10001eec > > vtable for 'V' @ 0x10013290 (subobject @ 0x10013ef0): > [0]: @0x10013cd8: 0x10001f74 > [1]: @0x10013c60: 0x10001e38 <.virtual thunk to E::vv()> ARM also has a similar problem, as Thumb addresses end up looking like: [0]: 0x8e7d I'm not sure if it's a problem with the test or if there is a missing call to addr_bits_remove somewhere. -- Will Newton Toolchain Working Group, Linaro