Re: [PATCH v3 4/6] Implement support for recording extension register ld/st insn

Pedro Alves
2014-08-27T10:17:57Z

On 08/27/2014 10:21 AM, Omair Javaid wrote:

> + while (memory_count)
> + {

> + while (reg_count)

Not implicit boolean coercion please. Write
'memory_count != 0' or 'memory_count > 0'.

>>> >> + /* VLDR Vector load register. */
>>> >> + else if ((opcode & 0x13) == 0x11)
>>> >> + {
>>> >> + uint8_t single_reg = 0;
>>> >> + uint8_t special_case;
>> >
>> > Is there some missing code here? Should there be a TODO comment?
> Seems like a bit of code missing here will update it in the final patch.

It's kind of hard to review code that we don't see... :-)
Please post the updated patch.

> Ping! Kindly provide your feedback any further comments will help me
> approve this patch series.

This is OK if Will is happy with the updated patch.

Thanks,
Pedro Alves