Re: [PATCH 5/7] Support for recording syscall on aarch64-linux

Andreas Arnez
2014-06-06T15:58:17Z

On Wed, Jun 04 2014, Omair Javaid wrote:

> This patch adds support for recording system call instruction on aarch64-linux
> targets.
>
> [...]
> @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> [...]
> +
> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1;
> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2;
> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3;
> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;

Is this a typo? Otherwise the reason for this specialty should be
documented in a comment here, IMO.