From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29591 invoked by alias); 12 Jun 2013 09:54:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29581 invoked by uid 89); 12 Jun 2013 09:54:13 -0000 X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-ie0-f171.google.com (HELO mail-ie0-f171.google.com) (209.85.223.171) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 12 Jun 2013 09:54:12 +0000 Received: by mail-ie0-f171.google.com with SMTP id qd12so8269149ieb.2 for ; Wed, 12 Jun 2013 02:54:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=HNsekjBHXNw6OfkxCJIp31lGIKN8t6M92y0W+2sCugk=; b=mUVBL2s2yVSAyNqA0NL/Sy1dvaDhaENQD4Pd/NxGbAMQkGO3ZKRm0aVVTBjbzCaM2w 9caE6kGGiydAh0JjBrR9RJvHINGoA/2ZAvAph6Yr5B78XXVUAC4+Y5i1DkxNPcDq3TK0 668EVWiRbZxMkGb3TLQtBexTX65BvFOBZ7KKm0lFKZ3ENE0O8RDq1lZ2ZPPJP2NZWYDi vKhBesqn/2EDBCVKxpwFmXl3w5YD5P7zE3Yn+PBn2mv4NFAhtx/hl5MV4jlePBCVK3CT ugr3/iKm7CMFi7NUQ/MRPglmBrFUOy/t1WmOuBn2JV9Wbt4d2P8QAeHzvHSsFk2CsTpZ 1Hrg== MIME-Version: 1.0 X-Received: by 10.50.50.164 with SMTP id d4mr2960600igo.69.1371030850992; Wed, 12 Jun 2013 02:54:10 -0700 (PDT) Received: by 10.64.8.111 with HTTP; Wed, 12 Jun 2013 02:54:10 -0700 (PDT) In-Reply-To: References: <51B22910.7010208@linaro.org> Date: Wed, 12 Jun 2013 10:26:00 -0000 Message-ID: Subject: Re: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads. From: Will Newton To: Andrew Pinski Cc: "gdb-patches@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQk1Onv3A5u2qd94N4np8wituX8aTU7F7cCM9p5jY5EttUjVnB9xy4Va/sTHsPIuthrrL2VG X-SW-Source: 2013-06/txt/msg00270.txt.bz2 On 12 June 2013 00:02, Andrew Pinski wrote: > On Fri, Jun 7, 2013 at 11:40 AM, Will Newton wrote: >> >> On Ubuntu the compiler passes --as-needed to the linker which means >> no DT_NEEDED entry is added for libpthread when building the TLS >> tests. This causes the test to fail as a libpthread is required to >> look up TLS variables. Add some calls to pthread functions to make >> sure libpthread is linked. > > > I think this should be an debian/Ubuntu local only patch as the > default for FSF GCC/binutils is not to pass --as-needed. I admit the change is a little, erm, weird, but my hope was to avoid causing pain to people who build gdb on Ubuntu. This isn't just Ubunto or Debian developers but Ubuntu or Debian users that happen to have downloaded a gdb tarball from gnu.org. Similar test failures in binutils have been worked around by adding -Wl,--no-as-needed which we could also do here, but I was concerned that this may break non-gcc compilers. -- Will Newton Toolchain Working Group, Linaro