From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16660 invoked by alias); 11 Jun 2013 13:25:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16630 invoked by uid 89); 11 Jun 2013 13:25:24 -0000 X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-ie0-f180.google.com (HELO mail-ie0-f180.google.com) (209.85.223.180) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 11 Jun 2013 13:25:23 +0000 Received: by mail-ie0-f180.google.com with SMTP id f4so14687472iea.39 for ; Tue, 11 Jun 2013 06:25:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=7dd2Q0WsdonLdaMLPygwiL4kMLSM35ydsh2+F8SHd0Y=; b=YVOzMticjTD2OvRZNt91dPGwEE45442P1ElszkanVRztvpR7XVqg301ob0BEdM6kMd Kc3frP45HWnOpCw0llqFMn8Uauy1i2GRe9RgnPnZvATYHQT42VNpy9eor9a9MbrYNq/3 SR6m1ieoyKsjpI1TeemFJIC96G2mEZib/F6o/KCFgqlqZLku4cbguSsMn+a0YtjY1Ov3 FurBHNSMTeP+N829fFIjLjimGRsBx/mrJ5NB3/9HNd8q5wx1tJEvwNLmcdGzm6qcOFMu WBR7exjAWB5lrIoK9ck7DzvPqz1Vu+LCeygdXq9ix4J0yy0L52TVqDVOgUBJCef+M60+ LW0w== MIME-Version: 1.0 X-Received: by 10.50.16.102 with SMTP id f6mr899734igd.41.1370957121680; Tue, 11 Jun 2013 06:25:21 -0700 (PDT) Received: by 10.64.8.111 with HTTP; Tue, 11 Jun 2013 06:25:21 -0700 (PDT) In-Reply-To: <201306072009.r57K9kiX009408@glazunov.sibelius.xs4all.nl> References: <51B228C9.2030105@linaro.org> <201306072009.r57K9kiX009408@glazunov.sibelius.xs4all.nl> Date: Tue, 11 Jun 2013 13:33:00 -0000 Message-ID: Subject: Re: [PATCH] gdb/doublest.c: Avoid calling ldfrexp if long double is double. From: Will Newton To: Mark Kettenis Cc: "gdb-patches@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQm3Afi3D0/9nDIwuoJ5AlM7bgbfDQYWCLjG8DQVZ7mZw4SzfsoExCAltep0YSaDWC/m4lnF X-SW-Source: 2013-06/txt/msg00247.txt.bz2 On 7 June 2013 21:09, Mark Kettenis wrote: >> Date: Fri, 07 Jun 2013 19:39:05 +0100 >> From: Will Newton >> >> There's no need to call ldfrexp if long double is the same size >> as double, the standard frexp will be faster and more accurate. >> This fixes a failure in ldbl_308.exp on ARM, where long double >> is the same size as double. >> >> gdb/ChangeLog: >> >> 2013-06-07 Will Newton >> >> * doublest.c (convert_doublest_to_floatformat): If long >> double is the same size as double call frexp instead of >> ldfrexp. >> --- >> gdb/doublest.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Hmm, sounds like the real bug is in ldfrexp. Not sure if that is > fixable though. How many systems are still out there that have a long > double type, but don't have frexpl(3)? > > Hmm, according to > > > > there might still be a few. But that means we just have to include > another gnulib module ;). This sounds like a better approach than my patch. Is there a standard set of steps to add a new gnulib module? I tried adding frexpl to update-gnulib.sh and that seems to work, but then all my systems are glibc-based so frexpl is present and correct anyway. Thanks, -- Will Newton Toolchain Working Group, Linaro