From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X00rFGNr8WiM2DkAWB0awg (envelope-from ) for ; Thu, 16 Oct 2025 18:02:11 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ixNgvJls; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 452041E047; Thu, 16 Oct 2025 18:02:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C37A21E047 for ; Thu, 16 Oct 2025 18:02:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 399EF3857B91 for ; Thu, 16 Oct 2025 22:02:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 399EF3857B91 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ixNgvJls Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id 606C53858D1E for ; Thu, 16 Oct 2025 22:01:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 606C53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 606C53858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760652097; cv=none; b=eeglEWYGjAnpoTlavZ74Tgs8BkhU0fhEBbWqk9VLzfTeI0TNFl/IGxeNqyg5GPFRGD5TKn19vupoxvPYIhzbXvxE4QmgeU2MEWfMCE92Yx+FgNREtDRJoymlybeQhysroe3Ebro38Uik1DyBm8+rc53NeABHZoeOKcL8kqYZhy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760652097; c=relaxed/simple; bh=wExsKyih4nTNrP+qVVLkfjsooIleIOVxgD151Ni4RD0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=NMSBOmWrBsfrWQYejqnyt4iZjuwp+GKS9hOHiPLPBdomPIABLtUArdDOCzmzGGZiseX/Hgv/OcY1kqYDWvNELsNPXxrD0MLuGqC9iMJjHFdq5cZqTBXs7K/7udRdBHWLASSdS05XCS9PxVpo7SJ8x3691p3u2NTvFwzwDP1mWf0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 606C53858D1E Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-4439f1cb764so395059b6e.3 for ; Thu, 16 Oct 2025 15:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760652097; x=1761256897; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=C1lo6DBQ0NhEvA0fgqvBO+Oq1yqcxqWel0jZXu1z1BY=; b=ixNgvJlsUiuhhPXI242aEzx3VvVKwez2Jfggo13cX5Rp+gScc9ckqwc1lRGUaFn0o5 ZObML3COqHi6Lcrp0ZVxRwSCteXcHGliqQZ2Cx2JOYpV2H4Zyoq0N6CYWlvn4ANb1tiD kJpmI/9qWXqp5xQSC0d0Of8OUvVF0WgX4osLXa1EvcO7ps4THdYaA+T3isldz/5trCbd VtM6AZSKrdC4NkYDw2CYclSRl+oGI8G/A05AbRampecaqbvmcg6uXfjthLoqez/3LXaM PhQnjcfO0qq5ZWzj2NauC0VrXYVLM8w17qBFANouBkYKkPI2UJA+kGZqO/E8Ft9wM8WH 9WAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760652097; x=1761256897; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C1lo6DBQ0NhEvA0fgqvBO+Oq1yqcxqWel0jZXu1z1BY=; b=haZ6hxYaCt2R4qr3hkkCMxiCaFr6jWA4hGtw+bEWdOUpUXmnr2tOkndQTxRBf8XE0Y RzHOv7uArEMtQbr8/i29vNdU9jePARsNhMwvI3COnVppRMJud6DVCkVdPhcR0Qu0Kc8B f8s9vk+r8/gAhiQ2F3TbbRcCkxT7pfR9lGmgWG1SJTIYsvwD/762LnnXsBgTMj4Kwtpy yECj9xaBQZ/SKB2uKxOkrPWVmn7jVyXWtuqkdmpxW1C3yJdBdxyTh9qld+Eu/2aSMY2b pzfneDjN9rxTBVTqxbK8zNaS1Vdb/3PRoQaPOiIOHcxhEAe7DcfgtU4/jX8pQQ5s3XmW nZ8g== X-Forwarded-Encrypted: i=1; AJvYcCXDoZOM26fxC9/sBzKUZQDtR0F11PXdqcQKIjL7JF9Y6WEHl0GzHoPVxVBFBGX+5u5QO+7WbSmwWh4Whw==@sourceware.org X-Gm-Message-State: AOJu0Yz3D1sszdK3RXxudA2xNAxDHZeiq4don8LRVbfdc+AHjEYVXAnN bn18kn3pYxstyBUbWgCovQogQfND0EFtSkcY2nNJ0qzWE8/MhLEHqv8jh0sAlnn4zZYcgaQH1sg EEMkzIKd2CyCIJm1IQBCw/H+LD4LkL0o= X-Gm-Gg: ASbGnctuouW8OlUruvxZ6/sXFclXZtzi/RpN2ZT+FNn3z+3cQpI5JFVqX209eBZCHqz oCU4G+DqSXRtDR1B09UK7d9qmB5r9jiy6GWa5KSJ168Mbjht+vrHqUr/2t7WHhJby+UE5aCWRbg pEwFzUU5AG8R/Cqbi44rI8yNksI8v7CvB+zcxhdPixI7Vfxa/C4AbrMjpbJ8nPPh4KdJpzZZmy5 qlLBHZvMKiEvNt6ogjhJDuBVIS63qSgcpw5pt81SAJNtRZToKgM7pwDRobUaVqsb6c2DN8= X-Google-Smtp-Source: AGHT+IFFX9ad7sXEaPCwSF9ZOA1q94qWWrwr77eog7+kSSa6xvzs1eaC9vKo/jMcAT5VrKUjHUxm/6ZLHzL01os1Ea0= X-Received: by 2002:a05:6808:21a2:b0:441:8f74:fbc with SMTP id 5614622812f47-443a3190540mr709893b6e.57.1760652096536; Thu, 16 Oct 2025 15:01:36 -0700 (PDT) MIME-Version: 1.0 References: <20251007123132.26769-1-Ezra.Sitorus@arm.com> <20251007123132.26769-3-Ezra.Sitorus@arm.com> <5bff9203-f0f8-4661-8aff-7b28d758416b@gmail.com> <1db3bf19-02e4-40bb-adf7-6355b176e0f2@arm.com> In-Reply-To: From: Luis Date: Thu, 16 Oct 2025 23:01:24 +0100 X-Gm-Features: AS18NWAYCJWUwWNvxtxNpwN7KGGD3KufI8ss_uU3G5loj192pukFgAsVNn1DTvI Message-ID: Subject: Re: [PATCH v2 2/5] gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver on Linux To: Ezra Sitorus Cc: Richard Earnshaw , gdb-patches@sourceware.org, thiago.bauermann@linaro.org Content-Type: multipart/alternative; boundary="000000000000c9873406414dc2c9" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --000000000000c9873406414dc2c9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 13, 2025, 15:53 Ezra Sitorus wrote: > On Mon, Oct 13, 2025 at 02:40:07PM +0100, Richard Earnshaw wrote: > > On 11/10/2025 12:50, Luis wrote: > > > On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote: > > > > From: Ezra Sitorus > > > > > > > > Support FPMR in gdbserver. > > > > > > Nit. Make it "Add support for FPMR register set in gdbserver." > > > > > > It is a bit more descriptive. > > > > But grammatically wrong, since FPMR is short for Floating Point Mode > > Register. So then you'd have: > > > > Add support for the floating point mode register register set in > > gdbserver!!!! > > > > R. > > > > > > > I agree with Richard that it should just be FPMR but I think FPMR registe= r > set makes sense too. Linux kernel has REGSET_FPMR, as well as REGSET_GPR > and REGSET_FPR. Maybe you're meant to think something along the lines of = a > 'register set called FPMR, which only has the FPMR'? > I meant FPMR the register set exposed by the Linux Kernel via ptrace. That's what these changes are dealing with. But either way is fine by me. You could use: "Add support for FPMR in gdbserver." > Which means something like this: > > > > > +/* Fill BUF with the FPMR register from the regcache.=EF=BF=BD */ > > > > + > > > > +static void > > > > +aarch64_fill_fpmr_regset (struct regcache *regcache, void *buf) > > should just be: > > Fill BUF with the FPMR from the regcache. > > but this works too: > > Fill BUF with the FPMR register set from the regcache. > Technically it is the register set we're dealing with, but it has a single register. Again, as long as it is clear I'm fine either way. It is a minor detail. > Ezra > --000000000000c9873406414dc2c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Oct 13, 2025, 15:53 Ezra Sitorus= <ezra.sitorus@arm.com> w= rote:
On Mon, Oct 13, 2025 at 02:40= :07PM +0100, Richard Earnshaw wrote:
> On 11/10/2025 12:50, Luis wrote:
> > On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote:
> > > From: Ezra Sitorus <ezra.sitorus@arm.com>
> > >
> > > Support FPMR in gdbserver.
> >
> > Nit. Make it "Add support for FPMR register set in gdbserver= ."
> >
> > It is a bit more descriptive.
>
> But grammatically wrong, since FPMR is short for Floating Point Mode > Register.=C2=A0 So then you'd have:
>
> Add support for the floating point mode register register set in
> gdbserver!!!!
>
> R.
>
> >

I agree with Richard that it should just be FPMR but I think FPMR register<= br> set makes sense too. Linux kernel has REGSET_FPMR, as well as REGSET_GPR and REGSET_FPR. Maybe you're meant to think something along the lines o= f a
'register set called FPMR, which only has the FPMR'?

I meant FPMR th= e register set exposed by the Linux Kernel via ptrace. That's what thes= e changes are dealing with.

But either way is fine by me. You could use:
"Add support for FPMR in gdbserver."


Which means something like this:

> > > +/* Fill BUF with the FPMR register from the regcache.=EF=BF= =BD */
> > > +
> > > +static void
> > > +aarch64_fill_fpmr_regset (struct regcache *regcache, void *= buf)

should just be:

Fill BUF with the FPMR from the regcache.

but this works too:

Fill BUF with the FPMR register set from the regcache.

Technically it is the= register set we're dealing with, but it has a single register. Again, = as long as it is clear I'm fine either way. It is a minor detail.
=


Ezra
--000000000000c9873406414dc2c9--