From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119432 invoked by alias); 4 Feb 2019 09:13:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119418 invoked by uid 89); 4 Feb 2019 09:13:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Gm-Message-State:sk:AHQUAub, tend, H*Ad:D*vnet.ibm.com, his X-HELO: mail-qt1-f193.google.com Received: from mail-qt1-f193.google.com (HELO mail-qt1-f193.google.com) (209.85.160.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Feb 2019 09:13:10 +0000 Received: by mail-qt1-f193.google.com with SMTP id y20so14510877qtm.13 for ; Mon, 04 Feb 2019 01:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IAeXIq0c4Ulee/krxpcbmSNFr+ICtH0uKp6fETJaVbY=; b=jkM2Tp4HfKXvEf0C4cjjxu0UYVtRN8d3Fw8Wyy3xlisLWdWokDZ+5rXnTLDCvxPndC 5wUV33aV8f3ToQM5dQpogAaZ8DSGgeA+nk40wFteyTh6Cp751jcPdHTjQZcWgAl6Ewww ijhs1qaaX7jcrtUQ4+YLA38CAE742yN9b3KS4= MIME-Version: 1.0 References: <1548738199-9403-1-git-send-email-omair.javaid@linaro.org> <6c29e316-f1cb-ee65-bc0b-844cba5d74ad@FreeBSD.org> In-Reply-To: <6c29e316-f1cb-ee65-bc0b-844cba5d74ad@FreeBSD.org> From: Omair Javaid Date: Mon, 04 Feb 2019 09:13:00 -0000 Message-ID: Subject: Re: [RFC PATCH 0/6] Support for Linux kernel thread aware debug To: John Baldwin Cc: GDB Patches , Pedro Alves , Philipp Rudo , Andreas Arnez , Peter Griffin , Ulrich Weigand , Kieran Bingham Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00014.txt.bz2 On Tue, 29 Jan 2019 at 22:30, John Baldwin wrote: > > On 1/28/19 9:03 PM, Omair Javaid wrote: > > This patch series implements linux kernel target which allows linux kernel > > tasks to be viewed as GDB threads. We have had multiple set of patches > > submitted over last few years aiming to insert add-ons into GDB for debugging > > Linux kernel. This patch series builds on top of Linux kernel infrastructure > > submitted by Philipp Rudo in his various sets of patches aiming to debug > > Linux kernel dumps. > > I just have one minor suggestion / comment about file names. I maintain > FreeBSD kernel patches for gdb out-of-tree (for various reasons), and those > patches use some similar things (e.g. a different OSABI). My comment has > to do with the filenames. Other osabi-specific files tend to use more > verbose names such as 'linux-arm-nat.c'. I wonder if it makes sense to > spell out linux here as well. I have been using 'arm-fbsd-kern.c' as a > complement to 'arm-fbsd-tdep.c' for the kernel gdbarch. The architecture > independent files follow the patter 'fbsd-k*.c' (e.g. fbsd-kld.c for modules > and fbsd-kthr.c for thread enumeration), but I would be happy to move those > to something like 'fbsd-kern-ld.c' and 'fbsd-kern-thr.c'. For your current > patchset that might mean something like 'linux-kern-tdep.c' instead of > 'lk-tdep.c'. I would also be fine with 'arm-linux-kern-tdep.c' instead of > 'arm-linux-kern.c' perhaps if other folks feel like that is more consistent. Hi John, Andreas has aptly described the reason behind choosing the nomenclature of new linux kernel specific files as it is right now and i am open to any suggestion that my come up during reviews. Also I was wondering if you can share details of kernel debugging features which has implemented in your out of tree FreeBSD patches for GDB. Also share some insight on ways to test this patchset. Thanks! > > -- > John Baldwin > >