From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10351 invoked by alias); 24 Jan 2018 10:57:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9711 invoked by uid 89); 24 Jan 2018 10:57:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:alternative, receipt X-HELO: mail-qt0-f173.google.com Received: from mail-qt0-f173.google.com (HELO mail-qt0-f173.google.com) (209.85.216.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Jan 2018 10:57:36 +0000 Received: by mail-qt0-f173.google.com with SMTP id x27so9139681qtm.12 for ; Wed, 24 Jan 2018 02:57:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0Fnl+fAtyhQWjbk2oAoElHauvm0xu9icgpfL1F0eJ5g=; b=joFYZakMscMHkqmWWaJZeWbuVKrV2Asy44mWey7m9uBXMezZ8wngoQKjppNUmB1gvE HedaU/SqIQIsFl6g9YAuA2HFfoWfgVCeO5ybyg0nm4A99I7KOWDIwYoPWrxJPeAufG+t 2ZX0+LHpxniDXryUce5YBW2eUnbIxMrYwoAbCKmtoYXlw/Ihy96sizrXgHQFLCp3EMAC idMjKl8lMmesOYGezyacuhGSqoIiR0r1X708kR9TJPo+gOF/ZLbbGexs4I2Hv14MZ9zW Vgz9z62nCnBD/lFLc8O4vrLFWOYRlcX6nC+bIlyYoACrFGYXoAifPlvbgl1BoRNK6XJV HADQ== X-Gm-Message-State: AKwxytfzxuf+jW4IOFITtYCoMiyYt83blEVB683OkU3P6s3SL0BtpAGi mLlrYaAfc+P360RqH/NLpngjQ2Y6FN7EEPI8nspusHUBC+Y= X-Google-Smtp-Source: AH8x225oxbxtmHOUp1GDbKwCpzWlAfxDCA/k+cyCFSKD+bgiaqP6jeH6N7bba/2SHo9tTCQLVbmNxed6+oe46nuQH/o= X-Received: by 10.200.35.208 with SMTP id r16mr9584271qtr.256.1516791454277; Wed, 24 Jan 2018 02:57:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.33.46 with HTTP; Wed, 24 Jan 2018 02:57:03 -0800 (PST) In-Reply-To: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> From: Omair Javaid Date: Wed, 24 Jan 2018 10:57:00 -0000 Message-ID: Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00472.txt.bz2 On 24 January 2018 at 14:26, Alan Hayward wrote: > Following review comments from Yao, this patch series is mostly a > reordering of the code from the previous patch series. > > This set of patches removes the need for gdbserver to ship the xml files > in the binary for those targets that use new style target descriptions. > > In exisiting code, gdbserver uses C code auto generated from xml files to > create target descriptions. When sending an xml description to GDB, it > creates an xml containing just the name of the original xml file. > Upon receipt, GDB reads and parses a local copy of xml file. > > With this new patch, we add common code that allows gdbserver and gdb > to turn a C target description structure into xml. To do this we must > first ensure that when gdbserver parses a target description it retains > enough information to turn it back into xml. > > The second patch commonises tdesc_reg, the third patch commonises > tdesc_feature and the fifth patch commonises the tdesc type structures. > This enables gdbserver to store all required information about a target > description. > > The sixth patch adds the xml printer. > The other patches are clean up patches. > > Patches have been tested on a make check on x86 targets=all build with > target board unix native-gdbserver. Also tested aarch64. Built for power > (becuase it does not use new target descriptions), but am unable to test. > In addition, patch four adds new test cases to unit test. > Hi Alan, I am failing to apply your patch series to the latest gdb sources. Apparently, your patch series needs a re-base over most recent gdb sources as there has not been a commit since these patches have been posted. Generally its a good idea to generate patches using git format-patch and send patches using git send-email. Patches need to be based off the most recent gdb commit that is available at the time of sending them for review. If you use git format-patch to generate patches from your local commits it would become very easy for a reviewer to just apply those patches using "git apply" in their local branches. Kindly post a patchset that works with a known version of gdb sources in order for your patches to be tested/reviewed upstream. Thanks! > > Alan. > > > gdb/Makefile.in | 1 - > gdb/arch/tdesc.c | 425 ------------------------ > gdb/arch/tdesc.h | 307 +----------------- > gdb/features/aarch64-core.c | 2 +- > gdb/features/aarch64-fpu.c | 2 +- > gdb/features/i386/32bit-avx.c | 2 +- > gdb/features/i386/32bit-avx512.c | 2 +- > gdb/features/i386/32bit-core.c | 2 +- > gdb/features/i386/32bit-linux.c | 2 +- > gdb/features/i386/32bit-mpx.c | 2 +- > gdb/features/i386/32bit-pkeys.c | 2 +- > gdb/features/i386/32bit-sse.c | 2 +- > gdb/features/i386/64bit-avx.c | 2 +- > gdb/features/i386/64bit-avx512.c | 2 +- > gdb/features/i386/64bit-core.c | 2 +- > gdb/features/i386/64bit-linux.c | 2 +- > gdb/features/i386/64bit-mpx.c | 2 +- > gdb/features/i386/64bit-pkeys.c | 2 +- > gdb/features/i386/64bit-segments.c | 2 +- > gdb/features/i386/64bit-sse.c | 2 +- > gdb/features/i386/x32-core.c | 2 +- > gdb/features/tic6x-c6xp.c | 2 +- > gdb/features/tic6x-core.c | 2 +- > gdb/features/tic6x-gp.c | 2 +- > gdb/gdbserver/Makefile.in | 3 - > gdb/gdbserver/configure.srv | 36 +++ > gdb/gdbserver/tdesc.c | 229 +++++++------ > gdb/gdbserver/tdesc.h | 58 +++- > gdb/regformats/regdat.sh | 5 +- > gdb/target-descriptions.c | 924 ++++++++++++++++++++++++++++++ > +++++++++-------------- > gdb/xml-tdesc.c | 9 - > gdb/xml-tdesc.h | 5 - > 32 files changed, 920 insertions(+), 1124 deletions(-) > >