From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29543 invoked by alias); 27 Aug 2014 09:09:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29531 invoked by uid 89); 27 Aug 2014 09:09:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 27 Aug 2014 09:09:06 +0000 Received: by mail-ob0-f172.google.com with SMTP id wn1so12698749obc.3 for ; Wed, 27 Aug 2014 02:09:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=CVL701GSYX2pG8JSrQaujEMj9DHA/eDSUNsVDTUai2U=; b=Ne8CTPTHfMwTCiY9G4xque26NQvdRyQ3L6Ut4PKyA53XyNcBgiuX2LTGARAi154Ce7 YhBJaLZ40RrRU6wDqYtXoyDAA4eTcUJn78hIcJHzIkq/SXK44DG1aBBAKuGLqh+ijjQw ZyxkbJRK3jv5LPPxNHA0Q4b/ZYsHW2uuWE9ZtCF0Ch4VMz57RCbgL8Je6kSEw8SfsslV C6BiESMBUM5RfXe9gV6kaqN5TA+/wiorSPu5i+NP/V2xZCIforP88dg/HJXuSv8PYVjD KVTlGsuHxwjdQxAGY1nCLw8+Q9BS+FZSgrJu1ow0j7V0aohH6WeZ4A/+wsHGOByNBXhC C/WA== X-Gm-Message-State: ALoCoQnHEl8slRfGLeE6xbUZyEoovEpMQC7PxAEwKbf69VYr4LGs5hKCeO7/PVz66xrP6wFRGxkv X-Received: by 10.182.142.67 with SMTP id ru3mr33022405obb.15.1409130544597; Wed, 27 Aug 2014 02:09:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.140.40 with HTTP; Wed, 27 Aug 2014 02:08:44 -0700 (PDT) In-Reply-To: <1407935535-27978-7-git-send-email-omair.javaid@linaro.org> References: <1407935535-27978-1-git-send-email-omair.javaid@linaro.org> <1407935535-27978-7-git-send-email-omair.javaid@linaro.org> From: Omair Javaid Date: Wed, 27 Aug 2014 09:09:00 -0000 Message-ID: Subject: Re: [PATCH v3 6/6] Fix reverse-step and reverse-next over undebuggable solib code To: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00553.txt.bz2 On 13 August 2014 18:12, Omair Javaid wrote: > This patch fixes failures to reverse-step or reverse-next over solib functions in absence of line information. > The problem is fixed by making sure that in solib functions we keep doing reverse single stepping in absence of line information. > > Tested with no regressions on arm, aarch64 and x86_64. > > gdb: > > 2014-08-13 Omair Javaid > > * infrun.c (process_event_stop_test): Updated. > > --- > gdb/infrun.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gdb/infrun.c b/gdb/infrun.c > index c18267f..db8f15b 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -4905,12 +4905,15 @@ process_event_stop_test (struct execution_control_state *ecs) > return; > } > > + stop_pc_sal = find_pc_line (stop_pc, 0); > + > /* Reverse stepping through solib trampolines. */ > > if (execution_direction == EXEC_REVERSE > && ecs->event_thread->control.step_over_calls != STEP_OVER_NONE) > { > if (gdbarch_skip_trampoline_code (gdbarch, frame, stop_pc) > + || stop_pc_sal.line == 0 > || (ecs->stop_func_start == 0 > && in_solib_dynsym_resolve_code (stop_pc))) > { > @@ -4939,8 +4942,6 @@ process_event_stop_test (struct execution_control_state *ecs) > } > } > > - stop_pc_sal = find_pc_line (stop_pc, 0); > - > /* NOTE: tausq/2004-05-24: This if block used to be done before all > the trampoline processing logic, however, there are some trampolines > that have no names, so we should do trampoline handling first. */ > -- > 1.9.1 > Ping! Kindly provide your feedback and help me approve this patch series.