From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2998 invoked by alias); 3 Jan 2014 19:20:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2987 invoked by uid 89); 3 Jan 2014 19:20:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 03 Jan 2014 19:20:19 +0000 Received: by mail-ob0-f177.google.com with SMTP id vb8so15725021obc.8 for ; Fri, 03 Jan 2014 11:20:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=URTc9cLEnmw32aQna3r9MjHQyznRVKsYOgr4buM9hvQ=; b=fzCv+5ERCbmna+uCdAptgHyIdr1equPUxWkdRLSYiLh3FDMUu+rdLD7HWQvVjEWQUa qlD+kTQwcN05dDQZPDTFpF1BO2GFHUIN49CzwKGp9/ix6os5IABo+9C8JeER8r4/DINH 2dv8qwDQ4CHI0dXZnsQEJn9BxaKtWQ+NDrVF9Eb2DxMjnMvxeIAdBO2bM832nJIOxvNn qaaduDy5P+wixn9JciN2JBU5j5gikR2CdfFBu8MptKZuCQmtGQMJHgIPnlVHWf5D64Kg ywdYDT365t3fEdwEOVMzPcgMYxv8RPvg8sPTA9n+i3vcsEPouMVhg6R/nWPnmIwA3JkJ 1p1w== X-Gm-Message-State: ALoCoQlUJkeyPxN/8xeVfyXxZU+qI9t9bLe/GtjP7uFJzY/1FDr+WdZFMQ3tXgdUdl4GkaX/i0Rd X-Received: by 10.182.148.106 with SMTP id tr10mr1558132obb.65.1388776817801; Fri, 03 Jan 2014 11:20:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.137.135 with HTTP; Fri, 3 Jan 2014 11:19:57 -0800 (PST) In-Reply-To: <52B43A57.7050705@redhat.com> References: <52687B1A.2050003@codesourcery.com> <527C580B.5020100@linaro.org> <83k3gj5p9t.fsf@gnu.org> <52809426.40405@linaro.org> <52929058.1050202@linaro.org> <52B43A57.7050705@redhat.com> From: Omair Javaid Date: Fri, 03 Jan 2014 19:20:00 -0000 Message-ID: Subject: Re: [PATCH 0/2] GDB process record and reverse debugging improvements for arm*-linux* To: Pedro Alves Cc: oza Pawandeep , Yao Qi , "gdb-patches@sourceware.org" , patches , Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00019.txt.bz2 On 20 December 2013 17:38, Pedro Alves wrote: > On 11/24/2013 11:48 PM, Omair Javaid wrote: > >> After incorporating all suggestions I am posting a final version of all >> three patches posted earlier. Looking for a go ahead for commit. > > All three emails in the series have the same subject apart from > the numbers, which make it confusing. It'd be good if you made > sure the subjects were actually different, and more specific, > in the git commit log. > > Hmm, I'm also surprised to now find that this "0/2" email > actually contains a patch. That makes it actually 3 patches > in the series. This is not the standard de facto way to > send a series. The best way is for 0 to be the series intro, > with no patch, and then have the patches be replies to the > intro mail. (I'd suggest addressing the comments I just > sent to patches #1 and #2, and resend the whole series with > git send-mail, which does that for you automatically.) > >> >> == PATCH 0 == >> >> This patch adds a news entry about improved process record-replay on >> arm*-linux* targets. >> It also adds linux-record.o to gdb_target_obs in configure.tgt and >> enables gdb.reverse testsuite for arm*-linux* targets. > > These could be two separate patches, with NEWS actually being the > last patch in the whole series. > >> gdb/testsuite: >> >> 2013-10-24 Omair Javaid >> >> * lib/gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets. > > Write: > > * lib/gdb.exp (supports_process_record): Return true for arm*-linux*. > > Otherwise looks good. > > -- > Pedro Alves > Suggestions to all previous patches have been incorporated and a patch series has been sent using git send-email here: https://sourceware.org/ml/gdb-patches/2014-01/msg00011.html Kindly suggest if they are good enough to be committed.