From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4277 invoked by alias); 10 Dec 2012 10:48:29 -0000 Received: (qmail 4253 invoked by uid 22791); 10 Dec 2012 10:48:25 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Dec 2012 10:48:14 +0000 Received: by mail-bk0-f41.google.com with SMTP id jg9so1093987bkc.0 for ; Mon, 10 Dec 2012 02:48:12 -0800 (PST) Received: by 10.204.157.26 with SMTP id z26mr4188596bkw.101.1355136492514; Mon, 10 Dec 2012 02:48:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.205.32.12 with HTTP; Mon, 10 Dec 2012 02:47:31 -0800 (PST) In-Reply-To: <50C1BD45.9080709@redhat.com> References: <87txryx36w.fsf@fleche.redhat.com> <50C1BD45.9080709@redhat.com> From: Hui Zhu Date: Mon, 10 Dec 2012 10:48:00 -0000 Message-ID: Subject: Re: [PATCH] Add fseek to ui-file To: Pedro Alves Cc: Tom Tromey , gdb-patches ml , Hui Zhu Content-Type: multipart/mixed; boundary=0015175d0a4c422fe504d07d4d73 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00227.txt.bz2 --0015175d0a4c422fe504d07d4d73 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1282 On Fri, Dec 7, 2012 at 5:56 PM, Pedro Alves wrote: > On 12/07/2012 08:01 AM, Hui Zhu wrote: >> +ui_file_fseek (struct ui_file * file, long offset, int whence) > > No space after '*'. Several instances of this issue in the patch. Fixed. > > On 12/07/2012 08:01 AM, Hui Zhu wrote: >> +static void >> +stdio_file_fseek (struct ui_file * file, long offset, int whence) >> +{ > ... >> + if (fseek (stdio->file, offset, whence)) >> + error (_("fseek fail: %s"), safe_strerror (errno)); > > I think that if we want to support error handling, then this should > return the fseek result to the caller instead of throwing an exception. > See e.g., the comment in stdio_file_write. > What about I change error to warning? Then it don't need some handle and something. And if really got some issue with this syscall, user can find issue with this warning? > -- > Pedro Alves > Post a new version. Thanks, Hui 2012-12-10 Hui Zhu * ui-file.c (ui_file): Add to_fseek. (ui_file_new): Call set_ui_file_fseek. (null_file_fseek, ui_file_fseek, set_ui_file_fseek, stdio_file_fseek): New functions. (stdio_file_new): Call set_ui_file_fseek. * ui-file.h (ui_file_fseek_ftype): New typedef. (set_ui_file_fseek, ui_file_fseek): New externs. --0015175d0a4c422fe504d07d4d73 Content-Type: text/plain; charset=US-ASCII; name="ui-file-fseek.txt" Content-Disposition: attachment; filename="ui-file-fseek.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hajh901i0 Content-length: 4775 LS0tIGEvdWktZmlsZS5jCisrKyBiL3VpLWZpbGUuYwpAQCAtMzYsNiArMzYs NyBAQCBzdGF0aWMgdWlfZmlsZV9mbHVzaF9mdHlwZSBudWxsX2ZpbGVfZmx1 CiBzdGF0aWMgdWlfZmlsZV9kZWxldGVfZnR5cGUgbnVsbF9maWxlX2RlbGV0 ZTsKIHN0YXRpYyB1aV9maWxlX3Jld2luZF9mdHlwZSBudWxsX2ZpbGVfcmV3 aW5kOwogc3RhdGljIHVpX2ZpbGVfcHV0X2Z0eXBlIG51bGxfZmlsZV9wdXQ7 CitzdGF0aWMgdWlfZmlsZV9mc2Vla19mdHlwZSBudWxsX2ZpbGVfZnNlZWs7 CiAKIHN0cnVjdCB1aV9maWxlCiAgIHsKQEAgLTQ5LDYgKzUwLDcgQEAgc3Ry dWN0IHVpX2ZpbGUKICAgICB1aV9maWxlX2lzYXR0eV9mdHlwZSAqdG9faXNh dHR5OwogICAgIHVpX2ZpbGVfcmV3aW5kX2Z0eXBlICp0b19yZXdpbmQ7CiAg ICAgdWlfZmlsZV9wdXRfZnR5cGUgKnRvX3B1dDsKKyAgICB1aV9maWxlX2Zz ZWVrX2Z0eXBlICp0b19mc2VlazsKICAgICB2b2lkICp0b19kYXRhOwogICB9 OwogaW50IHVpX2ZpbGVfbWFnaWM7CkBAIC02OCw2ICs3MCw3IEBAIHVpX2Zp bGVfbmV3ICh2b2lkKQogICBzZXRfdWlfZmlsZV9pc2F0dHkgKGZpbGUsIG51 bGxfZmlsZV9pc2F0dHkpOwogICBzZXRfdWlfZmlsZV9yZXdpbmQgKGZpbGUs IG51bGxfZmlsZV9yZXdpbmQpOwogICBzZXRfdWlfZmlsZV9wdXQgKGZpbGUs IG51bGxfZmlsZV9wdXQpOworICBzZXRfdWlfZmlsZV9mc2VlayAoZmlsZSwg bnVsbF9maWxlX2ZzZWVrKTsKICAgcmV0dXJuIGZpbGU7CiB9CiAKQEAgLTE3 MCw2ICsxNzMsMTIgQEAgbnVsbF9maWxlX2RlbGV0ZSAoc3RydWN0IHVpX2Zp bGUgKmZpbGUpCiAgIHJldHVybjsKIH0KIAorc3RhdGljIHZvaWQKK251bGxf ZmlsZV9mc2VlayAoc3RydWN0IHVpX2ZpbGUgKnN0cmVhbSwgbG9uZyBvZmZz ZXQsIGludCB3aGVuY2UpCit7CisgIHJldHVybjsKK30KKwogdm9pZCAqCiB1 aV9maWxlX2RhdGEgKHN0cnVjdCB1aV9maWxlICpmaWxlKQogewpAQCAtMjI4 LDYgKzIzNywxMiBAQCB1aV9maWxlX3JlYWQgKHN0cnVjdCB1aV9maWxlICpm aWxlLCBjaGFyCiB9CiAKIHZvaWQKK3VpX2ZpbGVfZnNlZWsgKHN0cnVjdCB1 aV9maWxlICpmaWxlLCBsb25nIG9mZnNldCwgaW50IHdoZW5jZSkKK3sKKyAg ZmlsZS0+dG9fZnNlZWsgKGZpbGUsIG9mZnNldCwgd2hlbmNlKTsKK30KKwor dm9pZAogZnB1dHNfdW5maWx0ZXJlZCAoY29uc3QgY2hhciAqYnVmLCBzdHJ1 Y3QgdWlfZmlsZSAqZmlsZSkKIHsKICAgZmlsZS0+dG9fZnB1dHMgKGJ1Ziwg ZmlsZSk7CkBAIC0yODQsNiArMjk5LDEyIEBAIHNldF91aV9maWxlX2ZwdXRz IChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwKIH0KIAogdm9pZAorc2V0X3VpX2Zp bGVfZnNlZWsgKHN0cnVjdCB1aV9maWxlICpmaWxlLCB1aV9maWxlX2ZzZWVr X2Z0eXBlICpmc2Vla19wKQoreworICBmaWxlLT50b19mc2VlayA9IGZzZWVr X3A7Cit9CisKK3ZvaWQKIHNldF91aV9maWxlX2RhdGEgKHN0cnVjdCB1aV9m aWxlICpmaWxlLCB2b2lkICpkYXRhLAogCQkgIHVpX2ZpbGVfZGVsZXRlX2Z0 eXBlICpkZWxldGUpCiB7CkBAIC00NjksNiArNDkwLDcgQEAgc3RhdGljIHVp X2ZpbGVfaXNhdHR5X2Z0eXBlIHN0ZGlvX2ZpbGVfaQogc3RhdGljIHVpX2Zp bGVfZGVsZXRlX2Z0eXBlIHN0ZGlvX2ZpbGVfZGVsZXRlOwogc3RhdGljIHN0 cnVjdCB1aV9maWxlICpzdGRpb19maWxlX25ldyAoRklMRSAqZmlsZSwgaW50 IGNsb3NlX3ApOwogc3RhdGljIHVpX2ZpbGVfZmx1c2hfZnR5cGUgc3RkaW9f ZmlsZV9mbHVzaDsKK3N0YXRpYyB1aV9maWxlX2ZzZWVrX2Z0eXBlIHN0ZGlv X2ZpbGVfZnNlZWs7CiAKIHN0YXRpYyBpbnQgc3RkaW9fZmlsZV9tYWdpYzsK IApAQCAtNDk5LDYgKzUyMSw3IEBAIHN0ZGlvX2ZpbGVfbmV3IChGSUxFICpm aWxlLCBpbnQgY2xvc2VfcCkKICAgc2V0X3VpX2ZpbGVfZnB1dHMgKHVpX2Zp bGUsIHN0ZGlvX2ZpbGVfZnB1dHMpOwogICBzZXRfdWlfZmlsZV9yZWFkICh1 aV9maWxlLCBzdGRpb19maWxlX3JlYWQpOwogICBzZXRfdWlfZmlsZV9pc2F0 dHkgKHVpX2ZpbGUsIHN0ZGlvX2ZpbGVfaXNhdHR5KTsKKyAgc2V0X3VpX2Zp bGVfZnNlZWsgKHVpX2ZpbGUsIHN0ZGlvX2ZpbGVfZnNlZWspOwogICByZXR1 cm4gdWlfZmlsZTsKIH0KIApAQCAtNjE2LDYgKzYzOSwxOSBAQCBzdGRpb19m aWxlX2lzYXR0eSAoc3RydWN0IHVpX2ZpbGUgKmZpbGUpCiAgIHJldHVybiAo aXNhdHR5IChzdGRpby0+ZmQpKTsKIH0KIAorc3RhdGljIHZvaWQKK3N0ZGlv X2ZpbGVfZnNlZWsgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBsb25nIG9mZnNl dCwgaW50IHdoZW5jZSkKK3sKKyAgc3RydWN0IHN0ZGlvX2ZpbGUgKnN0ZGlv ID0gdWlfZmlsZV9kYXRhIChmaWxlKTsKKworICBpZiAoc3RkaW8tPm1hZ2lj ICE9ICZzdGRpb19maWxlX21hZ2ljKQorICAgIGludGVybmFsX2Vycm9yIChf X0ZJTEVfXywgX19MSU5FX18sCisJCSAgICBfKCJzdGRpb19maWxlX2ZzZWVr OiBiYWQgbWFnaWMgbnVtYmVyIikpOworCisgIGlmIChmc2VlayAoc3RkaW8t PmZpbGUsIG9mZnNldCwgd2hlbmNlKSkKKyAgICB3YXJuaW5nIChfKCJmc2Vl ayBmYWlsOiAlcyIpLCBzYWZlX3N0cmVycm9yIChlcnJubykpOworfQorCiAv KiBMaWtlIGZkb3BlbigpLiAgQ3JlYXRlIGEgdWlfZmlsZSBmcm9tIGEgcHJl dmlvdXNseSBvcGVuZWQgRklMRS4gICovCiAKIHN0cnVjdCB1aV9maWxlICoK LS0tIGEvdWktZmlsZS5oCisrKyBiL3VpLWZpbGUuaApAQCAtNzksNiArNzks MTEgQEAgdHlwZWRlZiB2b2lkICh1aV9maWxlX2RlbGV0ZV9mdHlwZSkgKHN0 cgogZXh0ZXJuIHZvaWQgc2V0X3VpX2ZpbGVfZGF0YSAoc3RydWN0IHVpX2Zp bGUgKnN0cmVhbSwgdm9pZCAqZGF0YSwKIAkJCSAgICAgIHVpX2ZpbGVfZGVs ZXRlX2Z0eXBlICpkZWxldGUpOwogCit0eXBlZGVmIHZvaWQgKHVpX2ZpbGVf ZnNlZWtfZnR5cGUpIChzdHJ1Y3QgdWlfZmlsZSAqIHN0cmVhbSwgbG9uZyBv ZmZzZXQsCisJCQkJICAgIGludCB3aGVuY2UpOworZXh0ZXJuIHZvaWQgc2V0 X3VpX2ZpbGVfZnNlZWsgKHN0cnVjdCB1aV9maWxlICpzdHJlYW0sCisJCQkg ICAgICAgdWlfZmlsZV9mc2Vla19mdHlwZSAqZnNlZWspOworCiBleHRlcm4g dm9pZCAqdWlfZmlsZV9kYXRhIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSk7CiAK IApAQCAtMTEzLDYgKzExOCw4IEBAIGV4dGVybiBjaGFyICp1aV9maWxlX29i c2F2ZXN0cmluZyAoc3RydWMKIAogZXh0ZXJuIGxvbmcgdWlfZmlsZV9yZWFk IChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgY2hhciAqYnVmLCBsb25nIGxlbmd0 aF9idWYpOwogCitleHRlcm4gdm9pZCB1aV9maWxlX2ZzZWVrIChzdHJ1Y3Qg dWlfZmlsZSAqIGZpbGUsIGxvbmcgb2Zmc2V0LCBpbnQgd2hlbmNlKTsKKwog LyogQ3JlYXRlL29wZW4gYSBtZW1vcnkgYmFzZWQgZmlsZS4gIENhbiBiZSB1 c2VkIGFzIGEgc2NyYXRjaCBidWZmZXIKICAgIGZvciBjb2xsZWN0aW5nIG91 dHB1dC4gICovCiBleHRlcm4gc3RydWN0IHVpX2ZpbGUgKm1lbV9maWxlb3Bl biAodm9pZCk7Cg== --0015175d0a4c422fe504d07d4d73--