From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103525-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5611 invoked by alias); 19 Jul 2013 07:29:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5584 invoked by uid 89); 19 Jul 2013 07:29:15 -0000
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1
Received: from Unknown (HELO mail-oa0-f44.google.com) (209.85.219.44)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Jul 2013 07:29:09 +0000
Received: by mail-oa0-f44.google.com with SMTP id l10so5454166oag.17        for <gdb-patches@sourceware.org>; Fri, 19 Jul 2013 00:29:02 -0700 (PDT)
X-Received: by 10.60.162.67 with SMTP id xy3mr16829388oeb.26.1374218942405; Fri, 19 Jul 2013 00:29:02 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.60.116.101 with HTTP; Fri, 19 Jul 2013 00:28:22 -0700 (PDT)
In-Reply-To: <87hafsc7cd.fsf@fleche.redhat.com>
References: <CANFwon1gnBtdU2jbrZ9bCVuF3dMPAY2syeB1oMBXE1x4PSDLNA@mail.gmail.com> <51D2E749.9020604@codesourcery.com> <CANFwon34nGekzdhGMA4=-0_1n_5CQ2jnxeq8bo8SjLU5e4wP-g@mail.gmail.com> <51D4030F.6070000@codesourcery.com> <CANFwon23=5E8DH4KHK0jMU+ZP33DtEzZNFQpYOQDzUq+oo80QQ@mail.gmail.com> <51D42272.20209@codesourcery.com> <CANFwon0GvGudzY2=LuROho=kSWY7bjv0dPE=GxZWjmhOrtC1xQ@mail.gmail.com> <87r4f6gxfn.fsf@fleche.redhat.com> <CANFwon2EcxGLbhuiBpcQuvsqMFOsQSO85CB0ZAtn42VpdLWzKw@mail.gmail.com> <87hafsc7cd.fsf@fleche.redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Fri, 19 Jul 2013 07:29:00 -0000
Message-ID: <CANFwon3VP=j_EoHvQ4X+D97nKkX-qL11iFDfTMVamv2HFY-jFw@mail.gmail.com>
Subject: Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes
To: Tom Tromey <tromey@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-SW-Source: 2013-07/txt/msg00465.txt.bz2

On Thu, Jul 18, 2013 at 9:42 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> With "call" or "fprintf".
> Hui> The dprintf is directly outputted by inferior.  So the string is:
> Hui> "foobarbazqux" At foo entry
>
> Hui> But with others, the dprintf is outputted by GDB.  So the string is:
> Hui> ~"\"foobarbazqux\" At foo entry\n"
>
> Hui> That is why I use different $foobarbazqux.
>
> Ah, ok, that makes sense.  The patch is ok.
>
> Tom

Checked in http://sourceware.org/ml/gdb-cvs/2013-07/msg00090.html

Do you think this patch is OK for 7.6 branch?

Thanks,
Hui