From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12339 invoked by alias); 11 Aug 2012 15:20:26 -0000 Received: (qmail 12329 invoked by uid 22791); 11 Aug 2012 15:20:24 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 11 Aug 2012 15:20:11 +0000 Received: by pbbro12 with SMTP id ro12so5021190pbb.0 for ; Sat, 11 Aug 2012 08:20:11 -0700 (PDT) Received: by 10.68.234.6 with SMTP id ua6mr6203254pbc.117.1344698411478; Sat, 11 Aug 2012 08:20:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.239.132 with HTTP; Sat, 11 Aug 2012 08:19:31 -0700 (PDT) In-Reply-To: <1866631.Ri6KkAT9H2@qiyao.dyndns.org> References: <5020BF3A.8030809@mentor.com> <1866631.Ri6KkAT9H2@qiyao.dyndns.org> From: Hui Zhu Date: Sat, 11 Aug 2012 15:20:00 -0000 Message-ID: Subject: Re: [RFC] Autoload-breakpoints new version [3/9] notification async To: Yao Qi Cc: gdb-patches@sourceware.org, Hui Zhu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00337.txt.bz2 On Wed, Aug 8, 2012 at 9:24 PM, Yao Qi wrote: > On Tuesday, August 07, 2012 03:09:46 PM Hui Zhu wrote: >> This patch is the extend for the notification function. >> Current notification function cannot handle the packet when GDB doesn't = want >> to send or receive packet from the remote target. This patch do the exte= nd >> make GDB can handle the notification even if it doesn't send or receive >> packet. > > I am trying to understand what current GDB can do, and what patched GDB c= an > do. If I understand it correctly, > > - current GDB only handle notification when it sends or receives packets > - patched GDB can handle notification at any time when notification com= es > in. > > Looks this patch changes the way of GDB handling notifications (from "onl= y-on- > send-receive" handling to "anytime" handling), but has nothing to do with= how > notification is sent out from remote stub. If so, why do you add > "NotificationAsync" in remote_supported_packet? Remote supported packets= are > used to tell GDB what feature remote stub has or doesn't have. In other > words, "NotificationAsync" is a feature of GDB, instead of remote stub, s= o we > don't need "NotificationAsync". I agree with you. > > I applied patch 1/9 and 3/9, and get following regressions in gdbserver w= ith > async mode on. > > FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (unknown output > after running) > FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (2) (unknown o= utput > after running) > FAIL: gdb.mi/mi-nsmoribund.exp: resume all, waiting for program exit > (timeout) My part is OK, Could you tell me how do you do the test? > > -- > Yao (=E9=BD=90=E5=B0=A7) Thanks, Hui