From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4639 invoked by alias); 11 Dec 2012 07:22:32 -0000 Received: (qmail 4619 invoked by uid 22791); 11 Dec 2012 07:22:30 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 07:22:25 +0000 Received: by mail-bk0-f41.google.com with SMTP id jg9so1580237bkc.0 for ; Mon, 10 Dec 2012 23:22:23 -0800 (PST) Received: by 10.204.4.145 with SMTP id 17mr5847620bkr.34.1355210543325; Mon, 10 Dec 2012 23:22:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.226.140 with HTTP; Mon, 10 Dec 2012 23:21:43 -0800 (PST) In-Reply-To: <87vcc9el7d.fsf@fleche.redhat.com> References: <87txryx36w.fsf@fleche.redhat.com> <87lid9x6hl.fsf@fleche.redhat.com> <87vcc9el7d.fsf@fleche.redhat.com> From: Hui Zhu Date: Tue, 11 Dec 2012 07:22:00 -0000 Message-ID: Subject: Re: [PATCH] Add fseek to ui-file To: Tom Tromey Cc: gdb-patches ml , Hui Zhu Content-Type: multipart/mixed; boundary=001517588e7807e1cd04d08e8ba4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00309.txt.bz2 --001517588e7807e1cd04d08e8ba4 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 915 On Tue, Dec 11, 2012 at 3:55 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> Post a patch for that. Please help me review it. > > I think _p is not a super choice for a suffix. > It already has a meaning in gdb. > "_ptr" or most anything else would be better. > > Tom Post a new version. Please help me review it. Thanks, Hui 2012-12-11 Hui Zhu * ui-file.c (set_ui_file_flush): Change flush to flush_ptr. (set_ui_file_isatty): Change isatty to isatty_ptr. (set_ui_file_rewind): Change rewind to rewind_ptr. (set_ui_file_put): Change put to put_ptr. (set_ui_file_write): Change write to write_ptr. (set_ui_file_write_async_safe): Change write_async_safe to write_async_safe_ptr. (set_ui_file_read): Change read to read_ptr. (set_ui_file_fputs): Change fputs to fputs_ptr. (set_ui_file_data): Change delete to delete_ptr. --001517588e7807e1cd04d08e8ba4 Content-Type: text/plain; charset=US-ASCII; name="ui-file-change-arg.txt" Content-Disposition: attachment; filename="ui-file-change-arg.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hakpc32t0 Content-length: 2937 LS0tIGEvdWktZmlsZS5jCisrKyBiL3VpLWZpbGUuYwpAQCAtMjM0LDYxICsy MzQsNjEgQEAgZnB1dHNfdW5maWx0ZXJlZCAoY29uc3QgY2hhciAqYnVmLCBz dHJ1YwogfQogCiB2b2lkCi1zZXRfdWlfZmlsZV9mbHVzaCAoc3RydWN0IHVp X2ZpbGUgKmZpbGUsIHVpX2ZpbGVfZmx1c2hfZnR5cGUgKmZsdXNoKQorc2V0 X3VpX2ZpbGVfZmx1c2ggKHN0cnVjdCB1aV9maWxlICpmaWxlLCB1aV9maWxl X2ZsdXNoX2Z0eXBlICpmbHVzaF9wdHIpCiB7Ci0gIGZpbGUtPnRvX2ZsdXNo ID0gZmx1c2g7CisgIGZpbGUtPnRvX2ZsdXNoID0gZmx1c2hfcHRyOwogfQog CiB2b2lkCi1zZXRfdWlfZmlsZV9pc2F0dHkgKHN0cnVjdCB1aV9maWxlICpm aWxlLCB1aV9maWxlX2lzYXR0eV9mdHlwZSAqaXNhdHR5KQorc2V0X3VpX2Zp bGVfaXNhdHR5IChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgdWlfZmlsZV9pc2F0 dHlfZnR5cGUgKmlzYXR0eV9wdHIpCiB7Ci0gIGZpbGUtPnRvX2lzYXR0eSA9 IGlzYXR0eTsKKyAgZmlsZS0+dG9faXNhdHR5ID0gaXNhdHR5X3B0cjsKIH0K IAogdm9pZAotc2V0X3VpX2ZpbGVfcmV3aW5kIChzdHJ1Y3QgdWlfZmlsZSAq ZmlsZSwgdWlfZmlsZV9yZXdpbmRfZnR5cGUgKnJld2luZCkKK3NldF91aV9m aWxlX3Jld2luZCAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVpX2ZpbGVfcmV3 aW5kX2Z0eXBlICpyZXdpbmRfcHRyKQogewotICBmaWxlLT50b19yZXdpbmQg PSByZXdpbmQ7CisgIGZpbGUtPnRvX3Jld2luZCA9IHJld2luZF9wdHI7CiB9 CiAKIHZvaWQKLXNldF91aV9maWxlX3B1dCAoc3RydWN0IHVpX2ZpbGUgKmZp bGUsIHVpX2ZpbGVfcHV0X2Z0eXBlICpwdXQpCitzZXRfdWlfZmlsZV9wdXQg KHN0cnVjdCB1aV9maWxlICpmaWxlLCB1aV9maWxlX3B1dF9mdHlwZSAqcHV0 X3B0cikKIHsKLSAgZmlsZS0+dG9fcHV0ID0gcHV0OworICBmaWxlLT50b19w dXQgPSBwdXRfcHRyOwogfQogCiB2b2lkCiBzZXRfdWlfZmlsZV93cml0ZSAo c3RydWN0IHVpX2ZpbGUgKmZpbGUsCi0JCSAgICB1aV9maWxlX3dyaXRlX2Z0 eXBlICp3cml0ZSkKKwkJICAgIHVpX2ZpbGVfd3JpdGVfZnR5cGUgKndyaXRl X3B0cikKIHsKLSAgZmlsZS0+dG9fd3JpdGUgPSB3cml0ZTsKKyAgZmlsZS0+ dG9fd3JpdGUgPSB3cml0ZV9wdHI7CiB9CiAKIHZvaWQKIHNldF91aV9maWxl X3dyaXRlX2FzeW5jX3NhZmUgKHN0cnVjdCB1aV9maWxlICpmaWxlLAotCQkJ ICAgICAgdWlfZmlsZV93cml0ZV9hc3luY19zYWZlX2Z0eXBlICp3cml0ZV9h c3luY19zYWZlKQorCQkJICAgICAgdWlfZmlsZV93cml0ZV9hc3luY19zYWZl X2Z0eXBlICp3cml0ZV9hc3luY19zYWZlX3B0cikKIHsKLSAgZmlsZS0+dG9f d3JpdGVfYXN5bmNfc2FmZSA9IHdyaXRlX2FzeW5jX3NhZmU7CisgIGZpbGUt PnRvX3dyaXRlX2FzeW5jX3NhZmUgPSB3cml0ZV9hc3luY19zYWZlX3B0cjsK IH0KIAogdm9pZAotc2V0X3VpX2ZpbGVfcmVhZCAoc3RydWN0IHVpX2ZpbGUg KmZpbGUsIHVpX2ZpbGVfcmVhZF9mdHlwZSAqcmVhZCkKK3NldF91aV9maWxl X3JlYWQgKHN0cnVjdCB1aV9maWxlICpmaWxlLCB1aV9maWxlX3JlYWRfZnR5 cGUgKnJlYWRfcHRyKQogewotICBmaWxlLT50b19yZWFkID0gcmVhZDsKKyAg ZmlsZS0+dG9fcmVhZCA9IHJlYWRfcHRyOwogfQogCiB2b2lkCi1zZXRfdWlf ZmlsZV9mcHV0cyAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVpX2ZpbGVfZnB1 dHNfZnR5cGUgKmZwdXRzKQorc2V0X3VpX2ZpbGVfZnB1dHMgKHN0cnVjdCB1 aV9maWxlICpmaWxlLCB1aV9maWxlX2ZwdXRzX2Z0eXBlICpmcHV0c19wdHIp CiB7Ci0gIGZpbGUtPnRvX2ZwdXRzID0gZnB1dHM7CisgIGZpbGUtPnRvX2Zw dXRzID0gZnB1dHNfcHRyOwogfQogCiB2b2lkCiBzZXRfdWlfZmlsZV9kYXRh IChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgdm9pZCAqZGF0YSwKLQkJICB1aV9m aWxlX2RlbGV0ZV9mdHlwZSAqZGVsZXRlKQorCQkgIHVpX2ZpbGVfZGVsZXRl X2Z0eXBlICpkZWxldGVfcHRyKQogewogICBmaWxlLT50b19kYXRhID0gZGF0 YTsKLSAgZmlsZS0+dG9fZGVsZXRlID0gZGVsZXRlOworICBmaWxlLT50b19k ZWxldGUgPSBkZWxldGVfcHRyOwogfQogCiAvKiB1aV9maWxlIHV0aWxpdHkg ZnVuY3Rpb24gZm9yIGNvbnZlcnRpbmcgYSBgYHN0cnVjdCB1aV9maWxlJycg aW50bwo= --001517588e7807e1cd04d08e8ba4--