Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Hui Zhu <hui_zhu@mentor.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add autoload-breakpoints [2/6] ReportAsync-test
Date: Thu, 10 May 2012 15:31:00 -0000	[thread overview]
Message-ID: <CANFwon3P8-u=nLKtkSjN=3U23QV8YocHbu0DPen1eQ68ynGiKA@mail.gmail.com> (raw)
In-Reply-To: <4FA8DBB9.50505@codesourcery.com>

On Tue, May 8, 2012 at 4:39 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 05/08/2012 03:26 PM, Hui Zhu wrote:
>>> Remote feature should be tested in remote target or board file.
>>> You are testing a remote feature GDB unconditionally, even in native
>>> gdb.  It looks incorrect to me.
>>>
>>
>> This just a check for the this small gdbserver is OK.   I don't think this test will work with board or something.
>>
>
> My point is this test case exercises some "undesired" features w.r.t.
> testsuite and config.  I configure and build a native gdb, and type
> `make -k check' in gdb build dir.  Then, I'll examine the FAILs in
> gdb.sum to see the status of native gdb, what does the FAILs, if any, in
> gdb.remote/reportasync-test.exp mean to me?  It sounds like "I did a
> medical check-up to my eyes, but result tells me something wrong in my
> ears".  However, I am not strongly against this test case.

Sorry I didn't get your point.  This test is for the GDB, but not for
others, right?  :)

>
> We have a sub-dir gdb.server under testsuite/, *.exp are run even when
> testing native gdb, but they are test cases to GDBserver, rather than
> GDB, AFAICS.  When we see some FAILs in it, that means GDBserver has
> something wrong, at least ideally :)

All of them are for the gdbserver.  But this test is not for
GDBserver.  If you think this dir is OK, I will move it.

When gdbserver support some function that use report-async, we can add
a new test for that.

Thanks,
Hui


      reply	other threads:[~2012-05-10 15:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 10:54 Hui Zhu
2012-04-28  7:15 ` Hui Zhu
2012-04-28 20:37   ` Yao Qi
2012-05-08  7:26     ` Hui Zhu
2012-05-08  8:39       ` Yao Qi
2012-05-10 15:31         ` Hui Zhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANFwon3P8-u=nLKtkSjN=3U23QV8YocHbu0DPen1eQ68ynGiKA@mail.gmail.com' \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox