From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6191 invoked by alias); 13 Dec 2012 01:45:50 -0000 Received: (qmail 6183 invoked by uid 22791); 13 Dec 2012 01:45:49 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 01:45:16 +0000 Received: by mail-bk0-f41.google.com with SMTP id jg9so714906bkc.0 for ; Wed, 12 Dec 2012 17:45:15 -0800 (PST) Received: by 10.204.157.26 with SMTP id z26mr65241bkw.101.1355363115143; Wed, 12 Dec 2012 17:45:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.226.140 with HTTP; Wed, 12 Dec 2012 17:44:35 -0800 (PST) In-Reply-To: <878v939t6z.fsf@fleche.redhat.com> References: <87txryx36w.fsf@fleche.redhat.com> <87lid9x6hl.fsf@fleche.redhat.com> <87vcc9el7d.fsf@fleche.redhat.com> <878v939t6z.fsf@fleche.redhat.com> From: Hui Zhu Date: Thu, 13 Dec 2012 01:45:00 -0000 Message-ID: Subject: Re: [PATCH] Add fseek to ui-file To: Tom Tromey Cc: gdb-patches ml , Hui Zhu Content-Type: multipart/mixed; boundary=0015175d0a4c05137604d0b211f9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00427.txt.bz2 --0015175d0a4c05137604d0b211f9 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1061 On Wed, Dec 12, 2012 at 11:38 PM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> +static int > Hui> +null_file_fseek (struct ui_file *stream, long offset, int whence) > Hui> +{ > Hui> + return 0; > Hui> +} > > Why does this return success rather than error? > It seems strange to report success when nothing actually happens. > > Hui> +typedef int (ui_file_fseek_ftype) (struct ui_file * stream, long offset, > Hui> + int whence); > > Extra space after "*". > > Hui> +extern int ui_file_fseek (struct ui_file * file, long offset, int whence); > > Here too. > > Tom Post a new version according to your comments. Thanks, Hui 2012-12-13 Hui Zhu * ui-file.c (ui_file): Add to_fseek. (ui_file_new): Call set_ui_file_fseek. (null_file_fseek, ui_file_fseek, set_ui_file_fseek, stdio_file_fseek): New functions. (stdio_file_new): Call set_ui_file_fseek. * ui-file.h (ui_file_fseek_ftype): New typedef. (set_ui_file_fseek, ui_file_fseek): New externs. --0015175d0a4c05137604d0b211f9 Content-Type: text/plain; charset=US-ASCII; name="ui-file-fseek.txt" Content-Disposition: attachment; filename="ui-file-fseek.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_han869kk0 Content-length: 4742 LS0tIGEvdWktZmlsZS5jCisrKyBiL3VpLWZpbGUuYwpAQCAtMzYsNiArMzYs NyBAQCBzdGF0aWMgdWlfZmlsZV9mbHVzaF9mdHlwZSBudWxsX2ZpbGVfZmx1 CiBzdGF0aWMgdWlfZmlsZV9kZWxldGVfZnR5cGUgbnVsbF9maWxlX2RlbGV0 ZTsKIHN0YXRpYyB1aV9maWxlX3Jld2luZF9mdHlwZSBudWxsX2ZpbGVfcmV3 aW5kOwogc3RhdGljIHVpX2ZpbGVfcHV0X2Z0eXBlIG51bGxfZmlsZV9wdXQ7 CitzdGF0aWMgdWlfZmlsZV9mc2Vla19mdHlwZSBudWxsX2ZpbGVfZnNlZWs7 CiAKIHN0cnVjdCB1aV9maWxlCiAgIHsKQEAgLTQ5LDYgKzUwLDcgQEAgc3Ry dWN0IHVpX2ZpbGUKICAgICB1aV9maWxlX2lzYXR0eV9mdHlwZSAqdG9faXNh dHR5OwogICAgIHVpX2ZpbGVfcmV3aW5kX2Z0eXBlICp0b19yZXdpbmQ7CiAg ICAgdWlfZmlsZV9wdXRfZnR5cGUgKnRvX3B1dDsKKyAgICB1aV9maWxlX2Zz ZWVrX2Z0eXBlICp0b19mc2VlazsKICAgICB2b2lkICp0b19kYXRhOwogICB9 OwogaW50IHVpX2ZpbGVfbWFnaWM7CkBAIC02OCw2ICs3MCw3IEBAIHVpX2Zp bGVfbmV3ICh2b2lkKQogICBzZXRfdWlfZmlsZV9pc2F0dHkgKGZpbGUsIG51 bGxfZmlsZV9pc2F0dHkpOwogICBzZXRfdWlfZmlsZV9yZXdpbmQgKGZpbGUs IG51bGxfZmlsZV9yZXdpbmQpOwogICBzZXRfdWlfZmlsZV9wdXQgKGZpbGUs IG51bGxfZmlsZV9wdXQpOworICBzZXRfdWlfZmlsZV9mc2VlayAoZmlsZSwg bnVsbF9maWxlX2ZzZWVrKTsKICAgcmV0dXJuIGZpbGU7CiB9CiAKQEAgLTE3 MCw2ICsxNzMsMTIgQEAgbnVsbF9maWxlX2RlbGV0ZSAoc3RydWN0IHVpX2Zp bGUgKmZpbGUpCiAgIHJldHVybjsKIH0KIAorc3RhdGljIGludAorbnVsbF9m aWxlX2ZzZWVrIChzdHJ1Y3QgdWlfZmlsZSAqc3RyZWFtLCBsb25nIG9mZnNl dCwgaW50IHdoZW5jZSkKK3sKKyAgcmV0dXJuIC0xOworfQorCiB2b2lkICoK IHVpX2ZpbGVfZGF0YSAoc3RydWN0IHVpX2ZpbGUgKmZpbGUpCiB7CkBAIC0y MjcsNiArMjM2LDEyIEBAIHVpX2ZpbGVfcmVhZCAoc3RydWN0IHVpX2ZpbGUg KmZpbGUsIGNoYXIKICAgcmV0dXJuIGZpbGUtPnRvX3JlYWQgKGZpbGUsIGJ1 ZiwgbGVuZ3RoX2J1Zik7IAogfQogCitpbnQKK3VpX2ZpbGVfZnNlZWsgKHN0 cnVjdCB1aV9maWxlICpmaWxlLCBsb25nIG9mZnNldCwgaW50IHdoZW5jZSkK K3sKKyAgcmV0dXJuIGZpbGUtPnRvX2ZzZWVrIChmaWxlLCBvZmZzZXQsIHdo ZW5jZSk7Cit9CisKIHZvaWQKIGZwdXRzX3VuZmlsdGVyZWQgKGNvbnN0IGNo YXIgKmJ1Ziwgc3RydWN0IHVpX2ZpbGUgKmZpbGUpCiB7CkBAIC0yODQsNiAr Mjk5LDEyIEBAIHNldF91aV9maWxlX2ZwdXRzIChzdHJ1Y3QgdWlfZmlsZSAq ZmlsZSwKIH0KIAogdm9pZAorc2V0X3VpX2ZpbGVfZnNlZWsgKHN0cnVjdCB1 aV9maWxlICpmaWxlLCB1aV9maWxlX2ZzZWVrX2Z0eXBlICpmc2Vla19wdHIp Cit7CisgIGZpbGUtPnRvX2ZzZWVrID0gZnNlZWtfcHRyOworfQorCit2b2lk CiBzZXRfdWlfZmlsZV9kYXRhIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgdm9p ZCAqZGF0YSwKIAkJICB1aV9maWxlX2RlbGV0ZV9mdHlwZSAqZGVsZXRlX3B0 cikKIHsKQEAgLTQ2OSw2ICs0OTAsNyBAQCBzdGF0aWMgdWlfZmlsZV9pc2F0 dHlfZnR5cGUgc3RkaW9fZmlsZV9pCiBzdGF0aWMgdWlfZmlsZV9kZWxldGVf ZnR5cGUgc3RkaW9fZmlsZV9kZWxldGU7CiBzdGF0aWMgc3RydWN0IHVpX2Zp bGUgKnN0ZGlvX2ZpbGVfbmV3IChGSUxFICpmaWxlLCBpbnQgY2xvc2VfcCk7 CiBzdGF0aWMgdWlfZmlsZV9mbHVzaF9mdHlwZSBzdGRpb19maWxlX2ZsdXNo Oworc3RhdGljIHVpX2ZpbGVfZnNlZWtfZnR5cGUgc3RkaW9fZmlsZV9mc2Vl azsKIAogc3RhdGljIGludCBzdGRpb19maWxlX21hZ2ljOwogCkBAIC00OTks NiArNTIxLDcgQEAgc3RkaW9fZmlsZV9uZXcgKEZJTEUgKmZpbGUsIGludCBj bG9zZV9wKQogICBzZXRfdWlfZmlsZV9mcHV0cyAodWlfZmlsZSwgc3RkaW9f ZmlsZV9mcHV0cyk7CiAgIHNldF91aV9maWxlX3JlYWQgKHVpX2ZpbGUsIHN0 ZGlvX2ZpbGVfcmVhZCk7CiAgIHNldF91aV9maWxlX2lzYXR0eSAodWlfZmls ZSwgc3RkaW9fZmlsZV9pc2F0dHkpOworICBzZXRfdWlfZmlsZV9mc2VlayAo dWlfZmlsZSwgc3RkaW9fZmlsZV9mc2Vlayk7CiAgIHJldHVybiB1aV9maWxl OwogfQogCkBAIC02MTYsNiArNjM5LDE4IEBAIHN0ZGlvX2ZpbGVfaXNhdHR5 IChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSkKICAgcmV0dXJuIChpc2F0dHkgKHN0 ZGlvLT5mZCkpOwogfQogCitzdGF0aWMgaW50CitzdGRpb19maWxlX2ZzZWVr IChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgbG9uZyBvZmZzZXQsIGludCB3aGVu Y2UpCit7CisgIHN0cnVjdCBzdGRpb19maWxlICpzdGRpbyA9IHVpX2ZpbGVf ZGF0YSAoZmlsZSk7CisKKyAgaWYgKHN0ZGlvLT5tYWdpYyAhPSAmc3RkaW9f ZmlsZV9tYWdpYykKKyAgICBpbnRlcm5hbF9lcnJvciAoX19GSUxFX18sIF9f TElORV9fLAorCQkgICAgXygic3RkaW9fZmlsZV9mc2VlazogYmFkIG1hZ2lj IG51bWJlciIpKTsKKworICByZXR1cm4gZnNlZWsgKHN0ZGlvLT5maWxlLCBv ZmZzZXQsIHdoZW5jZSk7Cit9CisKIC8qIExpa2UgZmRvcGVuKCkuICBDcmVh dGUgYSB1aV9maWxlIGZyb20gYSBwcmV2aW91c2x5IG9wZW5lZCBGSUxFLiAg Ki8KIAogc3RydWN0IHVpX2ZpbGUgKgotLS0gYS91aS1maWxlLmgKKysrIGIv dWktZmlsZS5oCkBAIC03OSw2ICs3OSwxMSBAQCB0eXBlZGVmIHZvaWQgKHVp X2ZpbGVfZGVsZXRlX2Z0eXBlKSAoc3RyCiBleHRlcm4gdm9pZCBzZXRfdWlf ZmlsZV9kYXRhIChzdHJ1Y3QgdWlfZmlsZSAqc3RyZWFtLCB2b2lkICpkYXRh LAogCQkJICAgICAgdWlfZmlsZV9kZWxldGVfZnR5cGUgKmRlbGV0ZSk7CiAK K3R5cGVkZWYgaW50ICh1aV9maWxlX2ZzZWVrX2Z0eXBlKSAoc3RydWN0IHVp X2ZpbGUgKnN0cmVhbSwgbG9uZyBvZmZzZXQsCisJCQkJICAgaW50IHdoZW5j ZSk7CitleHRlcm4gdm9pZCBzZXRfdWlfZmlsZV9mc2VlayAoc3RydWN0IHVp X2ZpbGUgKnN0cmVhbSwKKwkJCSAgICAgICB1aV9maWxlX2ZzZWVrX2Z0eXBl ICpmc2Vla19wdHIpOworCiBleHRlcm4gdm9pZCAqdWlfZmlsZV9kYXRhIChz dHJ1Y3QgdWlfZmlsZSAqZmlsZSk7CiAKIApAQCAtMTEzLDYgKzExOCw4IEBA IGV4dGVybiBjaGFyICp1aV9maWxlX29ic2F2ZXN0cmluZyAoc3RydWMKIAog ZXh0ZXJuIGxvbmcgdWlfZmlsZV9yZWFkIChzdHJ1Y3QgdWlfZmlsZSAqZmls ZSwgY2hhciAqYnVmLCBsb25nIGxlbmd0aF9idWYpOwogCitleHRlcm4gaW50 IHVpX2ZpbGVfZnNlZWsgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBsb25nIG9m ZnNldCwgaW50IHdoZW5jZSk7CisKIC8qIENyZWF0ZS9vcGVuIGEgbWVtb3J5 IGJhc2VkIGZpbGUuICBDYW4gYmUgdXNlZCBhcyBhIHNjcmF0Y2ggYnVmZmVy CiAgICBmb3IgY29sbGVjdGluZyBvdXRwdXQuICAqLwogZXh0ZXJuIHN0cnVj dCB1aV9maWxlICptZW1fZmlsZW9wZW4gKHZvaWQpOwo= --0015175d0a4c05137604d0b211f9--