From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25603 invoked by alias); 3 Jul 2013 08:42:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25532 invoked by uid 89); 3 Jul 2013 08:42:23 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_RG autolearn=ham version=3.3.1 Received: from mail-bk0-f48.google.com (HELO mail-bk0-f48.google.com) (209.85.214.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Jul 2013 08:42:20 +0000 Received: by mail-bk0-f48.google.com with SMTP id jf17so2739402bkc.7 for ; Wed, 03 Jul 2013 01:42:18 -0700 (PDT) X-Received: by 10.204.191.132 with SMTP id dm4mr4480144bkb.66.1372840938542; Wed, 03 Jul 2013 01:42:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.0.75 with HTTP; Wed, 3 Jul 2013 01:41:38 -0700 (PDT) In-Reply-To: <51D2E749.9020604@codesourcery.com> References: <51D2E749.9020604@codesourcery.com> From: Hui Zhu Date: Wed, 03 Jul 2013 08:42:00 -0000 Message-ID: Subject: Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes To: Yao Qi Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=20cf3030bcc579dc4b04e09770c6 X-Virus-Found: No X-SW-Source: 2013-07/txt/msg00106.txt.bz2 --20cf3030bcc579dc4b04e09770c6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 983 On Tue, Jul 2, 2013 at 10:44 PM, Yao Qi wrote: > On 07/02/2013 09:30 PM, Hui Zhu wrote: >> >> --- a/gdb/mi/mi-cmd-break.c >> +++ b/gdb/mi/mi-cmd-break.c >> @@ -128,6 +128,9 @@ mi_argv_to_format (char **argv, int argc >> case '\v': >> obstack_grow (&obstack, "\\v", 2); >> break; >> + case '"': >> + obstack_grow (&obstack, "\\\"", 2); >> + break; >> default: >> if (isprint (argv[0][i])) >> obstack_grow (&obstack, argv[0] + i, 1); > > > IWBN to add a test case to show that GDB handles double quotes correctly > after this fix. Hi Yao, Thanks for your remind. Post a new patch about test this issue. Best, Hui > > -- > Yao (=E9=BD=90=E5=B0=A7) 2013-07-03 Hui Zhu PR gdb/15692 mi/mi-cmd-break.c (mi_argv_to_format): Handle double quotes. 2013-07-03 Hui Zhu PR gdb/15692 gdb.mi/mi-dprintf.exp: Add double quotes test. --20cf3030bcc579dc4b04e09770c6 Content-Type: text/plain; charset=US-ASCII; name="dprintf-mi-handle-quotes.txt" Content-Disposition: attachment; filename="dprintf-mi-handle-quotes.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hioa0j5s0 Content-length: 452 LS0tIGEvZ2RiL21pL21pLWNtZC1icmVhay5jCisrKyBiL2dkYi9taS9taS1j bWQtYnJlYWsuYwpAQCAtMTI4LDYgKzEyOCw5IEBAIG1pX2FyZ3ZfdG9fZm9y bWF0IChjaGFyICoqYXJndiwgaW50IGFyZ2MKIAljYXNlICdcdic6CiAJICBv YnN0YWNrX2dyb3cgKCZvYnN0YWNrLCAiXFx2IiwgMik7CiAJICBicmVhazsK KwljYXNlICciJzoKKwkgIG9ic3RhY2tfZ3JvdyAoJm9ic3RhY2ssICJcXFwi IiwgMik7CisJICBicmVhazsKIAlkZWZhdWx0OgogCSAgaWYgKGlzcHJpbnQg KGFyZ3ZbMF1baV0pKQogCSAgICBvYnN0YWNrX2dyb3cgKCZvYnN0YWNrLCBh cmd2WzBdICsgaSwgMSk7Cg== --20cf3030bcc579dc4b04e09770c6 Content-Type: text/plain; charset=US-ASCII; name="dprintf-mi-handle-quotes-test.txt" Content-Disposition: attachment; filename="dprintf-mi-handle-quotes-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hioa0qus1 Content-length: 1643 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktZHByaW50Zi5leHAKKysr IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktZHByaW50Zi5leHAKQEAgLTQ4 LDcgKzQ4LDcgQEAgbWlfZ2RiX3Rlc3QgIjMtZHByaW50Zi1pbnNlcnQgMjki IFwKIG1pX2dkYl90ZXN0ICItYnJlYWstaW5zZXJ0IG1haW4iICIuKiIgIm1p IGluc2VydCBicmVha3BvaW50IG1haW4iCiBtaV9kZWxldGVfYnJlYWtwb2lu dHMKIAotbWlfZ2RiX3Rlc3QgIjQtZHByaW50Zi1pbnNlcnQgZm9vIFwiQXQg Zm9vIGVudHJ5XFxuXCIiIFwKK21pX2dkYl90ZXN0ICI0LWRwcmludGYtaW5z ZXJ0IGZvbyBcIlxcXCJmb29iYXJiYXpxdXhcXFwiIEF0IGZvbyBlbnRyeVxc blwiIiBcCiAgICAgIjRcXF5kb25lLGJrcHQ9XHtudW1iZXI9XCIuKlwiLHR5 cGU9XCJkcHJpbnRmXCIuKmZ1bmM9XCJmb29cIixmaWxlPVwiLiptaS1kcHJp bnRmLmNcIixmdWxsbmFtZT1cIi4qbWktZHByaW50Zi5jXCIsbGluZT1cIi4q XCIuKiIgIm1pIGluc2VydCBkcHJpbnRmIGZvbyIKIAogbWlfZ2RiX3Rlc3Qg IjUtZHByaW50Zi1pbnNlcnQgJGRwX2xvY2F0aW9uMSBcImFyZz0lZCwgZz0l ZFxcblwiIGFyZyBnIiBcCkBAIC02OCw3ICs2OCw3IEBAIHByb2MgbWlfY29u dGludWVfZHByaW50ZiB7YXJnc30gewogCW1pX3J1bl9jbWQKIAlzZXQgbXNn ICJtaSAxc3QgZHByaW50ZiIKIAlnZGJfZXhwZWN0IHsKLSAgICAgICAgICAg IC1yZSAiLipBdCBmb28gZW50cnkuKmFyZz0xMjM0LCBnPTEyMzQiIHsKKyAg ICAgICAgICAgIC1yZSAiLipmb29iYXJiYXpxdXguKkF0IGZvbyBlbnRyeS4q YXJnPTEyMzQsIGc9MTIzNCIgewogCQlwYXNzICRtc2cKIAkgICAgfQogCSAg ICAtcmUgIi4qJG1pX2dkYl9wcm9tcHQkIiB7CkBAIC04Myw3ICs4Myw3IEBA IHByb2MgbWlfY29udGludWVfZHByaW50ZiB7YXJnc30gewogCXNldCBtc2cg Im1pIDJuZCBkcHJpbnRmIgogCW1pX3NlbmRfcmVzdW1pbmdfY29tbWFuZCAi ZXhlYy1jb250aW51ZSIgIiRtc2cgY29udGludWUiCiAJZ2RiX2V4cGVjdCB7 Ci0gICAgICAgICAgICAtcmUgIi4qQXQgZm9vIGVudHJ5Liphcmc9MTIzNSwg Zz0yMjIyIiB7CisgICAgICAgICAgICAtcmUgIi4qZm9vYmFyYmF6cXV4LipB dCBmb28gZW50cnkuKmFyZz0xMjM1LCBnPTIyMjIiIHsKIAkJcGFzcyAkbXNn CiAJICAgIH0KIAkgICAgLXJlICIuKiRtaV9nZGJfcHJvbXB0JCIgewo= --20cf3030bcc579dc4b04e09770c6--