From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19628 invoked by alias); 7 Aug 2011 16:30:15 -0000 Received: (qmail 19604 invoked by uid 22791); 7 Aug 2011 16:30:14 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Aug 2011 16:29:56 +0000 Received: by fxg9 with SMTP id 9so3763415fxg.0 for ; Sun, 07 Aug 2011 09:29:54 -0700 (PDT) Received: by 10.223.159.2 with SMTP id h2mr6148947fax.5.1312734594671; Sun, 07 Aug 2011 09:29:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.115.11 with HTTP; Sun, 7 Aug 2011 09:28:31 -0700 (PDT) From: Hui Zhu Date: Sun, 07 Aug 2011 16:30:00 -0000 Message-ID: Subject: [PATCH]tracepoint.c: Add conditionals num to find_matching_tracepoint To: gdb-patches ml Content-Type: multipart/mixed; boundary=0023541876f833240304a9ecd7e8 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00132.txt.bz2 --0023541876f833240304a9ecd7e8 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 771 Hi, I found that when I set some tracepoint to a same address, and use tsave. And use "target tfile " to open it. It will only one tracepoint available. And output some words like: Created tracepoint 1 for target's tracepoint 1 at 0x40050a. Assuming tracepoint 1 is same as target's tracepoint 2 at 0x40050a. Assuming tracepoint 1 is same as target's tracepoint 3 at 0x40050a. This is because find_matching_tracepoint didn't check the num. And I think the tracepoint have the same address is really helpful for user. Because we can set different condition to make tracepoint more powerful. So I make following patch. Please help me review it. Thanks, Hui 2011-08-08 Hui Zhu * tracepoint.c (find_matching_tracepoint): Add number check. --0023541876f833240304a9ecd7e8 Content-Type: text/plain; charset=US-ASCII; name="tfile-same-address.txt" Content-Disposition: attachment; filename="tfile-same-address.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gr286ww70 Content-length: 493 LS0tCiB0cmFjZXBvaW50LmMgfCAgICAxICsKIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKQoKLS0tIGEvdHJhY2Vwb2ludC5jCisrKyBiL3RyYWNl cG9pbnQuYwpAQCAtMzExMSw2ICszMTExLDcgQEAgZmluZF9tYXRjaGluZ190 cmFjZXBvaW50IChzdHJ1Y3QgdXBsb2FkZQogICAgICAgaWYgKGItPnR5cGUg PT0gdXRwLT50eXBlCiAJICAmJiB0LT5zdGVwX2NvdW50ID09IHV0cC0+c3Rl cAogCSAgJiYgdC0+cGFzc19jb3VudCA9PSB1dHAtPnBhc3MKKwkgICYmIHQt PmJhc2UubnVtYmVyID09IHV0cC0+bnVtYmVyCiAJICAvKiBGSVhNRSBhbHNv IHRlc3QgY29uZGl0aW9uYWxzIGFuZCBhY3Rpb25zLiAgKi8KIAkgICkKIAl7 Cg== --0023541876f833240304a9ecd7e8--