From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31138 invoked by alias); 17 Dec 2012 03:00:27 -0000 Received: (qmail 31115 invoked by uid 22791); 17 Dec 2012 03:00:24 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-oa0-f41.google.com (HELO mail-oa0-f41.google.com) (209.85.219.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Dec 2012 03:00:20 +0000 Received: by mail-oa0-f41.google.com with SMTP id k14so5461719oag.0 for ; Sun, 16 Dec 2012 19:00:19 -0800 (PST) Received: by 10.60.169.171 with SMTP id af11mr10349958oec.92.1355713219230; Sun, 16 Dec 2012 19:00:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.84.5 with HTTP; Sun, 16 Dec 2012 18:59:39 -0800 (PST) In-Reply-To: <87ehiszbm9.fsf@fleche.redhat.com> References: <87txryx36w.fsf@fleche.redhat.com> <87lid9x6hl.fsf@fleche.redhat.com> <87vcc9el7d.fsf@fleche.redhat.com> <878v939t6z.fsf@fleche.redhat.com> <87ehiszbm9.fsf@fleche.redhat.com> From: Hui Zhu Date: Mon, 17 Dec 2012 03:00:00 -0000 Message-ID: Subject: Re: [PATCH] Add fseek to ui-file To: Tom Tromey Cc: gdb-patches ml , Hui Zhu Content-Type: multipart/mixed; boundary=bcaec54d4766d97bdd04d1039420 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00532.txt.bz2 --bcaec54d4766d97bdd04d1039420 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 435 On Sat, Dec 15, 2012 at 3:18 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> +static int > Hui> +null_file_fseek (struct ui_file *stream, long offset, int whence) > Hui> +{ > Hui> + return -1; > Hui> +} > > It seems like this should set errno as well. > > Tom OK. Set errno to EBADF in new patch because its means "The stream specified is not a seekable stream". Thanks, Hui --bcaec54d4766d97bdd04d1039420 Content-Type: text/plain; charset=US-ASCII; name="ui-file-fseek.txt" Content-Disposition: attachment; filename="ui-file-fseek.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hat0m6mx0 Content-length: 4771 LS0tIGEvdWktZmlsZS5jCisrKyBiL3VpLWZpbGUuYwpAQCAtMzYsNiArMzYs NyBAQCBzdGF0aWMgdWlfZmlsZV9mbHVzaF9mdHlwZSBudWxsX2ZpbGVfZmx1 CiBzdGF0aWMgdWlfZmlsZV9kZWxldGVfZnR5cGUgbnVsbF9maWxlX2RlbGV0 ZTsKIHN0YXRpYyB1aV9maWxlX3Jld2luZF9mdHlwZSBudWxsX2ZpbGVfcmV3 aW5kOwogc3RhdGljIHVpX2ZpbGVfcHV0X2Z0eXBlIG51bGxfZmlsZV9wdXQ7 CitzdGF0aWMgdWlfZmlsZV9mc2Vla19mdHlwZSBudWxsX2ZpbGVfZnNlZWs7 CiAKIHN0cnVjdCB1aV9maWxlCiAgIHsKQEAgLTQ5LDYgKzUwLDcgQEAgc3Ry dWN0IHVpX2ZpbGUKICAgICB1aV9maWxlX2lzYXR0eV9mdHlwZSAqdG9faXNh dHR5OwogICAgIHVpX2ZpbGVfcmV3aW5kX2Z0eXBlICp0b19yZXdpbmQ7CiAg ICAgdWlfZmlsZV9wdXRfZnR5cGUgKnRvX3B1dDsKKyAgICB1aV9maWxlX2Zz ZWVrX2Z0eXBlICp0b19mc2VlazsKICAgICB2b2lkICp0b19kYXRhOwogICB9 OwogaW50IHVpX2ZpbGVfbWFnaWM7CkBAIC02OCw2ICs3MCw3IEBAIHVpX2Zp bGVfbmV3ICh2b2lkKQogICBzZXRfdWlfZmlsZV9pc2F0dHkgKGZpbGUsIG51 bGxfZmlsZV9pc2F0dHkpOwogICBzZXRfdWlfZmlsZV9yZXdpbmQgKGZpbGUs IG51bGxfZmlsZV9yZXdpbmQpOwogICBzZXRfdWlfZmlsZV9wdXQgKGZpbGUs IG51bGxfZmlsZV9wdXQpOworICBzZXRfdWlfZmlsZV9mc2VlayAoZmlsZSwg bnVsbF9maWxlX2ZzZWVrKTsKICAgcmV0dXJuIGZpbGU7CiB9CiAKQEAgLTE3 MCw2ICsxNzMsMTQgQEAgbnVsbF9maWxlX2RlbGV0ZSAoc3RydWN0IHVpX2Zp bGUgKmZpbGUpCiAgIHJldHVybjsKIH0KIAorc3RhdGljIGludAorbnVsbF9m aWxlX2ZzZWVrIChzdHJ1Y3QgdWlfZmlsZSAqc3RyZWFtLCBsb25nIG9mZnNl dCwgaW50IHdoZW5jZSkKK3sKKyAgZXJybm8gPSBFQkFERjsKKworICByZXR1 cm4gLTE7Cit9CisKIHZvaWQgKgogdWlfZmlsZV9kYXRhIChzdHJ1Y3QgdWlf ZmlsZSAqZmlsZSkKIHsKQEAgLTIyNyw2ICsyMzgsMTIgQEAgdWlfZmlsZV9y ZWFkIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgY2hhcgogICByZXR1cm4gZmls ZS0+dG9fcmVhZCAoZmlsZSwgYnVmLCBsZW5ndGhfYnVmKTsgCiB9CiAKK2lu dAordWlfZmlsZV9mc2VlayAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIGxvbmcg b2Zmc2V0LCBpbnQgd2hlbmNlKQoreworICByZXR1cm4gZmlsZS0+dG9fZnNl ZWsgKGZpbGUsIG9mZnNldCwgd2hlbmNlKTsKK30KKwogdm9pZAogZnB1dHNf dW5maWx0ZXJlZCAoY29uc3QgY2hhciAqYnVmLCBzdHJ1Y3QgdWlfZmlsZSAq ZmlsZSkKIHsKQEAgLTI4NCw2ICszMDEsMTIgQEAgc2V0X3VpX2ZpbGVfZnB1 dHMgKHN0cnVjdCB1aV9maWxlICpmaWxlLAogfQogCiB2b2lkCitzZXRfdWlf ZmlsZV9mc2VlayAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIHVpX2ZpbGVfZnNl ZWtfZnR5cGUgKmZzZWVrX3B0cikKK3sKKyAgZmlsZS0+dG9fZnNlZWsgPSBm c2Vla19wdHI7Cit9CisKK3ZvaWQKIHNldF91aV9maWxlX2RhdGEgKHN0cnVj dCB1aV9maWxlICpmaWxlLCB2b2lkICpkYXRhLAogCQkgIHVpX2ZpbGVfZGVs ZXRlX2Z0eXBlICpkZWxldGVfcHRyKQogewpAQCAtNDY5LDYgKzQ5Miw3IEBA IHN0YXRpYyB1aV9maWxlX2lzYXR0eV9mdHlwZSBzdGRpb19maWxlX2kKIHN0 YXRpYyB1aV9maWxlX2RlbGV0ZV9mdHlwZSBzdGRpb19maWxlX2RlbGV0ZTsK IHN0YXRpYyBzdHJ1Y3QgdWlfZmlsZSAqc3RkaW9fZmlsZV9uZXcgKEZJTEUg KmZpbGUsIGludCBjbG9zZV9wKTsKIHN0YXRpYyB1aV9maWxlX2ZsdXNoX2Z0 eXBlIHN0ZGlvX2ZpbGVfZmx1c2g7CitzdGF0aWMgdWlfZmlsZV9mc2Vla19m dHlwZSBzdGRpb19maWxlX2ZzZWVrOwogCiBzdGF0aWMgaW50IHN0ZGlvX2Zp bGVfbWFnaWM7CiAKQEAgLTQ5OSw2ICs1MjMsNyBAQCBzdGRpb19maWxlX25l dyAoRklMRSAqZmlsZSwgaW50IGNsb3NlX3ApCiAgIHNldF91aV9maWxlX2Zw dXRzICh1aV9maWxlLCBzdGRpb19maWxlX2ZwdXRzKTsKICAgc2V0X3VpX2Zp bGVfcmVhZCAodWlfZmlsZSwgc3RkaW9fZmlsZV9yZWFkKTsKICAgc2V0X3Vp X2ZpbGVfaXNhdHR5ICh1aV9maWxlLCBzdGRpb19maWxlX2lzYXR0eSk7Cisg IHNldF91aV9maWxlX2ZzZWVrICh1aV9maWxlLCBzdGRpb19maWxlX2ZzZWVr KTsKICAgcmV0dXJuIHVpX2ZpbGU7CiB9CiAKQEAgLTYxNiw2ICs2NDEsMTgg QEAgc3RkaW9fZmlsZV9pc2F0dHkgKHN0cnVjdCB1aV9maWxlICpmaWxlKQog ICByZXR1cm4gKGlzYXR0eSAoc3RkaW8tPmZkKSk7CiB9CiAKK3N0YXRpYyBp bnQKK3N0ZGlvX2ZpbGVfZnNlZWsgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBs b25nIG9mZnNldCwgaW50IHdoZW5jZSkKK3sKKyAgc3RydWN0IHN0ZGlvX2Zp bGUgKnN0ZGlvID0gdWlfZmlsZV9kYXRhIChmaWxlKTsKKworICBpZiAoc3Rk aW8tPm1hZ2ljICE9ICZzdGRpb19maWxlX21hZ2ljKQorICAgIGludGVybmFs X2Vycm9yIChfX0ZJTEVfXywgX19MSU5FX18sCisJCSAgICBfKCJzdGRpb19m aWxlX2ZzZWVrOiBiYWQgbWFnaWMgbnVtYmVyIikpOworCisgIHJldHVybiBm c2VlayAoc3RkaW8tPmZpbGUsIG9mZnNldCwgd2hlbmNlKTsKK30KKwogLyog TGlrZSBmZG9wZW4oKS4gIENyZWF0ZSBhIHVpX2ZpbGUgZnJvbSBhIHByZXZp b3VzbHkgb3BlbmVkIEZJTEUuICAqLwogCiBzdHJ1Y3QgdWlfZmlsZSAqCi0t LSBhL3VpLWZpbGUuaAorKysgYi91aS1maWxlLmgKQEAgLTc5LDYgKzc5LDEx IEBAIHR5cGVkZWYgdm9pZCAodWlfZmlsZV9kZWxldGVfZnR5cGUpIChzdHIK IGV4dGVybiB2b2lkIHNldF91aV9maWxlX2RhdGEgKHN0cnVjdCB1aV9maWxl ICpzdHJlYW0sIHZvaWQgKmRhdGEsCiAJCQkgICAgICB1aV9maWxlX2RlbGV0 ZV9mdHlwZSAqZGVsZXRlKTsKIAordHlwZWRlZiBpbnQgKHVpX2ZpbGVfZnNl ZWtfZnR5cGUpIChzdHJ1Y3QgdWlfZmlsZSAqc3RyZWFtLCBsb25nIG9mZnNl dCwKKwkJCQkgICBpbnQgd2hlbmNlKTsKK2V4dGVybiB2b2lkIHNldF91aV9m aWxlX2ZzZWVrIChzdHJ1Y3QgdWlfZmlsZSAqc3RyZWFtLAorCQkJICAgICAg IHVpX2ZpbGVfZnNlZWtfZnR5cGUgKmZzZWVrX3B0cik7CisKIGV4dGVybiB2 b2lkICp1aV9maWxlX2RhdGEgKHN0cnVjdCB1aV9maWxlICpmaWxlKTsKIAog CkBAIC0xMTMsNiArMTE4LDggQEAgZXh0ZXJuIGNoYXIgKnVpX2ZpbGVfb2Jz YXZlc3RyaW5nIChzdHJ1YwogCiBleHRlcm4gbG9uZyB1aV9maWxlX3JlYWQg KHN0cnVjdCB1aV9maWxlICpmaWxlLCBjaGFyICpidWYsIGxvbmcgbGVuZ3Ro X2J1Zik7CiAKK2V4dGVybiBpbnQgdWlfZmlsZV9mc2VlayAoc3RydWN0IHVp X2ZpbGUgKmZpbGUsIGxvbmcgb2Zmc2V0LCBpbnQgd2hlbmNlKTsKKwogLyog Q3JlYXRlL29wZW4gYSBtZW1vcnkgYmFzZWQgZmlsZS4gIENhbiBiZSB1c2Vk IGFzIGEgc2NyYXRjaCBidWZmZXIKICAgIGZvciBjb2xsZWN0aW5nIG91dHB1 dC4gICovCiBleHRlcm4gc3RydWN0IHVpX2ZpbGUgKm1lbV9maWxlb3BlbiAo dm9pZCk7Cg== --bcaec54d4766d97bdd04d1039420--