From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10293 invoked by alias); 20 Apr 2013 07:38:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10283 invoked by uid 89); 20 Apr 2013 07:38:06 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-oa0-f41.google.com (HELO mail-oa0-f41.google.com) (209.85.219.41) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 20 Apr 2013 07:38:05 +0000 Received: by mail-oa0-f41.google.com with SMTP id g12so3664830oah.14 for ; Sat, 20 Apr 2013 00:38:04 -0700 (PDT) X-Received: by 10.60.27.136 with SMTP id t8mr5804366oeg.92.1366443484445; Sat, 20 Apr 2013 00:38:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Sat, 20 Apr 2013 00:37:24 -0700 (PDT) In-Reply-To: References: <87fvymwkbi.fsf@fleche.redhat.com> From: Hui Zhu Date: Mon, 22 Apr 2013 00:24:00 -0000 Message-ID: Subject: Re: [PATCH] Let dprintf can be saved To: Tom Tromey Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=e89a8fb1fe2a7f043204dac5ea31 X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00640.txt.bz2 --e89a8fb1fe2a7f043204dac5ea31 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1034 Hi, This is patch add test for dprintf to save-bp.exp. Thanks, Hui 2013-04-20 Hui Zhu PR gdb/15165 * gdb.base/save-bp.exp: Add test for dprintf. On Sat, Apr 20, 2013 at 3:04 PM, Hui Zhu wrote: > On Sat, Apr 20, 2013 at 12:34 AM, Tom Tromey wrote: >>>>>>> "Hui" == Hui Zhu writes: >> >> Hui> +static void >> Hui> +dprintf_print_recreate (struct breakpoint *tp, struct ui_file *fp) >> >> This needs a short introductory comment. >> See the other print_recreate methods for examples. > > Fixed. > >> >> I think this patch could use a test case. >> It could be added wherever the existing "save" tests live. > > OK. I will post a patch for it later. > > Thanks, > Hui > >> >> Tom > > 2013-04-18 Hui Zhu > > PR gdb/15165 > > * breakpoint.c (dprintf_print_recreate): New. > (save_breakpoints): Let it not save dprintf commands. > (initialize_breakpoint_ops): Set dprintf_print_recreate. --e89a8fb1fe2a7f043204dac5ea31 Content-Type: text/plain; charset=US-ASCII; name="dprintf-save-test.txt" Content-Disposition: attachment; filename="dprintf-save-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfqh52ju1 Content-length: 2123 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9zYXZlLWJwLmV4cAorKysg Yi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3NhdmUtYnAuZXhwCkBAIC00Niw2 ICs0Niw4IEBAIHNldCBsb2NfYnA1IFtnZGJfZ2V0X2xpbmVfbnVtYmVyICJ3 aXRoIGMKIGdkYl9icmVha3BvaW50ICR7c3JjZmlsZX06JHtsb2NfYnA1fQog Z2RiX3Rlc3QgImNvbW1hbmRzXG5zaWxlbnRcbmVuZCIgIkVuZCB3aXRoLioi ICJhZGQgYnJlYWtwb2ludCBjb21tYW5kcyIKIAorZ2RiX3Rlc3QgImRwcmlu dGYgJHtzcmNmaWxlfToke2xvY19icDV9LFwiQXQgZm9vIGVudHJ5XFxuXCIi ICJEcHJpbnRmIC4qIgorCiAjIE5vdywgc2F2ZSB0aGUgYnJlYWtwb2ludHMg aW50byBhIGZpbGUuLi4KIHJlbW90ZV9maWxlIGhvc3QgZGVsZXRlICJicHMi CiBnZGJfdGVzdCAic2F2ZSBicmVha3BvaW50IGJwcyIKQEAgLTY1LDUgKzY3 LDYgQEAgZ2RiX3Rlc3QgInNvdXJjZSBicHMiCiAKICMgTm93LCB2ZXJpZnkg dGhhdCBhbGwgYnJlYWtwb2ludHMgaGF2ZSBiZWVuIGNyZWF0ZWQgY29ycmVj dGx5Li4uCiBzZXQgYnBfcm93X3N0YXJ0ICJcWzAtOVxdKyArYnJlYWtwb2lu dCAra2VlcCAreSArMHhcWzAtOWEtZlxdKyAraW4iCitzZXQgZHByaW50Zl9y b3dfc3RhcnQgIlxbMC05XF0rICtkcHJpbnRmICtrZWVwICt5ICsweFxbMC05 YS1mXF0rICtpbiIKIGdkYl90ZXN0ICJpbmZvIGJyZWFrIiBcCi0gICIgKk51 bSArVHlwZSArRGlzcCArRW5iICtBZGRyZXNzICtXaGF0XHJcbiRicF9yb3df c3RhcnQgYnJlYWtfbWUgYXQgLiokc3JjZmlsZTpcWzAtOVxdK1xyXG4kYnBf cm93X3N0YXJ0IG1haW4gYXQgLiokc3JjZmlsZTokbG9jX2JwMlxyXG4kYnBf cm93X3N0YXJ0IG1haW4gYXQgLiokc3JjZmlsZTokbG9jX2JwMyArdGhyZWFk IDFcclxuXFsgXHRdK3N0b3Agb25seSBpbiB0aHJlYWQgMVxyXG4kYnBfcm93 X3N0YXJ0IG1haW4gYXQgLiokc3JjZmlsZTokbG9jX2JwNFxyXG5cWyBcdFxd K3N0b3Agb25seSBpZiBpID09IDEoIFxcKChob3N0fHRhcmdldCkgZXZhbHNc XCkpP1xyXG4kYnBfcm93X3N0YXJ0IG1haW4gYXQgLiokc3JjZmlsZTokbG9j X2JwNVxyXG5cWyBcdFxdK3NpbGVudCIKKyAgIiAqTnVtICtUeXBlICtEaXNw ICtFbmIgK0FkZHJlc3MgK1doYXRcclxuJGJwX3Jvd19zdGFydCBicmVha19t ZSBhdCAuKiRzcmNmaWxlOlxbMC05XF0rXHJcbiRicF9yb3dfc3RhcnQgbWFp biBhdCAuKiRzcmNmaWxlOiRsb2NfYnAyXHJcbiRicF9yb3dfc3RhcnQgbWFp biBhdCAuKiRzcmNmaWxlOiRsb2NfYnAzICt0aHJlYWQgMVxyXG5cWyBcdF0r c3RvcCBvbmx5IGluIHRocmVhZCAxXHJcbiRicF9yb3dfc3RhcnQgbWFpbiBh dCAuKiRzcmNmaWxlOiRsb2NfYnA0XHJcblxbIFx0XF0rc3RvcCBvbmx5IGlm IGkgPT0gMSggXFwoKGhvc3R8dGFyZ2V0KSBldmFsc1xcKSk/XHJcbiRicF9y b3dfc3RhcnQgbWFpbiBhdCAuKiRzcmNmaWxlOiRsb2NfYnA1XHJcblxbIFx0 XF0rc2lsZW50XHJcbiRkcHJpbnRmX3Jvd19zdGFydCBtYWluIGF0IC4qJHNy Y2ZpbGU6JGxvY19icDVcclxuXFsgXHRcXStwcmludGYuKiIK --e89a8fb1fe2a7f043204dac5ea31--