From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97451-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18403 invoked by alias); 5 Jan 2013 05:37:21 -0000
Received: (qmail 18211 invoked by uid 22791); 5 Jan 2013 05:37:20 -0000
X-SWARE-Spam-Status: No, hits=-4.7 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Jan 2013 05:37:14 +0000
Received: by mail-ob0-f179.google.com with SMTP id x4so15331519obh.38        for <gdb-patches@sourceware.org>; Fri, 04 Jan 2013 21:37:13 -0800 (PST)
Received: by 10.182.192.68 with SMTP id he4mr40170051obc.99.1357364233682; Fri, 04 Jan 2013 21:37:13 -0800 (PST)
MIME-Version: 1.0
Received: by 10.60.84.5 with HTTP; Fri, 4 Jan 2013 21:36:33 -0800 (PST)
In-Reply-To: <87obh5ypk7.fsf@fleche.redhat.com>
References: <CANFwon27w-6+73nUvm-RYip2Ku8JcGRkVzJVwNrWOzsij6ES8A@mail.gmail.com> <87d2xm0wrs.fsf@fleche.redhat.com> <CANFwon1fZ0nP0rr10MDJmr7gJYqoDKiXsDAp8w=4iFU5MbekfQ@mail.gmail.com> <87obh5ypk7.fsf@fleche.redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Sat, 05 Jan 2013 05:37:00 -0000
Message-ID: <CANFwon2pVusoP15YcaOR63vcDz8yeCB97xpH14pgZaXwbgCBqQ@mail.gmail.com>
Subject: Re: [PATCH] Add extern of output_command to utils.h
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00081.txt.bz2

On Fri, Jan 4, 2013 at 10:45 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> What about add this extern to valprint.h that is included by printcmd.c?
>
> That sounds ok to me.
>
> Tom

Post a new version according to that.  Please help me review it.

Thanks,
Hui

2013-01-05  Hui Zhu  <hui_zhu@mentor.com>

	* tracepoint.c: Remove extern of function output_command.
	* valprint.h.h (output_command): New extern.

--- a/tracepoint.c
+++ b/tracepoint.c
@@ -93,11 +93,6 @@ extern void (*deprecated_readline_begin_
 extern char *(*deprecated_readline_hook) (char *);
 extern void (*deprecated_readline_end_hook) (void);

-/* GDB commands implemented in other modules:
- */
-
-extern void output_command (char *, int);
-
 /*
    Tracepoint.c:

--- a/valprint.h
+++ b/valprint.h
@@ -205,4 +205,6 @@ extern void generic_printstr (struct ui_
 			      int quote_char, int c_style_terminator,
 			      const struct value_print_options *options);

+extern void output_command (char *, int);
+
 #endif