From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13378 invoked by alias); 16 Apr 2013 09:33:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13362 invoked by uid 89); 16 Apr 2013 09:33:01 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-oa0-f45.google.com (HELO mail-oa0-f45.google.com) (209.85.219.45) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Apr 2013 09:33:00 +0000 Received: by mail-oa0-f45.google.com with SMTP id o17so147896oag.4 for ; Tue, 16 Apr 2013 02:32:59 -0700 (PDT) X-Received: by 10.60.27.136 with SMTP id t8mr558461oeg.92.1366104779445; Tue, 16 Apr 2013 02:32:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Tue, 16 Apr 2013 02:32:19 -0700 (PDT) In-Reply-To: <5166722F.2000709@codesourcery.com> References: <51665508.5050706@mentor.com> <516655FC.6070206@mentor.com> <51666686.7090203@codesourcery.com> <516668F3.3030405@mentor.com> <5166722F.2000709@codesourcery.com> From: Hui Zhu Date: Tue, 16 Apr 2013 15:44:00 -0000 Message-ID: Subject: Re: [PATCH] store trace default-collect to target [6/6] test To: Yao Qi Cc: Hui Zhu , gdb-patches ml Content-Type: multipart/mixed; boundary=e89a8fb1fe2a1add9004da770ed0 X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00468.txt.bz2 --e89a8fb1fe2a1add9004da770ed0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 1832 Hi Yao, Thanks for your review. On Thu, Apr 11, 2013 at 4:19 PM, Yao Qi wrote: > On 04/11/2013 03:40 PM, Hui Zhu wrote: >> >> --- a/testsuite/gdb.trace/tstatus.exp >> +++ b/testsuite/gdb.trace/tstatus.exp >> @@ -137,6 +137,8 @@ proc test_tracepoints {} { >> >> test_tracepoints >> >> +gdb_test_no_output "set default-collect \$regs" >> + >> set tracefile [standard_output_file ${testfile}] >> # Save trace frames to tfile. >> gdb_test "tsave ${tracefile}.tf" \ >> @@ -147,6 +149,8 @@ gdb_test "tsave -ctf ${tracefile}.ctf" \ >> "Trace data saved to directory '${tracefile}.ctf'.*" \ >> "save ctf trace file" >> >> +gdb_test_no_output "set default-collect" >> + >> # Change target to tfile. >> set test "change to tfile target" >> gdb_test_multiple "target tfile ${tracefile}.tf" "$test" { >> @@ -159,6 +163,8 @@ gdb_test_multiple "target tfile ${tracef >> } >> } >> >> +gdb_test "show default-collect" "The list of expressions to collect by >> default is \"\\\$regs\".*" >> + >> # Convert "(because I can) to "\(because I can\)" >> set tstatus_output [string map {\( \\(} $tstatus_output] >> set tstatus_output [string map {\) \\)} $tstatus_output] > > > I am afraid that tstatus.exp is not a good place to test "default-collect= ". > The tstatus.exp is to test the output of command 'tstatus' in various > situations, and also test that the output of 'tstatus' command on tfile > target is identical to its output on the ctf target. Probably, actions.e= xp > is better, IMO. Move it to actions.exp Post a new version for it. Best, Hui 2013-04-16 Hui Zhu * gdb.trace/disconnected-tracing.exp (disconnected_tracing): Add test for default-collect. * gdb.trace/actions.exp: Add test for default-collect. > > -- > Yao (=E9=BD=90=E5=B0=A7) --e89a8fb1fe2a1add9004da770ed0 Content-Type: text/plain; charset=US-ASCII; name="defc-test.txt" Content-Disposition: attachment; filename="defc-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfkvhbjr0 Content-length: 2270 LS0tIGEvdGVzdHN1aXRlL2dkYi50cmFjZS9hY3Rpb25zLmV4cAorKysgYi90 ZXN0c3VpdGUvZ2RiLnRyYWNlL2FjdGlvbnMuZXhwCkBAIC0yNDgsNiArMjQ4 LDggQEAgZ2RiX3RyYWNlX3NldGFjdGlvbnMgInNldCBhY3Rpb25zIGZvciBm aQogICAgICJjb2xsZWN0IFwkcmVncyIgIl4kIiBcCiAgICAgImVuZCIgIiIK IAorZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJzZXQgZGVmYXVsdC1jb2xsZWN0IFwk cmVncyIKKwogIyBDaGVjayB0aGUgZGVmaW5pdGlvbiBvZiB0cmFjZXBvaW50 cy4gIFRoZXNlIHRyYWNlcG9pbnRzIG1heSBoYXZlCiAjIGRpZmZlcmVudCBu dW1iZXIgaW4gZGlmZmVyZW50IHJ1bnMuCiAKQEAgLTI1Niw2ICsyNTgsOCBA QCBwcm9jIGNoZWNrX3RyYWNlcG9pbnQgeyBkYXRhX3NvdXJjZSB9IHsKIAln bG9iYWwgZ2RiX3Byb21wdAogCWdsb2JhbCBzcmNmaWxlCiAKKwlnZGJfdGVz dCAic2hvdyBkZWZhdWx0LWNvbGxlY3QiICJUaGUgbGlzdCBvZiBleHByZXNz aW9ucyB0byBjb2xsZWN0IGJ5IGRlZmF1bHQgaXMgXCJcXFwkcmVnc1wiLioi CisKIAlzZXQgdHBfb25fZ2RiX2NfdGVzdCAwCiAJc2V0IHRwX29uX2dkYl9h c21fdGVzdCAwCiAJc2V0IHRwX29uX2dkYl9yZWN1cnNpb25fdGVzdCAwCi0t LSBhL3Rlc3RzdWl0ZS9nZGIudHJhY2UvZGlzY29ubmVjdGVkLXRyYWNpbmcu ZXhwCisrKyBiL3Rlc3RzdWl0ZS9nZGIudHJhY2UvZGlzY29ubmVjdGVkLXRy YWNpbmcuZXhwCkBAIC02NSw2ICs2NSw4IEBAIHByb2MgZGlzY29ubmVjdGVk X3RyYWNpbmcgeyAgfSB7CiAJICAgICJjb2xsZWN0IGZvbyIgIl4kIgogCWdk Yl90ZXN0ICJicmVhayBlbmQiICJCcmVha3BvaW50ICR7ZGVjaW1hbH0gYXQg LioiCiAKKwlnZGJfdGVzdF9ub19vdXRwdXQgInNldCBkZWZhdWx0LWNvbGxl Y3QgXCRyZWdzIgorCiAJZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJ0c3RhcnQiCiAK IAlnZGJfdGVzdCAiY29udGludWUiICJDb250aW51aW5nXFwuXFsgXHJcblxd K0JyZWFrcG9pbnQuKiIKQEAgLTczLDYgKzc1LDggQEAgcHJvYyBkaXNjb25u ZWN0ZWRfdHJhY2luZyB7ICB9IHsKIAlnZGJfdGVzdCAiaW5mbyB0cmFjZXBv aW50cyIgIi4qaW4gc3RhcnQgYXQuKiIgXAogCSAgICAiZmlyc3QgaW5mbyB0 cmFjZXBvaW50cyIKIAorCWdkYl90ZXN0X25vX291dHB1dCAic2V0IGRlZmF1 bHQtY29sbGVjdCIKKwogCWdkYl90ZXN0ICJkaXNjb25uZWN0IiAiRW5kaW5n IHJlbW90ZSBkZWJ1Z2dpbmdcXC4iICJmaXJzdCBkaXNjb25uZWN0IgogCWlm IHsgW2dkYl9yZWNvbm5lY3RdID09IDAgfSB7CiAJICAgIHBhc3MgImZpcnN0 IHJlY29ubmVjdCBhZnRlciB1bmxvYWQiCkBAIC04Myw2ICs4Nyw4IEBAIHBy b2MgZGlzY29ubmVjdGVkX3RyYWNpbmcgeyAgfSB7CiAJZ2RiX3Rlc3QgImlu Zm8gdHJhY2Vwb2ludHMiICIuKmluIHN0YXJ0IGF0LioiIFwKIAkgICAgInNl Y29uZCBpbmZvIHRyYWNlcG9pbnRzIgogCisJZ2RiX3Rlc3QgInNob3cgZGVm YXVsdC1jb2xsZWN0IiAiVGhlIGxpc3Qgb2YgZXhwcmVzc2lvbnMgdG8gY29s bGVjdCBieSBkZWZhdWx0IGlzIFwiXFxcJHJlZ3NcIi4qIgorCiAJZGVsZXRl X2JyZWFrcG9pbnRzCiAJZ2RiX3Rlc3QgImluZm8gdHJhY2Vwb2ludHMiICIu Kk5vIHRyYWNlcG9pbnRzLi4qIiBcCiAJICAgICJ0aGlyZCBpbmZvIHRyYWNl cG9pbnRzIgo= --e89a8fb1fe2a1add9004da770ed0--