From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26113 invoked by alias); 9 Mar 2013 14:14:25 -0000 Received: (qmail 26103 invoked by uid 22791); 9 Mar 2013 14:14:23 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ob0-f170.google.com (HELO mail-ob0-f170.google.com) (209.85.214.170) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 09 Mar 2013 14:14:15 +0000 Received: by mail-ob0-f170.google.com with SMTP id wc20so2112799obb.1 for ; Sat, 09 Mar 2013 06:14:14 -0800 (PST) X-Received: by 10.60.24.72 with SMTP id s8mr4652163oef.68.1362838454336; Sat, 09 Mar 2013 06:14:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.60.7 with HTTP; Sat, 9 Mar 2013 06:13:34 -0800 (PST) From: Hui Zhu Date: Sat, 09 Mar 2013 14:14:00 -0000 Message-ID: Subject: [PATCH] Fix gdb crash with tui To: gdb-patches ml Cc: Joel Brobecker Content-Type: multipart/mixed; boundary=e89a8ff1c8aaf502a304d77e8d6d X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00419.txt.bz2 --e89a8ff1c8aaf502a304d77e8d6d Content-Type: text/plain; charset=ISO-8859-1 Content-length: 713 Hi, I got crash when I use tui. The steps to reproduce is: gdb gdb b gdb_main r Ctrl-x A change to TUI mode. Keep click some times. Keep click some times. Then you can get "---Type to continue, or q to quit---" Click . Then the GDB crash. I think this issue is this part should not output "---Type to continue, or q to quit---". So I make a patch to let tui doesn't output "file" just output "fullname". Not sure is a good enough but this issue is fixed. I suggest we fix this issue before next release because it will crash the GDB. Thanks, Hui 2013-03-09 Hui Zhu * source.c (print_source_lines_base): Doesn't output "file". --e89a8ff1c8aaf502a304d77e8d6d Content-Type: text/plain; charset=US-ASCII; name="fix-tui-crash.txt" Content-Disposition: attachment; filename="fix-tui-crash.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_he2usgcj0 Content-length: 1111 LS0tIGEvc291cmNlLmMKKysrIGIvc291cmNlLmMKQEAgLTEzNDQsMTggKzEz NDQsMTYgQEAgcHJpbnRfc291cmNlX2xpbmVzX2Jhc2UgKHN0cnVjdCBzeW10 YWIgKgogCXsKIAkgIHVpX291dF9maWVsZF9pbnQgKHVpb3V0LCAibGluZSIs IGxpbmUpOwogCSAgdWlfb3V0X3RleHQgKHVpb3V0LCAiXHRpbiAiKTsKLQkg IHVpX291dF9maWVsZF9zdHJpbmcgKHVpb3V0LCAiZmlsZSIsCi0JCQkgICAg ICAgc3ltdGFiX3RvX2ZpbGVuYW1lX2Zvcl9kaXNwbGF5IChzKSk7CiAKIAkg IC8qIFRVSSBleHBlY3RzIHRoZSAiZnVsbG5hbWUiIGZpZWxkLiAgV2hpbGUg aXQgaXMKIAkgICAgICF1aV9vdXRfaXNfbWlfbGlrZV9wIGNvbXBhcmVkIHRv IENMSSBpdCBpcyAhdWlfc291cmNlX2xpc3QuICAqLwogCSAgaWYgKHVpX291 dF9pc19taV9saWtlX3AgKHVpb3V0KQogCSAgICAgIHx8ICF1aV9vdXRfdGVz dF9mbGFncyAodWlvdXQsIHVpX3NvdXJjZV9saXN0KSkKLQkgICAgewotCSAg ICAgIGNvbnN0IGNoYXIgKmZ1bGxuYW1lID0gc3ltdGFiX3RvX2Z1bGxuYW1l IChzKTsKKwkgICAgdWlfb3V0X2ZpZWxkX3N0cmluZyAodWlvdXQsICJmdWxs bmFtZSIsIHN5bXRhYl90b19mdWxsbmFtZSAocykpOworCSAgZWxzZQorCSAg ICB1aV9vdXRfZmllbGRfc3RyaW5nICh1aW91dCwgImZpbGUiLAorCQkJCSBz eW10YWJfdG9fZmlsZW5hbWVfZm9yX2Rpc3BsYXkgKHMpKTsKIAotCSAgICAg IHVpX291dF9maWVsZF9zdHJpbmcgKHVpb3V0LCAiZnVsbG5hbWUiLCBmdWxs bmFtZSk7Ci0JICAgIH0KIAkgIHVpX291dF90ZXh0ICh1aW91dCwgIlxuIik7 CiAJfQogCg== --e89a8ff1c8aaf502a304d77e8d6d--