From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17845 invoked by alias); 23 Apr 2013 03:42:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17832 invoked by uid 89); 23 Apr 2013 03:42:32 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ob0-f170.google.com (HELO mail-ob0-f170.google.com) (209.85.214.170) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 23 Apr 2013 03:42:31 +0000 Received: by mail-ob0-f170.google.com with SMTP id eh20so149351obb.15 for ; Mon, 22 Apr 2013 20:42:30 -0700 (PDT) X-Received: by 10.182.246.198 with SMTP id xy6mr11021251obc.1.1366688550328; Mon, 22 Apr 2013 20:42:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Mon, 22 Apr 2013 20:41:50 -0700 (PDT) In-Reply-To: <51748351.2030300@codesourcery.com> References: <51748351.2030300@codesourcery.com> From: Hui Zhu Date: Tue, 23 Apr 2013 17:53:00 -0000 Message-ID: Subject: Re: [PATCH] Fix bug 15181 Missing continue on dprintf that defaults to "gdb" style from "agent" To: Yao Qi Cc: gdb-patches ml , Marc Khouzam Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-04/txt/msg00701.txt.bz2 On Mon, Apr 22, 2013 at 8:24 AM, Yao Qi wrote: > On 04/21/2013 07:06 PM, Hui Zhu wrote: >> >> This patch is from Marc to fix >> http://sourceware.org/bugzilla/show_bug.cgi?id=3D15181 >> I add a test for it. > > > Hui, > I am afraid that it is not correct to append "continue" command to dprintf > commands, considering PR 15075 dprintf inteferes with "next". This patch > removes > "continue" command from dprintf commands, and it is reasonable to remove > "continue", IMO. The patch is not perfect, as it disallows users setting > commands to dprintf, and I prefer to support commands in dprintf, > personally. > > Since you are actively fixing dprintf bugs, feel free to take PR 15075 ov= er, > and fix it first. Then, PR 15181 may not be a bug at all. The patch for remove "continue" is still in discussion, right? So I think the patch from Marc is more easy to handle 15181. And it will not affect new patches. Thanks, Hui And > > -- > Yao (=E9=BD=90=E5=B0=A7)