From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92611-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1121 invoked by alias); 5 Jul 2012 01:15:14 -0000
Received: (qmail 1105 invoked by uid 22791); 5 Jul 2012 01:15:13 -0000
X-SWARE-Spam-Status: No, hits=-4.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-we0-f169.google.com (HELO mail-we0-f169.google.com) (74.125.82.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jul 2012 01:14:53 +0000
Received: by werl57 with SMTP id l57so284579wer.0        for <gdb-patches@sourceware.org>; Wed, 04 Jul 2012 18:14:52 -0700 (PDT)
Received: by 10.216.228.29 with SMTP id e29mr7768271weq.153.1341450892145; Wed, 04 Jul 2012 18:14:52 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.122.193 with HTTP; Wed, 4 Jul 2012 18:14:11 -0700 (PDT)
In-Reply-To: <87wr2s61p9.fsf@fleche.redhat.com>
References: <CANFwon2gboB-_waNACh1jSxrsXeuDSsEq=+b2yDnQV1Q1x4e+g@mail.gmail.com> <87wr2s61p9.fsf@fleche.redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Thu, 05 Jul 2012 01:15:00 -0000
Message-ID: <CANFwon28mYqfvJnVp6e1TEw8wVegA0Cm9DYYuKjTyE7vXSUawg@mail.gmail.com>
Subject: Re: [PATCH]Add option "-at" to "maint agent" and "maint agent-eval"
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>, Stan Shebs <stan_shebs@mentor.com>, 	Yao Qi <Yao_Qi@mentor.com>, Eli Zaretskii <eliz@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00067.txt.bz2

On Thu, Jun 28, 2012 at 2:37 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> 2012-06-24  Hui Zhu  <hui_zhu@mentor.com>
>>>      * ax-gdb.c (cli/cli-utils.h): New include.
>>>      (linespec.h): Ditto.
>>>      (agent_eval_command_one): New function.
>>>      (agent_command_1): Ditto.
>>>      (agent_command): Call function agent_command_1.
>>>      (agent_eval_command): Ditto.
>>>      (_initialize_ax_gdb): Change help for "maint agent"
>>>      and "maint agent-eval".
>
> This is also ok.  I think it may slightly abuse linespec parsing, but
> considering that it is a 'maint' command, I don't think it matters, as
> we are free to say "don't do that", or change it as needed.
>
>>> +      expr = parse_exp_1 (&exp, block_for_pc (pc), 0);
>
> You'll need a minor tweak to get it to compile, since I changed
> parse_exp_1 today.
>
> Tom

OK.  Thanks for your help.

Checked in.
http://sourceware.org/ml/gdb-cvs/2012-07/msg00037.html
http://sourceware.org/ml/gdb-cvs/2012-07/msg00038.html
http://sourceware.org/ml/gdb-cvs/2012-07/msg00039.html

Best,
Hui