From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99448-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12341 invoked by alias); 12 Mar 2013 15:47:54 -0000
Received: (qmail 12329 invoked by uid 22791); 12 Mar 2013 15:47:52 -0000
X-SWARE-Spam-Status: No, hits=-4.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-oa0-f51.google.com (HELO mail-oa0-f51.google.com) (209.85.219.51)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 15:47:36 +0000
Received: by mail-oa0-f51.google.com with SMTP id h2so5945490oag.10        for <gdb-patches@sourceware.org>; Tue, 12 Mar 2013 08:47:35 -0700 (PDT)
X-Received: by 10.60.1.34 with SMTP id 2mr12313977oej.47.1363103255821; Tue, 12 Mar 2013 08:47:35 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.60.60.7 with HTTP; Tue, 12 Mar 2013 08:46:54 -0700 (PDT)
In-Reply-To: <87ehfkiqoi.fsf@fleche.redhat.com>
References: <CANFwon0GXGwSqOyev+te3f0DBCqG3y0ovJ+yJ-kcaWkMAJOwXw@mail.gmail.com> <513DDE2C.9080109@codesourcery.com> <87r4jmngr5.fsf@fleche.redhat.com> <87k3penfy3.fsf@fleche.redhat.com> <CANFwon0UqJtN2O7poC8d0X+puqR-LCfw368qKJJs50YE_wexZA@mail.gmail.com> <87y5dsityl.fsf@fleche.redhat.com> <513F4028.5090000@mentor.com> <87txogir7j.fsf@fleche.redhat.com> <CANFwon2Q0NjeOSgq96SQ_h4ktup2=ye+y9EmYYKBoqrUYjQjVg@mail.gmail.com> <87ehfkiqoi.fsf@fleche.redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Tue, 12 Mar 2013 15:47:00 -0000
Message-ID: <CANFwon26Lk+_ZkCONZkyRRLZ5j0KrE-8PEMGgm7oyRG-CO7sVA@mail.gmail.com>
Subject: Re: [PATCH] Fix agent code generate bug of ref
To: Tom Tromey <tromey@redhat.com>
Cc: Hui Zhu <hui_zhu@mentor.com>, Yao Qi <yao@codesourcery.com>, 	gdb-patches ml <gdb-patches@sourceware.org>, Joel Brobecker <brobecker@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00524.txt.bz2

On Tue, Mar 12, 2013 at 11:27 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> On Tue, Mar 12, 2013 at 11:16 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
>>>
> Hui> According to the discussion with Tom in IRC.
> Hui> I add a check before call access_memory.
> Hui> +      if (size != 1 && size != 2 && size != 4 && size != 8)
> Hui> +        error (_("Refn doesn't support size %d"),
> Hui> +               size * TARGET_CHAR_BIT);
>
>>> The old error message mentioned the actual opcode name.
>>> I think "Refn" is less clear, since it isn't the name of anything
>>> in DWARF.
>
> Hui> What about change it to "DW_OP_deref and DW_OP_deref_size"?
>
> It seems simple to just resurrect the old error message.
>
> Tom

Oops.  I forgot that.
Check in http://sourceware.org/ml/gdb-cvs/2013-03/msg00103.html to use
old error.

Thanks,
Hui