From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7364 invoked by alias); 3 Jul 2013 12:03:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7308 invoked by uid 89); 3 Jul 2013 12:03:36 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_RG autolearn=ham version=3.3.1 Received: from mail-bk0-f42.google.com (HELO mail-bk0-f42.google.com) (209.85.214.42) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Jul 2013 12:03:35 +0000 Received: by mail-bk0-f42.google.com with SMTP id jk13so23101bkc.29 for ; Wed, 03 Jul 2013 05:03:33 -0700 (PDT) X-Received: by 10.205.9.8 with SMTP id ou8mr104052bkb.76.1372853013107; Wed, 03 Jul 2013 05:03:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.0.75 with HTTP; Wed, 3 Jul 2013 05:02:52 -0700 (PDT) In-Reply-To: <51D4030F.6070000@codesourcery.com> References: <51D2E749.9020604@codesourcery.com> <51D4030F.6070000@codesourcery.com> From: Hui Zhu Date: Wed, 03 Jul 2013 12:03:00 -0000 Message-ID: Subject: Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes To: Yao Qi Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=20cf301cc6042d08ac04e09a4048 X-Virus-Found: No X-SW-Source: 2013-07/txt/msg00138.txt.bz2 --20cf301cc6042d08ac04e09a4048 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 998 On Wed, Jul 3, 2013 at 6:55 PM, Yao Qi wrote: > On 07/03/2013 04:41 PM, Hui Zhu wrote: >> >> @@ -68,7 +68,7 @@ proc mi_continue_dprintf {args} { >> mi_run_cmd >> set msg "mi 1st dprintf" >> gdb_expect { >> - -re ".*At foo entry.*arg=3D1234, g=3D1234" { >> + -re ".*foobarbazqux.*At foo entry.*arg=3D1234, g=3D1234" { > > > It is good if we match double quotes before and after foobarbazqux, and g= et > rid of ".*" between "foobarbazqux" and "At foo entry", in order to get the > test more restrictive. Something like > > ".*\\\\\"foobarbazqux\\\\\" At foo entry.*arg=3D1234, g=3D1234" > > I have no other comments then. Update test patch for it. Thanks, Hui > > -- > Yao (=E9=BD=90=E5=B0=A7) 2013-07-03 Hui Zhu PR gdb/15692 mi/mi-cmd-break.c (mi_argv_to_format): Handle double quotes. 2013-07-03 Hui Zhu PR gdb/15692 gdb.mi/mi-dprintf.exp: Add double quotes test. --20cf301cc6042d08ac04e09a4048 Content-Type: text/plain; charset=US-ASCII; name="dprintf-mi-handle-quotes.txt" Content-Disposition: attachment; filename="dprintf-mi-handle-quotes.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hioh72gd0 Content-length: 452 LS0tIGEvZ2RiL21pL21pLWNtZC1icmVhay5jCisrKyBiL2dkYi9taS9taS1j bWQtYnJlYWsuYwpAQCAtMTI4LDYgKzEyOCw5IEBAIG1pX2FyZ3ZfdG9fZm9y bWF0IChjaGFyICoqYXJndiwgaW50IGFyZ2MKIAljYXNlICdcdic6CiAJICBv YnN0YWNrX2dyb3cgKCZvYnN0YWNrLCAiXFx2IiwgMik7CiAJICBicmVhazsK KwljYXNlICciJzoKKwkgIG9ic3RhY2tfZ3JvdyAoJm9ic3RhY2ssICJcXFwi IiwgMik7CisJICBicmVhazsKIAlkZWZhdWx0OgogCSAgaWYgKGlzcHJpbnQg KGFyZ3ZbMF1baV0pKQogCSAgICBvYnN0YWNrX2dyb3cgKCZvYnN0YWNrLCBh cmd2WzBdICsgaSwgMSk7Cg== --20cf301cc6042d08ac04e09a4048 Content-Type: text/plain; charset=US-ASCII; name="dprintf-mi-handle-quotes-test.txt" Content-Disposition: attachment; filename="dprintf-mi-handle-quotes-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hioh7afx1 Content-length: 1932 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktZHByaW50Zi5leHAKKysr IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIubWkvbWktZHByaW50Zi5leHAKQEAgLTQ4 LDcgKzQ4LDcgQEAgbWlfZ2RiX3Rlc3QgIjMtZHByaW50Zi1pbnNlcnQgMjki IFwKIG1pX2dkYl90ZXN0ICItYnJlYWstaW5zZXJ0IG1haW4iICIuKiIgIm1p IGluc2VydCBicmVha3BvaW50IG1haW4iCiBtaV9kZWxldGVfYnJlYWtwb2lu dHMKIAotbWlfZ2RiX3Rlc3QgIjQtZHByaW50Zi1pbnNlcnQgZm9vIFwiQXQg Zm9vIGVudHJ5XFxuXCIiIFwKK21pX2dkYl90ZXN0ICI0LWRwcmludGYtaW5z ZXJ0IGZvbyBcIlxcXCJmb29iYXJiYXpxdXhcXFwiIEF0IGZvbyBlbnRyeVxc blwiIiBcCiAgICAgIjRcXF5kb25lLGJrcHQ9XHtudW1iZXI9XCIuKlwiLHR5 cGU9XCJkcHJpbnRmXCIuKmZ1bmM9XCJmb29cIixmaWxlPVwiLiptaS1kcHJp bnRmLmNcIixmdWxsbmFtZT1cIi4qbWktZHByaW50Zi5jXCIsbGluZT1cIi4q XCIuKiIgIm1pIGluc2VydCBkcHJpbnRmIGZvbyIKIAogbWlfZ2RiX3Rlc3Qg IjUtZHByaW50Zi1pbnNlcnQgJGRwX2xvY2F0aW9uMSBcImFyZz0lZCwgZz0l ZFxcblwiIGFyZyBnIiBcCkBAIC02NSwxMCArNjUsMTYgQEAgcHJvYyBtaV9j b250aW51ZV9kcHJpbnRmIHthcmdzfSB7CiAgICAgd2l0aF90ZXN0X3ByZWZp eCAkYXJncyB7CiAJZ2xvYmFsIG1pX2dkYl9wcm9tcHQKIAorCWlmIHsgJGFy Z3MgPT0gImNhbGwiIHx8ICRhcmdzID09ICJmcHJpbnRmIiB9IHsKKwkgICAg c2V0IGZvb2JhcmJhenF1eCAiZm9vYmFyYmF6cXV4LioiCisJfSBlbHNlIHsK KwkgICAgc2V0IGZvb2JhcmJhenF1eCAiXFxcXFwiZm9vYmFyYmF6cXV4XFxc XFwiIgorCX0KKwogCW1pX3J1bl9jbWQKIAlzZXQgbXNnICJtaSAxc3QgZHBy aW50ZiIKIAlnZGJfZXhwZWN0IHsKLSAgICAgICAgICAgIC1yZSAiLipBdCBm b28gZW50cnkuKmFyZz0xMjM0LCBnPTEyMzQiIHsKKyAgICAgICAgICAgIC1y ZSAiLiokZm9vYmFyYmF6cXV4IEF0IGZvbyBlbnRyeS4qYXJnPTEyMzQsIGc9 MTIzNCIgewogCQlwYXNzICRtc2cKIAkgICAgfQogCSAgICAtcmUgIi4qJG1p X2dkYl9wcm9tcHQkIiB7CkBAIC04Myw3ICs4OSw3IEBAIHByb2MgbWlfY29u dGludWVfZHByaW50ZiB7YXJnc30gewogCXNldCBtc2cgIm1pIDJuZCBkcHJp bnRmIgogCW1pX3NlbmRfcmVzdW1pbmdfY29tbWFuZCAiZXhlYy1jb250aW51 ZSIgIiRtc2cgY29udGludWUiCiAJZ2RiX2V4cGVjdCB7Ci0gICAgICAgICAg ICAtcmUgIi4qQXQgZm9vIGVudHJ5Liphcmc9MTIzNSwgZz0yMjIyIiB7Cisg ICAgICAgICAgICAtcmUgIi4qJGZvb2JhcmJhenF1eCBBdCBmb28gZW50cnku KmFyZz0xMjM1LCBnPTIyMjIiIHsKIAkJcGFzcyAkbXNnCiAJICAgIH0KIAkg ICAgLXJlICIuKiRtaV9nZGJfcHJvbXB0JCIgewo= --20cf301cc6042d08ac04e09a4048--