From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14769 invoked by alias); 23 Apr 2013 07:14:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14759 invoked by uid 89); 23 Apr 2013 07:14:47 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-oa0-f42.google.com (HELO mail-oa0-f42.google.com) (209.85.219.42) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 23 Apr 2013 07:14:46 +0000 Received: by mail-oa0-f42.google.com with SMTP id i10so270662oag.15 for ; Tue, 23 Apr 2013 00:14:45 -0700 (PDT) X-Received: by 10.60.133.13 with SMTP id oy13mr2061235oeb.28.1366701284868; Tue, 23 Apr 2013 00:14:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Tue, 23 Apr 2013 00:14:04 -0700 (PDT) From: Hui Zhu Date: Tue, 23 Apr 2013 20:00:00 -0000 Message-ID: Subject: [PATCH] fix Bug 15180 Agent style dprintf does not respect conditions To: gdb-patches ml Content-Type: multipart/mixed; boundary=047d7b471dfe9947ef04db01f05d X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00703.txt.bz2 --047d7b471dfe9947ef04db01f05d Content-Type: text/plain; charset=ISO-8859-1 Content-length: 441 Hi, This is because in linux_wait_1, it didn't add any check just call run_breakpoint_commands (event_child->stop_pc); So I add a check call run_breakpoint_commands only when condition is true. Because I don't know howto handle the output in gdbserver. So I didn't add test for it. Thanks, Hui 2013-04-23 Hui Zhu PR gdb/15180 * linux-low.c (linux_wait_1): Add a check before call run_breakpoint_commands. --047d7b471dfe9947ef04db01f05d Content-Type: text/plain; charset=US-ASCII; name="dprintf-gdbserver-cond.txt" Content-Disposition: attachment; filename="dprintf-gdbserver-cond.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfuqmggx0 Content-length: 1859 LS0tIGEvZ2RiL2dkYnNlcnZlci9saW51eC1sb3cuYworKysgYi9nZGIvZ2Ri c2VydmVyL2xpbnV4LWxvdy5jCkBAIC0yMzEzLDYgKzIzMTMsNyBAQCBsaW51 eF93YWl0XzEgKHB0aWRfdCBwdGlkLAogICBpbnQgbWF5YmVfaW50ZXJuYWxf dHJhcDsKICAgaW50IHJlcG9ydF90b19nZGI7CiAgIGludCB0cmFjZV9ldmVu dDsKKyAgaW50IGNvbmRpdGlvbl90cnVlOwogCiAgIC8qIFRyYW5zbGF0ZSBn ZW5lcmljIHRhcmdldCBvcHRpb25zIGludG8gbGludXggb3B0aW9ucy4gICov CiAgIG9wdGlvbnMgPSBfX1dBTEw7CkBAIC0yNjE1LDYgKzI2MTYsOSBAQCBD aGVjayBpZiB3ZSdyZSBhbHJlYWR5IHRoZXJlLlxuIiwKICAgICAgIGdvdG8g cmV0cnk7CiAgICAgfQogCisgIGNvbmRpdGlvbl90cnVlID0gZ2RiX2JyZWFr cG9pbnRfaGVyZSAoZXZlbnRfY2hpbGQtPnN0b3BfcGMpCisJCSAgICYmIGdk Yl9jb25kaXRpb25fdHJ1ZV9hdF9icmVha3BvaW50IChldmVudF9jaGlsZC0+ c3RvcF9wYyk7CisKICAgLyogSWYgR0RCIHdhbnRlZCB0aGlzIHRocmVhZCB0 byBzaW5nbGUgc3RlcCwgd2UgYWx3YXlzIHdhbnQgdG8KICAgICAgcmVwb3J0 IHRoZSBTSUdUUkFQLCBhbmQgbGV0IEdEQiBoYW5kbGUgaXQuICBXYXRjaHBv aW50cyBzaG91bGQKICAgICAgYWx3YXlzIGJlIHJlcG9ydGVkLiAgU28gc2hv dWxkIHNpZ25hbHMgd2UgY2FuJ3QgZXhwbGFpbi4gIEEKQEAgLTI2MjgsMTEg KzI2MzIsMTEgQEAgQ2hlY2sgaWYgd2UncmUgYWxyZWFkeSB0aGVyZS5cbiIs CiAJCSAgIHx8IGV2ZW50X2NoaWxkLT5zdG9wcGVkX2J5X3dhdGNocG9pbnQK IAkJICAgfHwgKCFzdGVwX292ZXJfZmluaXNoZWQKIAkJICAgICAgICYmICFi cF9leHBsYWluc190cmFwICYmICF0cmFjZV9ldmVudCkKLQkJICAgfHwgKGdk Yl9icmVha3BvaW50X2hlcmUgKGV2ZW50X2NoaWxkLT5zdG9wX3BjKQotCQkg ICAgICAgJiYgZ2RiX2NvbmRpdGlvbl90cnVlX2F0X2JyZWFrcG9pbnQgKGV2 ZW50X2NoaWxkLT5zdG9wX3BjKQorCQkgICB8fCAoY29uZGl0aW9uX3RydWUK IAkJICAgICAgICYmIGdkYl9ub19jb21tYW5kc19hdF9icmVha3BvaW50IChl dmVudF9jaGlsZC0+c3RvcF9wYykpKTsKIAotICBydW5fYnJlYWtwb2ludF9j b21tYW5kcyAoZXZlbnRfY2hpbGQtPnN0b3BfcGMpOworICBpZiAoY29uZGl0 aW9uX3RydWUpCisgICAgcnVuX2JyZWFrcG9pbnRfY29tbWFuZHMgKGV2ZW50 X2NoaWxkLT5zdG9wX3BjKTsKIAogICAvKiBXZSBmb3VuZCBubyByZWFzb24g R0RCIHdvdWxkIHdhbnQgdXMgdG8gc3RvcC4gIFdlIGVpdGhlciBoaXQgb25l CiAgICAgIG9mIG91ciBvd24gYnJlYWtwb2ludHMsIG9yIGZpbmlzaGVkIGFu IGludGVybmFsIHN0ZXAgR0RCCg== --047d7b471dfe9947ef04db01f05d--