From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25194 invoked by alias); 30 Apr 2013 00:58:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25184 invoked by uid 89); 30 Apr 2013 00:58:25 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ob0-f171.google.com (HELO mail-ob0-f171.google.com) (209.85.214.171) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Apr 2013 00:58:24 +0000 Received: by mail-ob0-f171.google.com with SMTP id er7so6042069obc.30 for ; Mon, 29 Apr 2013 17:58:22 -0700 (PDT) X-Received: by 10.182.118.42 with SMTP id kj10mr24458889obb.99.1367283502395; Mon, 29 Apr 2013 17:58:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Mon, 29 Apr 2013 17:57:42 -0700 (PDT) In-Reply-To: <87fvyd827o.fsf@fleche.redhat.com> References: <87zjwuv0qn.fsf@fleche.redhat.com> <87li87ll0r.fsf@fleche.redhat.com> <87fvyd827o.fsf@fleche.redhat.com> From: Hui Zhu Date: Tue, 30 Apr 2013 11:12:00 -0000 Message-ID: Subject: Re: [PATCH] not trigger pagination with dprintf To: Tom Tromey Cc: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-04/txt/msg00889.txt.bz2 On Sat, Apr 27, 2013 at 4:30 AM, Tom Tromey wrote: > Hui> Because as the Marc said in bugzilla, when pagination is triggered, > Hui> inferior execution will be interrupted until the user answers the > Hui> pagination prompt. And dptintf breakpoint call printf in its > Hui> commands. So I want to make dprintf can handle it. > > If pagination from a breakpoint's commands really breaks gdb, then it > should be disabled universally while in "commands", not just for > dprintf. > > If it doesn't break gdb, well, then it seems like it is what the user > asked for. Hi Tom, I post a new patch that temporarily set pagination_enabled to 0 in the begin of commands execution function bpstat_do_actions to close pagination. Then all the commands of breakpoint will not trigger pagination. If you think this patch is OK, I will update patch for bug 15075 http://sourceware.org/ml/gdb-patches/2013-04/msg00711.html temporarily set pagination_enabled to 0 too. Thanks, Hui 2013-04-30 Hui Zhu PR gdb/15182 * breakpoint.c (bpstat_do_actions): Temporarily set pagination_enabled to 0. --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -4374,7 +4374,11 @@ void bpstat_do_actions (void) { struct cleanup *cleanup_if_error = make_bpstat_clear_actions_cleanup (); + struct cleanup *back_to; + extern int pagination_enabled; + back_to = make_cleanup_restore_integer (&pagination_enabled); + pagination_enabled = 0; /* Do any commands attached to breakpoint we are stopped at. */ while (!ptid_equal (inferior_ptid, null_ptid) && target_has_execution @@ -4387,6 +4391,7 @@ bpstat_do_actions (void) if (!bpstat_do_actions_1 (&inferior_thread ()->control.stop_bpstat)) break; + do_cleanups (back_to); discard_cleanups (cleanup_if_error); }