From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8953 invoked by alias); 21 Apr 2013 09:35:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8943 invoked by uid 89); 21 Apr 2013 09:35:30 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-oa0-f46.google.com (HELO mail-oa0-f46.google.com) (209.85.219.46) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 21 Apr 2013 09:35:20 +0000 Received: by mail-oa0-f46.google.com with SMTP id k3so2400527oag.19 for ; Sun, 21 Apr 2013 02:35:19 -0700 (PDT) X-Received: by 10.182.128.105 with SMTP id nn9mr7220767obb.10.1366536918987; Sun, 21 Apr 2013 02:35:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Sun, 21 Apr 2013 02:34:38 -0700 (PDT) In-Reply-To: <87zjwuv0qn.fsf@fleche.redhat.com> References: <87zjwuv0qn.fsf@fleche.redhat.com> From: Hui Zhu Date: Mon, 22 Apr 2013 09:21:00 -0000 Message-ID: Subject: Re: [PATCH] not trigger pagination with dprintf To: Tom Tromey Cc: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-04/txt/msg00646.txt.bz2 On Sat, Apr 20, 2013 at 2:22 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> This is the patch for http://sourceware.org/bugzilla/show_bug.cgi?id=15182 > Hui> I agree with what Marc said in the bug report. > > Quoting for clarity: > > a) when pagination is triggered, inferior execution will be > interrupted until the user answers the pagination prompt > > b) pagination is triggered by the dprintf but not by real inferior > output. So, as dprintf and inferior printouts appear interleaved > on the screen, the pagination prompt will be triggered when the > dprintfs add up to too many, which will seem random to the user, > since the other printouts are also visible. > > > I agree these arguments are pretty good, but I don't see why they apply > particularly to dprintf as opposed to all gdb output. But then the > result is to just disable all pagination -- something already easily > done. > > So I tend to think this should not go in. Will you OK if I update patch to make printf_command call ui_printf with filter is 0 just with dprintf? Thanks, Hui > > FWIW I have never understood why gdb provides _unfiltered variants of > the print functions. It seems to me that a stream should either be > paginated or not -- having it work at the level of the individual print > means that some prints will provoke paging behavior and some will not; > and, worse, since they are in fact interleaved, the "paging" output may > not all be visible anyhow. > > Tom