From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12507 invoked by alias); 30 Jun 2013 15:17:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12477 invoked by uid 89); 30 Jun 2013 15:17:49 -0000 X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ob0-f171.google.com (HELO mail-ob0-f171.google.com) (209.85.214.171) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 30 Jun 2013 15:17:47 +0000 Received: by mail-ob0-f171.google.com with SMTP id dn14so3465239obc.16 for ; Sun, 30 Jun 2013 08:17:45 -0700 (PDT) X-Received: by 10.60.42.174 with SMTP id p14mr8190751oel.73.1372605465594; Sun, 30 Jun 2013 08:17:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.137.196 with HTTP; Sun, 30 Jun 2013 08:17:05 -0700 (PDT) In-Reply-To: <51CB2BAA.1070507@redhat.com> References: <51CB2BAA.1070507@redhat.com> From: Hui Zhu Date: Sun, 30 Jun 2013 17:15:00 -0000 Message-ID: Subject: Re: [PATCH] fix PR 15180 "May only run agent-printf on the target" To: Pedro Alves Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=001a11c2519a31909304e0609d86 X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00940.txt.bz2 --001a11c2519a31909304e0609d86 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 2773 Hi Pedro, Thanks for your review. On Thu, Jun 27, 2013 at 1:58 AM, Pedro Alves wrote: > On 06/17/2013 08:47 AM, Hui Zhu wrote: >> Hi, >> >> This patch is for PR 15180 too. Because it depends on patch in >> http://sourceware.org/ml/gdb-patches/2013-06/msg00139.html >> So I post it in another thread. >> >> It make dprintf_after_condition_true doesn't do actions if dprintf >> style is agent. Because the actions is already did in agent. > > If dprintf style is agent, then the target doesn't report events > for such hits. If we happen to see a trap reported for the > same address as another breakpoint, the trap is surely not explained > by the dprintf. IOW, we shouldn't have a bpstat a dprintf w/ style > agent at all. What is need is to override the breakpoint_hit method > of dprintf_breakpoint_ops to always return false for agent style dprintfs. > > Or maybe I'm missing something. I have a hard time going from > the bug description in the PR to the patch. OK. I add dprintf_check_status in the new patch according to your comments. > >> >> The test patch test the issue about 15180. > > Hmm, I get: > > Running target native-gdbserver > Using ../../../src/gdb/testsuite/boards/../boards/native-gdbserver.exp as board description file for target. > Using ../../../src/gdb/testsuite/config/gdbserver.exp as tool-and-target-specific interface file. > Running ../../../src/gdb/testsuite/gdb.base/dprintf-same-addr.exp ... > FAIL: gdb.base/dprintf-same-addr.exp: agent: First continue (the program exited) > FAIL: gdb.base/dprintf-same-addr.exp: agent: Second continue (the program is no longer running) > FAIL: gdb.base/dprintf-same-addr.exp: agent: check i > > === gdb Summary === > > # of expected passes 16 > # of unexpected failures 3 > # of unsupported tests 1 > I am sorry that didn't talk this test very clear. It depend on the patches in http://sourceware.org/ml/gdb-patches/2013-06/msg00367.html Could you patch those patches and try again? Thanks, Hui 2013-06-30 Hui Zhu PR gdb/15180 * breakpoint.c (dprintf_check_status): New function. (initialize_breakpoint_ops): Set dprintf_check_status. 2013-06-30 Hui Zhu PR gdb/15180 * gdb.base/dprintf-same-addr.c: New file. * gdb.base/dprintf-same-addr.exp: New file. > > >> >> Thanks, >> Hui >> >> 2013-06-17 Hui Zhu >> >> PR gdb/15180 >> * breakpoint.c (dprintf_after_condition_true): Check dprintf style >> before do actions. >> >> 2013-06-17 Hui Zhu >> >> PR gdb/15180 >> * gdb.base/dprintf-same-addr.c: New file. >> * gdb.base/dprintf-same-addr.exp: New file. >> > > > -- > Pedro Alves --001a11c2519a31909304e0609d86 Content-Type: text/plain; charset=US-ASCII; name="dprintf-same-addr.txt" Content-Disposition: attachment; filename="dprintf-same-addr.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hikdtaya0 Content-length: 1143 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC0xMzQxOCw2ICsxMzQxOCwxOCBAQCBkcHJpbnRmX3JlX3NldCAoc3Ry dWN0IGJyZWFrcG9pbnQgKmIpCiAgICAgdXBkYXRlX2RwcmludGZfY29tbWFu ZF9saXN0IChiKTsKIH0KIAorLyogSW1wbGVtZW50IHRoZSAiY2hlY2tfc3Rh dHVzIiBicmVha3BvaW50X29wcyBtZXRob2QgZm9yIGRwcmludGYuICAqLwor CitzdGF0aWMgdm9pZAorZHByaW50Zl9jaGVja19zdGF0dXMgKHN0cnVjdCBi cHN0YXRzICpicykKK3sKKyAgaWYgKHN0cmNtcCAoZHByaW50Zl9zdHlsZSwg ZHByaW50Zl9zdHlsZV9hZ2VudCkgPT0gMCkKKyAgICB7CisgICAgICBicy0+ c3RvcCA9IDA7CisgICAgICBicy0+cHJpbnRfaXQgPSBwcmludF9pdF9ub29w OworICAgIH0KK30KKwogLyogSW1wbGVtZW50IHRoZSAicHJpbnRfcmVjcmVh dGUiIGJyZWFrcG9pbnRfb3BzIG1ldGhvZCBmb3IgZHByaW50Zi4gICovCiAK IHN0YXRpYyB2b2lkCkBAIC0xNTk1OCw2ICsxNTk3MCw3IEBAIGluaXRpYWxp emVfYnJlYWtwb2ludF9vcHMgKHZvaWQpCiAgIG9wcyA9ICZkcHJpbnRmX2Jy ZWFrcG9pbnRfb3BzOwogICAqb3BzID0gYmtwdF9iYXNlX2JyZWFrcG9pbnRf b3BzOwogICBvcHMtPnJlX3NldCA9IGRwcmludGZfcmVfc2V0OworICBvcHMt PmNoZWNrX3N0YXR1cyA9IGRwcmludGZfY2hlY2tfc3RhdHVzOwogICBvcHMt PnJlc291cmNlc19uZWVkZWQgPSBia3B0X3Jlc291cmNlc19uZWVkZWQ7CiAg IG9wcy0+cHJpbnRfaXQgPSBia3B0X3ByaW50X2l0OwogICBvcHMtPnByaW50 X21lbnRpb24gPSBia3B0X3ByaW50X21lbnRpb247Cg== --001a11c2519a31909304e0609d86 Content-Type: text/plain; charset=US-ASCII; name="dprintf-same-addr-test.txt" Content-Disposition: attachment; filename="dprintf-same-addr-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hikdthjc1 Content-length: 5072 LS0tIC9kZXYvbnVsbAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2Rw cmludGYtc2FtZS1hZGRyLmMKQEAgLTAsMCArMSwzNSBAQAorLyogVGhpcyB0 ZXN0Y2FzZSBpcyBwYXJ0IG9mIEdEQiwgdGhlIEdOVSBkZWJ1Z2dlci4KKwor ICAgQ29weXJpZ2h0IChDKSAyMDEzIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLgorICAgQ29udHJpYnV0ZWQgYnkgSHVpIFpodSAgPGh1aUBjb2Rl c291cmNlcnkuY29tPgorCisgICBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQor ICAgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyAgIHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vu c2UsIG9yCisgICAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9u LgorCisgICBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhv cGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAgIGJ1dCBXSVRIT1VUIEFO WSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5 IG9mCisgICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisgICBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCisgICBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZQorICAgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBu b3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwor CisjaW5jbHVkZSA8c3RkaW8uaD4KKworaW50CittYWluICgpCit7CisgIGlu dCBpOworCisgIGZvciAoaT0wOyBpIDwgOTk7IGkrKykKKyAgICB7CisgICAg ICBwcmludGYoIkhlbGxvXG4iKTsJLyogdGVzdCBsaW5lICAqLworCisgICAg ICAvKiBXaXRob3V0IHRoaXMgbGluZSwgdGVzdCB3aXRoIGZwcmludGYgd2ls bCBub3Qgd29yay4gICovCisgICAgICBmcHJpbnRmIChzdGRlcnIsICJ3b3Js ZFxuIik7CisgICAgfQorCisgIHJldHVybiAwOworfQotLS0gL2Rldi9udWxs CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZHByaW50Zi1zYW1lLWFk ZHIuZXhwCkBAIC0wLDAgKzEsODIgQEAKKyMgICBDb3B5cmlnaHQgKEMpIDIw MTMgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjICAgQ29udHJp YnV0ZWQgYnkgSHVpIFpodSAgPGh1aUBjb2Rlc291cmNlcnkuY29tPgorCisj IFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlz dHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlz aGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhl ciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkg b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhl CisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFp bHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGgg dGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9y Zy9saWNlbnNlcy8+LgorCitzdGFuZGFyZF90ZXN0ZmlsZQorCitpZiBbcHJl cGFyZV9mb3JfdGVzdGluZyAiZmFpbGVkIHRvIHByZXBhcmUgZm9yIGRwcmlu dGYgd2l0aCBub24tc3RvcCIgXAorICAgICR7dGVzdGZpbGV9ICR7c3JjZmls ZX0ge2RlYnVnfV0geworICAgIHJldHVybiAtMQorfQorCitzZXQgYnBfbG9j YXRpb24gW2dkYl9nZXRfbGluZV9udW1iZXIgInRlc3QgbGluZSJdCisKK3By b2MgY29udGludWVfZHByaW50ZiB7YXJnc30geworICAgIHdpdGhfdGVzdF9w cmVmaXggJGFyZ3MgeworCWdsb2JhbCBicF9sb2NhdGlvbgorCisJZ2RiX3Rl c3QgImRwcmludGYgJGJwX2xvY2F0aW9uLFwiSGVsbG9cXG5cIiIgIkRwcmlu dGYgLioiCisJZ2RiX3Rlc3Rfbm9fb3V0cHV0IHtzZXQgJGJwbnVtMT0kYnBu dW19CisJZ2RiX2JyZWFrcG9pbnQgJGJwX2xvY2F0aW9uCisJZ2RiX3Rlc3Rf bm9fb3V0cHV0IHtzZXQgJGJwbnVtMj0kYnBudW19CisKKwlnZGJfdGVzdCAi Y29udGludWUiICJCcmVha3BvaW50IFxbMC05XF0rLCBtYWluIC4qIiAiRmly c3QgY29udGludWUiCisKKwlnZGJfdGVzdF9ub19vdXRwdXQgImNvbmRpdGlv biBcJGJwbnVtMSBpPjEwIgorCWdkYl90ZXN0X25vX291dHB1dCAiY29uZGl0 aW9uIFwkYnBudW0yIGk+MTUiCisKKwlnZGJfdGVzdCAiY29udGludWUiICJC cmVha3BvaW50IFxbMC05XF0rLCBtYWluIC4qIiAiU2Vjb25kIGNvbnRpbnVl IgorCisJZ2RiX3Rlc3QgInAgaSIgIlxbMC05XF0rID0gMTYiICJjaGVjayBp IgorICAgIH0KK30KKworaWYgIVtydW50byBtYWluXSB7CisgICAgcmV0dXJu IC0xCit9CitnZGJfdGVzdF9ub19vdXRwdXQgInNldCBkcHJpbnRmLXN0eWxl IGdkYiIgIlNldCBkcHJpbnRmIHN0eWxlIHRvIGdkYiIKK2NvbnRpbnVlX2Rw cmludGYgImdkYiIKKworaWYgIVt0YXJnZXRfaW5mbyBleGlzdHMgZ2RiLG5v aW5mZXJpb3Jpb10geworICAgIGlmICFbcnVudG8gbWFpbl0geworCXJldHVy biAtMQorICAgIH0KKyAgICBnZGJfdGVzdF9ub19vdXRwdXQgInNldCBkcHJp bnRmLXN0eWxlIGNhbGwiICJTZXQgZHByaW50ZiBzdHlsZSB0byBjYWxsIgor ICAgIGNvbnRpbnVlX2RwcmludGYgImNhbGwiCisKKyAgICBpZiAhW3J1bnRv IG1haW5dIHsKKwlyZXR1cm4gLTEKKyAgICB9CisgICAgZ2RiX3Rlc3Rfbm9f b3V0cHV0ICJzZXQgZHByaW50Zi1mdW5jdGlvbiBmcHJpbnRmIiAic2V0IGRw cmludGYtY2hhbm5lbCBzdGRlcnIiCisgICAgZ2RiX3Rlc3Rfbm9fb3V0cHV0 ICJzZXQgZHByaW50Zi1jaGFubmVsIHN0ZGVyciIgInNldCBkcHJpbnRmIGNo YW5uZWwiCisgICAgY29udGludWVfZHByaW50ZiAiZnByaW50ZiIKK30gZWxz ZSB7CisgICAgdW5zdXBwb3J0ZWQgInRlc3QgZHByaW50Zi1zdHlsZSBjYWxs IgorfQorCitpZiAhW3J1bnRvIG1haW5dIHsKKyAgICByZXR1cm4gLTEKK30K K2dkYl90ZXN0ICJkcHJpbnRmIG1haW4sXCJIZWxsb1xcblwiIiAiRHByaW50 ZiAuKiIKK3NldCBtc2cgIlNldCBkcHJpbnRmIHN0eWxlIHRvIGFnZW50Igor Z2RiX3Rlc3RfbXVsdGlwbGUgInNldCBkcHJpbnRmLXN0eWxlIGFnZW50IiAk bXNnIHsKKyAgICAtcmUgIndhcm5pbmc6IFRhcmdldCBjYW5ub3QgcnVuIGRw cmludGYgY29tbWFuZHMuKlxyXG4kZ2RiX3Byb21wdCAkIiB7CisJdW5zdXBw b3J0ZWQgJG1zZworICAgIH0KKyAgICAtcmUgIi4qJGdkYl9wcm9tcHQgJCIg eworCXBhc3MgJG1zZworCWNvbnRpbnVlX2RwcmludGYgImFnZW50IgorICAg IH0KK30K --001a11c2519a31909304e0609d86--