Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes
Date: Tue, 02 Jul 2013 13:31:00 -0000	[thread overview]
Message-ID: <CANFwon1gnBtdU2jbrZ9bCVuF3dMPAY2syeB1oMBXE1x4PSDLNA@mail.gmail.com> (raw)

Hi,

I found this issue because mi_argv_to_format doesn't handle double
quotes.  So I make a patch to add it.

Thanks,
Hui

2013-07-02  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15692
	mi/mi-cmd-break.c (mi_argv_to_format): Handle double quotes.

--- a/gdb/mi/mi-cmd-break.c
+++ b/gdb/mi/mi-cmd-break.c
@@ -128,6 +128,9 @@ mi_argv_to_format (char **argv, int argc
 	case '\v':
 	  obstack_grow (&obstack, "\\v", 2);
 	  break;
+	case '"':
+	  obstack_grow (&obstack, "\\\"", 2);
+	  break;
 	default:
 	  if (isprint (argv[0][i]))
 	    obstack_grow (&obstack, argv[0] + i, 1);


             reply	other threads:[~2013-07-02 13:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 13:31 Hui Zhu [this message]
2013-07-02 14:44 ` Yao Qi
2013-07-03  8:42   ` Hui Zhu
2013-07-03 10:55     ` Yao Qi
2013-07-03 12:03       ` Hui Zhu
2013-07-03 13:09         ` Yao Qi
2013-07-07  5:54           ` Hui Zhu
2013-07-10 17:03             ` Tom Tromey
2013-07-18 12:58               ` Hui Zhu
2013-07-18 13:42                 ` Tom Tromey
2013-07-19  7:29                   ` Hui Zhu
2013-07-23 19:04                     ` Tom Tromey
2013-07-24  1:56                       ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANFwon1gnBtdU2jbrZ9bCVuF3dMPAY2syeB1oMBXE1x4PSDLNA@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox