From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10390 invoked by alias); 14 May 2013 11:15:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10380 invoked by uid 89); 14 May 2013 11:15:41 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-oa0-f54.google.com (HELO mail-oa0-f54.google.com) (209.85.219.54) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 11:15:40 +0000 Received: by mail-oa0-f54.google.com with SMTP id o17so423824oag.27 for ; Tue, 14 May 2013 04:15:39 -0700 (PDT) X-Received: by 10.60.149.231 with SMTP id ud7mr5127242oeb.119.1368530139350; Tue, 14 May 2013 04:15:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Tue, 14 May 2013 04:14:58 -0700 (PDT) In-Reply-To: <87bo8edehd.fsf@fleche.redhat.com> References: <87bo8edehd.fsf@fleche.redhat.com> From: Hui Zhu Date: Tue, 14 May 2013 11:15:00 -0000 Message-ID: Subject: Re: [PATCH] Fix bug 15433 - GDB crashes when using agent dprintf, %s format, and an in-line string To: Tom Tromey Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=047d7b419051d20c5d04dcabc0f5 X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00461.txt.bz2 --047d7b419051d20c5d04dcabc0f5 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1554 Hi Tom, Thanks for your review. On Tue, May 14, 2013 at 12:35 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> + if (aexpr == NULL) > Hui> + error (_("Agent is not support commands of breakpoint %d."), > Hui> + bl->owner->number); > > In addition to what Yao said, this change seems roughly equivalent to > simply removing the TRY_CATCH from parse_cmd_to_aexpr. (You'd have to > clear loc->cmd_bytecode first, but it seems to me that this has to be > done anyway, because parse_cmd_to_aexpr can already call error...) Agree with you. Updated patches for it. > > I also still don't understand the code to set null_command_or_parse_error. > Maybe you explained it to me last time, but I forget. If it is actually > correct as-is, I would appreciate a comment explaining it. I posted some introduction about it in http://sourceware.org/ml/gdb-patches/2013-05/msg00425.html . I hope it will be helpful to you to understand this function. And I suggest we can discussion this function in thread http://sourceware.org/ml/gdb-patches/2013-04/msg00839.html ([PATCH/v2] fix Bug 15180 Agent style dprintf does not respect conditions, I will ping it later) that I did a lot of change about this function. Thanks, Hui 2013-05-14 Hui Zhu PR gdb/15433 * breakpoint.c (parse_cmd_to_aexpr): Remove TRY_CATCH for gen_printf. 2013-05-14 Hui Zhu PR gdb/15433 * gdb.base/dprintf.exp: Test unsupport commands on target. --047d7b419051d20c5d04dcabc0f5 Content-Type: text/plain; charset=US-ASCII; name="dprintf-cmd-not-support.txt" Content-Disposition: attachment; filename="dprintf-cmd-not-support.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hgozgr7t0 Content-length: 1123 LS0tIGEvZ2RiL2JyZWFrcG9pbnQuYworKysgYi9nZGIvYnJlYWtwb2ludC5j CkBAIC0yMjM5LDIyICsyMjM5LDkgQEAgcGFyc2VfY21kX3RvX2FleHByIChD T1JFX0FERFIgc2NvcGUsIGNoYQogCSsrY21kcmVzdDsKICAgICB9CiAKLSAg LyogV2UgZG9uJ3Qgd2FudCB0byBzdG9wIHByb2Nlc3NpbmcsIHNvIGNhdGNo IGFueSBlcnJvcnMKLSAgICAgdGhhdCBtYXkgc2hvdyB1cC4gICovCi0gIFRS WV9DQVRDSCAoZXgsIFJFVFVSTl9NQVNLX0VSUk9SKQotICAgIHsKLSAgICAg IGFleHByID0gZ2VuX3ByaW50ZiAoc2NvcGUsIGdkYmFyY2gsIDAsIDAsCi0J CQkgIGZvcm1hdF9zdGFydCwgZm9ybWF0X2VuZCAtIGZvcm1hdF9zdGFydCwK LQkJCSAgZnBpZWNlcywgbmFyZ3MsIGFyZ3ZlYyk7Ci0gICAgfQotCi0gIGlm IChleC5yZWFzb24gPCAwKQotICAgIHsKLSAgICAgIC8qIElmIHdlIGdvdCBo ZXJlLCBpdCBtZWFucyB0aGUgY29tbWFuZCBjb3VsZCBub3QgYmUgcGFyc2Vk IHRvIGEgdmFsaWQKLQkgYnl0ZWNvZGUgZXhwcmVzc2lvbiBhbmQgdGh1cyBj YW4ndCBiZSBldmFsdWF0ZWQgb24gdGhlIHRhcmdldCdzIHNpZGUuCi0JIEl0 J3Mgbm8gdXNlIGl0ZXJhdGluZyB0aHJvdWdoIHRoZSBvdGhlciBjb21tYW5k cy4gICovCi0gICAgICByZXR1cm4gTlVMTDsKLSAgICB9CisgIGFleHByID0g Z2VuX3ByaW50ZiAoc2NvcGUsIGdkYmFyY2gsIDAsIDAsCisJCSAgICAgIGZv cm1hdF9zdGFydCwgZm9ybWF0X2VuZCAtIGZvcm1hdF9zdGFydCwKKwkJICAg ICAgZnBpZWNlcywgbmFyZ3MsIGFyZ3ZlYyk7CiAKICAgZG9fY2xlYW51cHMg KG9sZF9jbGVhbnVwcyk7CiAK --047d7b419051d20c5d04dcabc0f5 Content-Type: text/plain; charset=US-ASCII; name="dprintf-cmd-not-support-test.txt" Content-Disposition: attachment; filename="dprintf-cmd-not-support-test.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hgozgr801 Content-length: 720 LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9kcHJpbnRmLmV4cAorKysg Yi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2RwcmludGYuZXhwCkBAIC0xMzEs NiArMTMxLDExIEBAIGlmICR0YXJnZXRfY2FuX2RwcmludGYgewogCSJcW1xy XG5cXVx0YnJlYWtwb2ludCBhbHJlYWR5IGhpdCAyIHRpbWVzIgogCSJcW1xy XG5cXSAgICAgICAgYWdlbnQtcHJpbnRmIFwiYXJnPSVkLCBnPSVkXFxcXG5c IiwgYXJnLCBnIgogICAgIH0KKworICAgICMgVGVzdCB1bnN1cHBvcnQgY29t bWFuZHMuCisgICAgZ2RiX3Rlc3QgImRwcmludGYgJGRwX2xvY2F0aW9uMSxc IiVzXFxuXCIsIFwidGVzdFwiIiAiRHByaW50ZiAuKiIKKyAgICBnZGJfdGVz dCAiY29udGludWUiICIuKlVuc3VwcG9ydGVkIG9wZXJhdG9yIE9QX1NUUklO RyAuKiBpbiBleHByZXNzaW9uLioiIFwKKyAgICAgICIzcmQgZHByaW50Ziwg YWdlbnQiCiB9CiAKIGdkYl90ZXN0ICJzZXQgZHByaW50Zi1zdHlsZSBmb29i YXIiICJVbmRlZmluZWQgaXRlbTogXCJmb29iYXJcIi4iIFwK --047d7b419051d20c5d04dcabc0f5--