From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21426 invoked by alias); 16 Jun 2012 15:33:06 -0000 Received: (qmail 21417 invoked by uid 22791); 16 Jun 2012 15:33:05 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-we0-f169.google.com (HELO mail-we0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Jun 2012 15:32:48 +0000 Received: by wefh52 with SMTP id h52so3522344wef.0 for ; Sat, 16 Jun 2012 08:32:47 -0700 (PDT) Received: by 10.180.24.68 with SMTP id s4mr11998807wif.4.1339860766945; Sat, 16 Jun 2012 08:32:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.122.193 with HTTP; Sat, 16 Jun 2012 08:32:06 -0700 (PDT) In-Reply-To: <4FDB4F5F.7000206@redhat.com> References: <4FDB4F5F.7000206@redhat.com> From: Hui Zhu Date: Sat, 16 Jun 2012 15:33:00 -0000 Message-ID: Subject: Re: [PATCH] Fix buf inside tracepoint tfile memory read To: Pedro Alves Cc: gdb-patches ml , Joel Brobecker Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00547.txt.bz2 On Fri, Jun 15, 2012 at 11:06 PM, Pedro Alves wrote: > On 06/15/2012 11:28 AM, Hui Zhu wrote: > >> 2012-06-15 =A0Hui Zhu =A0 >> >> =A0 =A0 =A0 * tracepoint.c (tfile_xfer_partial): Add a lseek. > > > Okay, thanks. > > I wonder if a testcase could be constructed? > > -- > Pedro Alves Thanks. Checked in. http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=3Ds= rc&r1=3D1.14375&r2=3D1.14376 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/tracepoint.c.diff?cvsroot= =3Dsrc&r1=3D1.257&r2=3D1.258 I will post the test for it later. Best, Hui