From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8122 invoked by alias); 15 Aug 2012 14:23:56 -0000 Received: (qmail 8100 invoked by uid 22791); 15 Aug 2012 14:23:54 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Aug 2012 14:23:40 +0000 Received: by yhr47 with SMTP id 47so2044868yhr.0 for ; Wed, 15 Aug 2012 07:23:39 -0700 (PDT) Received: by 10.68.223.164 with SMTP id qv4mr40965536pbc.20.1345040618727; Wed, 15 Aug 2012 07:23:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.239.132 with HTTP; Wed, 15 Aug 2012 07:22:58 -0700 (PDT) In-Reply-To: References: <5020BF3A.8030809@mentor.com> <1866631.Ri6KkAT9H2@qiyao.dyndns.org> <50286552.1090003@codesourcery.com> From: Hui Zhu Date: Wed, 15 Aug 2012 14:23:00 -0000 Message-ID: Subject: Re: [RFC] Autoload-breakpoints new version [3/9] notification async To: Yao Qi Cc: gdb-patches@sourceware.org, Hui Zhu Content-Type: multipart/mixed; boundary=047d7b16371349aabe04c74eaceb X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00435.txt.bz2 --047d7b16371349aabe04c74eaceb Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1607 On Tue, Aug 14, 2012 at 8:01 PM, Hui Zhu wrote: > On Mon, Aug 13, 2012 at 10:24 AM, Yao Qi wrote: >> On 08/11/2012 11:19 PM, Hui Zhu wrote: >>>> >>>> > >>>> >I applied patch 1/9 and 3/9, and get following regressions in gdbserver >>>> > with >>>> >async mode on. >>>> > >>>> > FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (unknown >>>> > output >>>> >after running) >>>> > FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (2) (unknown >>>> > output >>>> >after running) >>>> > FAIL: gdb.mi/mi-nsmoribund.exp: resume all, waiting for program exit >>>> >(timeout) >>> >>> My part is OK, Could you tell me how do you do the test? >>> >> >> In gdb build dir, add the following line into testsuite/site.exp >> >> set GDBFLAGS "-ex \"set target-async on\"" >> >> make check RUNTESTFLAGS="--target_board=native-gdbserver" >> >> or you can set GDBFLAGS in your own board file other than testuite/site.exp. >> >> -- >> Yao > > Hi guys, > > I found this issue is because notification "Stop:" cannot be handled > in async handler. > What I thought is push it back a buffer and let GDB handle it later > that GDB in right status to handle it. > > I didn't have other good idea on this issue is because I cannot > reproduce it in command line. > > Do you have some comments on this issue? > > Thanks, > Hui Hi, I done a new version to handle this issue. Because readchar will throw error and pop_target directly in remote.c. So I change it use another way to handle it. Not sure it is good or not. But it make test can be passed. Thanks, Hui --047d7b16371349aabe04c74eaceb Content-Type: text/plain; name="notification_async.txt" Content-Disposition: attachment; filename="notification_async.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h5wifb8i0 Content-length: 9057 LS0tCgotLS0KIHJlbW90ZS5jIHwgIDEwOCArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCA5OCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlv bnMoLSkKCi0tLSBhL3JlbW90ZS5jCisrKyBiL3JlbW90ZS5jCkBAIC0yMjQs NiArMjI0LDExIEBAIHN0YXRpYyB2b2lkIHJlbW90ZV9xdWVyeV9zdXBwb3J0 ZWQgKHZvaWQKIAogc3RhdGljIHZvaWQgcmVtb3RlX2NoZWNrX3N5bWJvbHMg KHN0cnVjdCBvYmpmaWxlICpvYmpmaWxlKTsKIAorc3RhdGljIHZvaWQgKCph c3luY19jbGllbnRfY2FsbGJhY2spIChlbnVtIGluZmVyaW9yX2V2ZW50X3R5 cGUgZXZlbnRfdHlwZSwKKwkJCQkgICAgICB2b2lkICpjb250ZXh0KTsKK3N0 YXRpYyB2b2lkICphc3luY19jbGllbnRfY29udGV4dDsKK3N0YXRpYyBzZXJp YWxfZXZlbnRfZnR5cGUgcmVtb3RlX2FzeW5jX3NlcmlhbF9oYW5kbGVyOwor CiB2b2lkIF9pbml0aWFsaXplX3JlbW90ZSAodm9pZCk7CiAKIHN0cnVjdCBz dG9wX3JlcGx5OwpAQCAtMTI5Nyw2ICsxMzAyLDcgQEAgZW51bSB7CiAgIFBB Q0tFVF9RRGlzYWJsZVJhbmRvbWl6YXRpb24sCiAgIFBBQ0tFVF9RQWdlbnQs CiAgIFBBQ0tFVF9BdXRvbG9hZEJyZWFrcG9pbnRzLAorICBQQUNLRVRfTm90 aWZpY2F0aW9uQXN5bmMsCiAgIFBBQ0tFVF9NQVgKIH07CiAKQEAgLTM5OTgs NiArNDAwNCw4IEBAIHN0YXRpYyBzdHJ1Y3QgcHJvdG9jb2xfZmVhdHVyZSBy ZW1vdGVfcHIKICAgICByZW1vdGVfc3RyaW5nX3RyYWNpbmdfZmVhdHVyZSwg LTEgfSwKICAgeyAiQXV0b2xvYWRCcmVha3BvaW50cyIsIFBBQ0tFVF9ESVNB QkxFLCByZW1vdGVfc3VwcG9ydGVkX3BhY2tldCwKICAgICBQQUNLRVRfQXV0 b2xvYWRCcmVha3BvaW50cyB9LAorICB7ICJOb3RpZmljYXRpb25Bc3luYyIs IFBBQ0tFVF9ESVNBQkxFLCByZW1vdGVfc3VwcG9ydGVkX3BhY2tldCwKKyAg ICBQQUNLRVRfTm90aWZpY2F0aW9uQXN5bmMgfSwKIH07CiAKIHN0YXRpYyBj aGFyICpyZW1vdGVfc3VwcG9ydF94bWw7CkBAIC00MzU1LDYgKzQzNjMsMTAg QEAgcmVtb3RlX29wZW5fMSAoY2hhciAqbmFtZSwgaW50IGZyb21fdHR5LAog CiAgIGlmICh0YXJnZXRfYXN5bmNfcGVybWl0dGVkKQogICAgIHdhaXRfZm9y ZXZlcl9lbmFibGVkX3AgPSAxOworCisgIGlmIChyZW1vdGVfcHJvdG9jb2xf cGFja2V0c1tQQUNLRVRfTm90aWZpY2F0aW9uQXN5bmNdLnN1cHBvcnQKKwkg ICE9IFBBQ0tFVF9ESVNBQkxFKQorICAgIHNlcmlhbF9hc3luYyAocmVtb3Rl X2Rlc2MsIHJlbW90ZV9hc3luY19zZXJpYWxfaGFuZGxlciwgTlVMTCk7CiB9 CiAKIC8qIFRoaXMgdGFrZXMgYSBwcm9ncmFtIHByZXZpb3VzbHkgYXR0YWNo ZWQgdG8gYW5kIGRldGFjaGVzIGl0LiAgQWZ0ZXIKQEAgLTY5ODAsMTEgKzY5 OTIsMjAgQEAgcmVtb3RlX2ZpbGVzX2luZm8gKHN0cnVjdCB0YXJnZXRfb3Bz ICppZwogCiAvKiBSZWFkIGEgc2luZ2xlIGNoYXJhY3RlciBmcm9tIHRoZSBy ZW1vdGUgZW5kLiAgKi8KIAorc3RhdGljIGludCByZWFkY2hhcl9idWZmZXJf Y2ggPSAtMTsKKwogc3RhdGljIGludAogcmVhZGNoYXIgKGludCB0aW1lb3V0 KQogewogICBpbnQgY2g7CiAKKyAgaWYgKHJlYWRjaGFyX2J1ZmZlcl9jaCAh PSAtMSkKKyAgICB7CisgICAgICBjaCA9IHJlYWRjaGFyX2J1ZmZlcl9jaDsK KyAgICAgIHJlYWRjaGFyX2J1ZmZlcl9jaCA9IC0xOworICAgICAgcmV0dXJu IGNoOworICAgIH0KKwogICBjaCA9IHNlcmlhbF9yZWFkY2hhciAocmVtb3Rl X2Rlc2MsIHRpbWVvdXQpOwogCiAgIGlmIChjaCA+PSAwKQpAQCAtNjk5Myw4 ICs3MDE0LDEyIEBAIHJlYWRjaGFyIChpbnQgdGltZW91dCkKICAgc3dpdGNo ICgoZW51bSBzZXJpYWxfcmMpIGNoKQogICAgIHsKICAgICBjYXNlIFNFUklB TF9FT0Y6Ci0gICAgICBwb3BfdGFyZ2V0ICgpOwotICAgICAgZXJyb3IgKF8o IlJlbW90ZSBjb25uZWN0aW9uIGNsb3NlZCIpKTsKKyAgICAgIGlmICh0aW1l b3V0KQorICAgICAgICB7CisJICBwb3BfdGFyZ2V0ICgpOworCSAgZXJyb3Ig KF8oIlJlbW90ZSBjb25uZWN0aW9uIGNsb3NlZCIpKTsKKwl9CisgICAgICBi cmVhazsKICAgICAgIC8qIG5vIHJldHVybiAqLwogICAgIGNhc2UgU0VSSUFM X0VSUk9SOgogICAgICAgcG9wX3RhcmdldCAoKTsKQEAgLTcwMDcsNiArNzAz MiwxNyBAQCByZWFkY2hhciAoaW50IHRpbWVvdXQpCiAgIHJldHVybiBjaDsK IH0KIAorLyogV2hlbiB0aGUgZnVuY3Rpb24gdGhhdCBjYWxsIHRoZSByZWFk Y2hhciBnb3QgYSBjaGFyIGlzIG5vdCBmb3IgaXQKKyAgIGFuZCBvdGhlciBm dW5jdGlvbiBuZWVkIHRoaXMgY2hhcu+8jGNhbGwgdGhpcyBmdW5jdGlvbiB0 byBwdXQKKyAgIHRoaXMgY2hhciBiYWNrLiAgVGhlbiB3aGVuIG90aGVyIGZ1 bmN0aW9uIGNhbGwgcmVhZGNoYXIsIGl0IHdpbGwKKyAgIGdvdCB0aGlzIGNo YXIgZmlyc3QuICovCisKK3N0YXRpYyB2b2lkCityZWFkY2hhcl9idWZmZXJf cHV0IChpbnQgY2gpCit7CisgIHJlYWRjaGFyX2J1ZmZlcl9jaCA9IGNoOwor fQorCiAvKiBTZW5kIHRoZSBjb21tYW5kIGluICpCVUYgdG8gdGhlIHJlbW90 ZSBtYWNoaW5lLCBhbmQgcmVhZCB0aGUgcmVwbHkKICAgIGludG8gKkJVRi4g IFJlcG9ydCBhbiBlcnJvciBpZiB3ZSBnZXQgYW4gZXJyb3IgcmVwbHkuICBS ZXNpemUKICAgICpCVUYgdXNpbmcgeHJlYWxsb2MgaWYgbmVjZXNzYXJ5IHRv IGhvbGQgdGhlIHJlc3VsdCwgYW5kIHVwZGF0ZQpAQCAtNzUwNyw3ICs3NTQz LDExIEBAIGdldHBrdF9vcl9ub3RpZl9zYW5lXzEgKGNoYXIgKipidWYsIGxv bmcKIAkgICAgIHNob3cgdXAgd2l0aGluIHJlbW90ZV90aW1lb3V0IGludGVy dmFscy4gICovCiAJICBkbwogCSAgICBjID0gcmVhZGNoYXIgKHRpbWVvdXQp OwotCSAgd2hpbGUgKGMgIT0gU0VSSUFMX1RJTUVPVVQgJiYgYyAhPSAnJCcg JiYgYyAhPSAnJScpOworCSAgd2hpbGUgKGMgIT0gU0VSSUFMX1RJTUVPVVQg JiYgYyAhPSBTRVJJQUxfRU9GICYmIGMgIT0gJyQnCisJCSAmJiBjICE9ICcl Jyk7CisKKwkgIGlmIChjID09IFNFUklBTF9FT0YpCisJICAgIHJldHVybiAt MTsKIAogCSAgaWYgKGMgPT0gU0VSSUFMX1RJTUVPVVQpCiAJICAgIHsKQEAg LTExMjA3LDI1ICsxMTI0Nyw3MiBAQCByZW1vdGVfaXNfYXN5bmNfcCAodm9p ZCkKICAgICAvKiBXZSBvbmx5IGVuYWJsZSBhc3luYyB3aGVuIHRoZSB1c2Vy IHNwZWNpZmljYWxseSBhc2tzIGZvciBpdC4gICovCiAgICAgcmV0dXJuIDA7 CiAKKyAgaWYgKHJlbW90ZV9wcm90b2NvbF9wYWNrZXRzW1BBQ0tFVF9Ob3Rp ZmljYXRpb25Bc3luY10uc3VwcG9ydAorCSAgIT0gUEFDS0VUX0RJU0FCTEUp CisgICAgcmV0dXJuIGFzeW5jX2NsaWVudF9jYWxsYmFjayAhPSBOVUxMOwor CiAgIC8qIFdlJ3JlIGFzeW5jIHdoZW5ldmVyIHRoZSBzZXJpYWwgZGV2aWNl IGlzLiAgKi8KICAgcmV0dXJuIHNlcmlhbF9pc19hc3luY19wIChyZW1vdGVf ZGVzYyk7CiB9CiAKK3N0YXRpYyBpbnQKK3JlbW90ZV9pc19ub3RpZmljYXRp b25hc3luYyAodm9pZCkKK3sKKyAgaW50IGMgPSBzZXJpYWxfcmVhZGNoYXIg KHJlbW90ZV9kZXNjLCAwKTsKKworICBpZiAoYyA9PSAnJScpCisgICAgcmV0 dXJuIDE7CisKKyAgaWYgKGMgPj0gMCkKKyAgICByZWFkY2hhcl9idWZmZXJf cHV0IChjKTsKKyAgcmV0dXJuIDA7Cit9CisKIC8qIFBhc3MgdGhlIFNFUklB TCBldmVudCBvbiBhbmQgdXAgdG8gdGhlIGNsaWVudC4gIE9uZSBkYXkgdGhp cyBjb2RlCiAgICB3aWxsIGJlIGFibGUgdG8gZGVsYXkgbm90aWZ5aW5nIHRo ZSBjbGllbnQgb2YgYW4gZXZlbnQgdW50aWwgdGhlCiAgICBwb2ludCB3aGVy ZSBhbiBlbnRpcmUgcGFja2V0IGhhcyBiZWVuIHJlY2VpdmVkLiAgKi8KIAot c3RhdGljIHZvaWQgKCphc3luY19jbGllbnRfY2FsbGJhY2spIChlbnVtIGlu ZmVyaW9yX2V2ZW50X3R5cGUgZXZlbnRfdHlwZSwKLQkJCQkgICAgICB2b2lk ICpjb250ZXh0KTsKLXN0YXRpYyB2b2lkICphc3luY19jbGllbnRfY29udGV4 dDsKLXN0YXRpYyBzZXJpYWxfZXZlbnRfZnR5cGUgcmVtb3RlX2FzeW5jX3Nl cmlhbF9oYW5kbGVyOwotCiBzdGF0aWMgdm9pZAogcmVtb3RlX2FzeW5jX3Nl cmlhbF9oYW5kbGVyIChzdHJ1Y3Qgc2VyaWFsICpzY2IsIHZvaWQgKmNvbnRl eHQpCiB7Ci0gIC8qIERvbid0IHByb3BvZ2F0ZSBlcnJvciBpbmZvcm1hdGlv biB1cCB0byB0aGUgY2xpZW50LiAgSW5zdGVhZCBsZXQKLSAgICAgdGhlIGNs aWVudCBmaW5kIG91dCBhYm91dCB0aGUgZXJyb3IgYnkgcXVlcnlpbmcgdGhl IHRhcmdldC4gICovCi0gIGFzeW5jX2NsaWVudF9jYWxsYmFjayAoSU5GX1JF R19FVkVOVCwgYXN5bmNfY2xpZW50X2NvbnRleHQpOworICAvKiBDaGVjayBp ZiB0aGlzIGlzIFJlcG9ydEFzeW5jLiAgKi8KKyAgaWYgKHJlbW90ZV9pc19u b3RpZmljYXRpb25hc3luYyAoKSkKKyAgICB7CisgICAgICBpbnQgdmFsOwor ICAgICAgc3RydWN0IHJlbW90ZV9zdGF0ZSAqcnMgPSBnZXRfcmVtb3RlX3N0 YXRlICgpOworCisgICAgICB2YWwgPSByZWFkX2ZyYW1lICgmcnMtPmJ1Ziwg JnJzLT5idWZfc2l6ZSk7CisgICAgICBpZiAodmFsID49IDApCisJeworCSAg aWYgKHJlbW90ZV9kZWJ1ZykKKwkgICAgeworCSAgICAgIHN0cnVjdCBjbGVh bnVwICpvbGRfY2hhaW47CisJICAgICAgY2hhciAqc3RyOworCisJICAgICAg c3RyID0gZXNjYXBlX2J1ZmZlciAocnMtPmJ1ZiwgdmFsKTsKKwkgICAgICBv bGRfY2hhaW4gPSBtYWtlX2NsZWFudXAgKHhmcmVlLCBzdHIpOworCSAgICAg IGZwcmludGZfdW5maWx0ZXJlZCAoZ2RiX3N0ZGxvZywgIiAgTm90aWZpY2F0 aW9uIHJlY2VpdmVkOiAlc1xuIiwKKwkJCQkgIHN0cik7CisJICAgICAgZG9f Y2xlYW51cHMgKG9sZF9jaGFpbik7CisJICAgIH0KKwkgIGhhbmRsZV9ub3Rp ZmljYXRpb24gKHJzLT5idWYsIHZhbCk7CisJfQorICAgICAgZWxzZQorCXsK KwkgIGlmIChyZW1vdGVfZGVidWcpCisJICAgIHsKKwkgICAgICBmcHJpbnRm X3VuZmlsdGVyZWQgKGdkYl9zdGRsb2csICJwdXRwa3Q6IEp1bms6ICIpOwor CSAgICAgIGZwcmludGZfdW5maWx0ZXJlZCAoZ2RiX3N0ZGxvZywgIiUlJXMi LCBycy0+YnVmKTsKKwkgICAgfQorCX0KKyAgICB9CisgIGVsc2UKKyAgICB7 CisgICAgICAvKiBEb24ndCBwcm9wb2dhdGUgZXJyb3IgaW5mb3JtYXRpb24g dXAgdG8gdGhlIGNsaWVudC4gIEluc3RlYWQgbGV0CisgICAgICAgICB0aGUg Y2xpZW50IGZpbmQgb3V0IGFib3V0IHRoZSBlcnJvciBieSBxdWVyeWluZyB0 aGUgdGFyZ2V0LiAgKi8KKyAgICAgIGlmIChhc3luY19jbGllbnRfY2FsbGJh Y2spCisJYXN5bmNfY2xpZW50X2NhbGxiYWNrIChJTkZfUkVHX0VWRU5ULCBh c3luY19jbGllbnRfY29udGV4dCk7CisgICAgfQogfQogCiBzdGF0aWMgdm9p ZApAQCAtMTEyNDYsMTIgKzExMzMzLDE5IEBAIHJlbW90ZV9hc3luYyAodm9p ZCAoKmNhbGxiYWNrKSAoZW51bSBpbmYKIHsKICAgaWYgKGNhbGxiYWNrICE9 IE5VTEwpCiAgICAgewotICAgICAgc2VyaWFsX2FzeW5jIChyZW1vdGVfZGVz YywgcmVtb3RlX2FzeW5jX3NlcmlhbF9oYW5kbGVyLCBOVUxMKTsKKyAgICAg IGlmIChyZW1vdGVfcHJvdG9jb2xfcGFja2V0c1tQQUNLRVRfTm90aWZpY2F0 aW9uQXN5bmNdLnN1cHBvcnQKKwkgICAgICA9PSBQQUNLRVRfRElTQUJMRSkK KyAgICAgICAgc2VyaWFsX2FzeW5jIChyZW1vdGVfZGVzYywgcmVtb3RlX2Fz eW5jX3NlcmlhbF9oYW5kbGVyLCBOVUxMKTsKICAgICAgIGFzeW5jX2NsaWVu dF9jYWxsYmFjayA9IGNhbGxiYWNrOwogICAgICAgYXN5bmNfY2xpZW50X2Nv bnRleHQgPSBjb250ZXh0OwogICAgIH0KICAgZWxzZQotICAgIHNlcmlhbF9h c3luYyAocmVtb3RlX2Rlc2MsIE5VTEwsIE5VTEwpOworICAgIHsKKyAgICAg IGlmIChyZW1vdGVfcHJvdG9jb2xfcGFja2V0c1tQQUNLRVRfTm90aWZpY2F0 aW9uQXN5bmNdLnN1cHBvcnQKKwkgICAgICA9PSBQQUNLRVRfRElTQUJMRSkK KwlzZXJpYWxfYXN5bmMgKHJlbW90ZV9kZXNjLCBOVUxMLCBOVUxMKTsKKyAg ICAgIGFzeW5jX2NsaWVudF9jYWxsYmFjayA9IE5VTEw7CisgICAgfQogfQog CiBzdGF0aWMgdm9pZApAQCAtMTE3NjksNiArMTE4NjMsOSBAQCBTaG93IHRo ZSBtYXhpbXVtIHNpemUgb2YgdGhlIGFkZHJlc3MgKGluCiAgIGFkZF9wYWNr ZXRfY29uZmlnX2NtZCAoJnJlbW90ZV9wcm90b2NvbF9wYWNrZXRzW1BBQ0tF VF9BdXRvbG9hZEJyZWFrcG9pbnRzXSwKIAkJCSAiQXV0b2xvYWRCcmVha3Bv aW50cyIsICJhdXRvbG9hZC1icmVha3BvaW50cyIsIDApOwogCisgIGFkZF9w YWNrZXRfY29uZmlnX2NtZCAoJnJlbW90ZV9wcm90b2NvbF9wYWNrZXRzW1BB Q0tFVF9Ob3RpZmljYXRpb25Bc3luY10sCisJCQkgIk5vdGlmaWNhdGlvbkFz eW5jIiwgIm5vdGlmaWNhdGlvbi1hc3luYyIsIDApOworCiAgIC8qIEtlZXAg dGhlIG9sZCBgYHNldCByZW1vdGUgWi1wYWNrZXQgLi4uJycgd29ya2luZy4g IEVhY2ggaW5kaXZpZHVhbAogICAgICBaIHN1Yi1wYWNrZXQgaGFzIGl0cyBv d24gc2V0IGFuZCBzaG93IGNvbW1hbmRzLCBidXQgdXNlcnMgbWF5CiAgICAg IGhhdmUgc2V0cyB0byB0aGlzIHZhcmlhYmxlIGluIHRoZWlyIC5nZGJpbml0 IGZpbGVzIChvciBpbiB0aGVpcgo= --047d7b16371349aabe04c74eaceb--